From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB01641D8D for ; Mon, 27 Feb 2023 08:05:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6A59410DC; Mon, 27 Feb 2023 08:05:45 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58]) by mails.dpdk.org (Postfix) with ESMTP id 112DE40A84 for ; Mon, 27 Feb 2023 08:05:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nQXPyz5UnkGWNQ8/hWhFaAxa+OoLj7+yifQveDfDzwD3JyBsBlimFGLrKXwUjUWyzjiJWKimWb4D4X3CBJyjQj59JgFKzKLY8uxK+QpPuglyQX/u4N0JEJakzRVA1u18CSLqRaFL/tV1q/MXb4aZWQqNmOp0xmDvgcrMf7CrUInp6MhO+xDYUVFLQADFLgy/cLo2BUhPm+QStGvg6M2xVOS8NWESo3yqO0q2fpleB5qfuhsYgWoUX8ePmNCpv7dNpnS2B1cNzK2jKlQDaFFLz5RVRy7wHnKOK6XyidBxeO8V8ahwuwAgB6xixfTloliNGJll2r8cCwRSWRgQ4t+h9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l+x7OAHHY2v4E2GQjaFJauGr6YIlJ6YYtOYxs4ESzoE=; b=Wy2k3+Ittrubghd4Lmvc3S03GCIkbk0G4Afjp6bclAJqPN3iX0Ow8P2+tJ4shiaR8Q10Z0QTlbRv3NwEExoCNZwIdqeUQtQ0lJuabsxZqgA3fdMnuY1tBSvJOs2F8fai2sbdBPp1BKGuSkjaDpVCk/oei7eDTLBWrUp6SAJ0MQa+GMR2F5k3uFlRmZqSvZh2K0VXRBEDyoZ+HMQmgH/cAqoR6FP410MGvFIcQU24mv2jkCunUFcRg8+NlTARA6BEBtIXvaxP4wCsnVgzn8gvADwD/3Qm7EUemmZOZeDz2vWhP6gDCQDgnYf2r3PDDKL9KS8N0pXeE3A05TL4QuFQFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+x7OAHHY2v4E2GQjaFJauGr6YIlJ6YYtOYxs4ESzoE=; b=NrVM0SgiCDiX1VCogid6E9ZVoy02n6kO8DDZI2YcNDjpLF49b+89dOIykRhPwxDbZcHzzm6IIPXEpY3L+aYPXSG6ywKmBvCpdrR2bkit/IEwjTULkN0P/OvL4pn/u3ekjPSZLq8W6u/mUk6b/DF7ZXzTczb6A04E6n5ZxNGkwC/aLROM6gPzse9Ww/SBmZk9Mk9zfKm6ZWiC8v0nd8zg4DFgHMgL4aGel5y8siUXazyT2svIsIQdpN2zkjUz5L37oo0nJ0/OYLkZZvS8z9UKHZ/X5PnVdbGwbdhvi8qV7U1aI81Z0fv6sH3QEUENrk+CGXBV71T0RfbJ6/v78BiCsg== Received: from MW4PR04CA0179.namprd04.prod.outlook.com (2603:10b6:303:85::34) by DM4PR12MB6133.namprd12.prod.outlook.com (2603:10b6:8:ae::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 07:05:42 +0000 Received: from CO1NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:303:85:cafe::5c) by MW4PR04CA0179.outlook.office365.com (2603:10b6:303:85::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27 via Frontend Transport; Mon, 27 Feb 2023 07:05:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT048.mail.protection.outlook.com (10.13.175.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.12 via Frontend Transport; Mon, 27 Feb 2023 07:05:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:05:24 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:05:20 -0800 From: Xueming Li To: Andy Pei CC: Maxime Coquelin , dpdk stable Subject: patch 'vdpa/ifc: fix argument compatibility check' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:59:08 +0800 Message-ID: <20230227070107.15664-40-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT048:EE_|DM4PR12MB6133:EE_ X-MS-Office365-Filtering-Correlation-Id: f613178b-5243-4003-7b36-08db189109fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gF1IQcZUO4WHrEIm/ABAlPMdXNoZ7VCB/sQHNCwLCQfgW95T63qKaNOvsNaXK4EQvr4hIP7zJbKutnaM2WrtkmPpJDmo1A6/g0mjUbxDMYRObil2glfa9Bp0JUApmguIkYE6Dhp0sMXxPFpzt3BQP6kxFEXOuD2O3P+wuDHFlnWdYfznNpM9gNKfDZmjghRjzlhFnmh8gAAoLGPVzupDUXroOVRlmBXSdjggBKOosihykqaHBIq6XUIjv17f64cntz5WStgxKmtonYUP8ejK0acrBGEP6FA8xQnr0TREBZ/gq6R6lzykczpdHCrUwYaLsZ3oVXKZ3M5kNWGpY6f33rAR8sdPSe3upvPhWG2+BvS4HSY4tW95AY8TSSxv0S4stL0rDH+4+kuNIwPxfWL5WZ4Pek2pFI9PsdkcPYuVhfVhtWRqOzd67EIkIGu0v06lPmFFaAQgE+sJtsnXoxhnkLl/dvcclN/fuVNw370w9maXq6Ib1I7v6+jBX+fZjzKxwSm9tqWaN36ezypUIku96YO3/Uj6qT7iFJJ4dtrJ3huGp6ab1VSZvoqk2VmdgGr7kD+LUB7CQ6FEZq3RE3t+i7JjcO7P72fjl3nmMebL/4zoQDrNEINkXnJK+bqaKaZc4Ny6V838qxYP+NysatIKeqRNKp/vE3Pxugf9+1uWW8hShXfUoEt4+SmLf+pl0GcqSOX3agsE5ZTwiwp/RzHuqNB82/uArgjo2mHJDLeTU5dXtBwlRbFJGLz5fLYApn48v/xJywLSSmJSggvuepGKKuuDh5QPuGBuhQ1pdpPCZkqpXb7sYISLps8tymyde7Us X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(376002)(346002)(39860400002)(396003)(451199018)(46966006)(40470700004)(36840700001)(2906002)(4326008)(6916009)(41300700001)(8936002)(70206006)(70586007)(8676002)(40480700001)(316002)(36756003)(336012)(426003)(86362001)(54906003)(478600001)(5660300002)(26005)(16526019)(53546011)(6286002)(1076003)(55016003)(186003)(7696005)(966005)(2616005)(34020700004)(40460700003)(6666004)(47076005)(36860700001)(83380400001)(7636003)(82310400005)(82740400003)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:05:41.8517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f613178b-5243-4003-7b36-08db189109fc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6133 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=a347909ae202aff278a619e5b692b43eb5c55d33 Thanks. Xueming Li --- >From a347909ae202aff278a619e5b692b43eb5c55d33 Mon Sep 17 00:00:00 2001 From: Andy Pei Date: Thu, 1 Dec 2022 15:32:20 +0800 Subject: [PATCH] vdpa/ifc: fix argument compatibility check Cc: Xueming Li [ upstream commit 97d2dfc4e15caf654eb84ede24f4c1a43793e850 ] "sw_fallback_lm=0" means driver does not provide live migration assistance. so hardware assistance is needed to support live migration. However registers for live migration in BAR4 are not implemented. In the case, we just return error after display some logs. Fixes: 4c3f55cc23ea ("net/ifc: add LM mode parameter") Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 49d68ad1b1..9468f66638 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c @@ -1746,6 +1746,11 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, goto error; } internal->sw_lm = sw_fallback_lm; + if (!internal->sw_lm && !internal->hw.lm_cfg) { + DRV_LOG(ERR, "Device %s does not support HW assist live migration, please enable sw-live-migration!", + pci_dev->name); + goto error; + } pthread_mutex_lock(&internal_list_lock); TAILQ_INSERT_TAIL(&internal_list, list, next); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:42.230197000 +0800 +++ 0041-vdpa-ifc-fix-argument-compatibility-check.patch 2023-02-27 14:08:40.749237000 +0800 @@ -1 +1 @@ -From 97d2dfc4e15caf654eb84ede24f4c1a43793e850 Mon Sep 17 00:00:00 2001 +From a347909ae202aff278a619e5b692b43eb5c55d33 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 97d2dfc4e15caf654eb84ede24f4c1a43793e850 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org