From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2629641D8D for ; Mon, 27 Feb 2023 08:06:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2247B410DC; Mon, 27 Feb 2023 08:06:45 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by mails.dpdk.org (Postfix) with ESMTP id 5DE3B40A84 for ; Mon, 27 Feb 2023 08:06:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OU7qRjSipvUTUrxr10QisgDAp22Do/KDsKMm18rqLTOtBxF9dQFbeVVQQ/1s0cVpVNErt6MSxk9j3Uv9Gfv+MBR7rOyd7t0HX8TEzZUaBo0/sasU4MVb/Wgaf4eLqoHCWYPJby7/HhGtLX6C6d2TpJ3EIzZIG0YUb8tca/WHPx1wVNhp27nrE1iOPFTS2C79qJ0a3u4LHTS2LU5b9MolRCzCHxk37JRNITJLg0N1P4keNes6N6jAI4qzT2Adj+WtTJMJplBGQLnSN16QVK26KUDKGoN1zIxKN3b7AyTqbNpL/zDkz7nnSlF6vlkFjVn0QzL5nEC7wOlcJX3ERgzL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PaMRrqs6ahHRCkMVja72lU02silwAHY02+M7Ob9Mo5Q=; b=E5uE2Y+aIpf2drGn8/tvzbJR2gmds9qDZhuDQVnPUmRHFzwVkq43UNjiWMbp6OHnc9INQGxNgpz+tZZk8sKOf1wPX3jduZ2RewyWqNUBUql+y6nAOKG5R6zNvLiHtTVvvMfQK6ILhdDld9WJsk/YrXgu94OPiYVR+i/OwngbbFGNNHYC6MkdLqpDZoVpbTVn5GzrzEhaqSpM6AJwrZkyBAELWHFQm7OjDC69snUqRfjp7wiTeYRE0MxjeuNzvqGvSfvxjONNl84kXI1hDXMBA3i7lWva9DeSpqZb2nyDq+oTsx7EOyhA+64abxd2zgcHT7a4shMZINJmi0fXzUEmnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PaMRrqs6ahHRCkMVja72lU02silwAHY02+M7Ob9Mo5Q=; b=d3oxMrWEasmDeKv/gyD2eODb9VQN1Ap4uz5b5rzhQykPX3XP1P7zr0B1HG0fnA7vArgiurFYBagmCesrosMTyYjJBDHNx/2DCRDyk5U9M2B3YCCKpXr0y50vbP/blAQX8UII7PrMpCHiSW7e6vl3g5xOuVt01eVe14d7ld8QzVxZ9xnY3un6iQdqGUatiZCCZ3/0VmaaFpBsxwCxvROerIO0P5//ld4wzUS1L/LlVBCs7dDUxVMolMbiks/i8YSJUCc1lSZgFHcRDxkwLmYNhyxJFBkVE8h5n58fVBbIxHqCzMXXjoK+5wmP93bJk2RjpxWk/phclo8Ya3TRMLlK0w== Received: from MW2PR16CA0059.namprd16.prod.outlook.com (2603:10b6:907:1::36) by DM6PR12MB4331.namprd12.prod.outlook.com (2603:10b6:5:21a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 07:06:41 +0000 Received: from CO1NAM11FT013.eop-nam11.prod.protection.outlook.com (2603:10b6:907:1:cafe::26) by MW2PR16CA0059.outlook.office365.com (2603:10b6:907:1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 07:06:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT013.mail.protection.outlook.com (10.13.174.227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.16 via Frontend Transport; Mon, 27 Feb 2023 07:06:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:06:28 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:06:25 -0800 From: Xueming Li To: David Marchand CC: Sunil Uttarwar , dpdk stable Subject: patch 'crypto/ccp: remove some printf' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:59:18 +0800 Message-ID: <20230227070107.15664-50-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT013:EE_|DM6PR12MB4331:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b6b7fc7-0c39-4bd4-77b1-08db18912d9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 47GBwdHkOhTCjDMjoiTyAKR+kCdeRID+0mUdowLK/p29rwTzf5T2S4UNEtXHHJXMRNOFkFT7M0QehlkXduRujX60xOWxK1LYpIS2FMMEd4qVSQ0HLYERDtO47jYPBSGKTe9A0atnWQi5wag1XBQAgFbM0onJdiuC/3Mgq5K2sK/OJRb9SI7JpXZSmzPJHcsZhm0SHE8ZqtvjrOPMpXldwKDJ8NJwGeyjr4pRf2FTH5KBG3AqECWNKs2WYIvz3iKnQMnnLvPzvWm/Kkbk6JFv4ONFv8cabDzC4Ukr4RXKCEn/GKBn0HhAqGe3DTmBPCSMpspsU3pN7Vd5Jed1ZknjvenoYkThCWXRRspHFKeRXcIGPDT2z3/pSPVfQjx1JcGUx64UmXZhQiQpnPAZ0GVQ38LE6MBOLlYeXGvbBvkvkUd+01PBxAdyuzl8srh80lygoW/Zi0A7ZQ4nlRcPwSvhGC0E6gnQ6a02Fi34LIoywC+pK40go6zI7sc9W06z6h2rtOFTgxNy1q3T1ptWb04XEQKljPDICXd07tMgBu7LEMRxDgYljhgTp/dGyYb5JoMQog0jKRI3Prl1PsjIT6o4SoC47vldTCE51rO3DzoquZunjpCY9Ubp2+r9TGb8bFqUayupsBECk5etScZCDoLS5FfeJm/pfNycqdD/DOTmdQseKBpMepwNR8g7sHLNR9uAmTiii/VHmfZJ4E1OjQ1r3JN3Eu5jXaoEfDk7u5CVVioRT5SO9NWIsIOw0DmDbTvWuNJgv8vcazVT1J/D//HC5KTdAcunCCzEFKHdXDuSesJs12fr1RQnD8AskDm7+EMV X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199018)(36840700001)(40470700004)(46966006)(83380400001)(2906002)(426003)(47076005)(2616005)(82310400005)(34020700004)(70586007)(478600001)(6916009)(8676002)(356005)(70206006)(53546011)(16526019)(36860700001)(6286002)(186003)(26005)(4326008)(5660300002)(1076003)(8936002)(82740400003)(336012)(7636003)(6666004)(41300700001)(36756003)(966005)(54906003)(7696005)(40460700003)(40480700001)(86362001)(55016003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:06:41.6113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6b7fc7-0c39-4bd4-77b1-08db18912d9d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT013.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4331 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=4e76b627566902b8b8667e52cac950ad34eb7f22 Thanks. Xueming Li --- >From 4e76b627566902b8b8667e52cac950ad34eb7f22 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 4 Oct 2022 11:51:29 +0200 Subject: [PATCH] crypto/ccp: remove some printf Cc: Xueming Li [ upstream commit e946ca8e727424b511fe4ea278d8bec76b800e7a ] A DPDK application must _not_ use printf. Use log framework. Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") Signed-off-by: David Marchand Acked-by: Sunil Uttarwar --- drivers/crypto/ccp/ccp_dev.c | 4 ++-- drivers/crypto/ccp/ccp_pci.c | 3 ++- drivers/crypto/ccp/rte_ccp_pmd.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index 424ead82c3..9c9cb81236 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -362,7 +362,7 @@ ccp_find_lsb_regions(struct ccp_queue *cmd_q, uint64_t status) if (ccp_get_bit(&cmd_q->lsbmask, j)) weight++; - printf("Queue %d can access %d LSB regions of mask %lu\n", + CCP_LOG_DBG("Queue %d can access %d LSB regions of mask %lu\n", (int)cmd_q->id, weight, cmd_q->lsbmask); return weight ? 0 : -EINVAL; @@ -709,7 +709,7 @@ ccp_probe_devices(struct rte_pci_device *pci_dev, snprintf(dirname, sizeof(dirname), "%s/%s", SYSFS_PCI_DEVICES, d->d_name); if (is_ccp_device(dirname, ccp_id, &ccp_type)) { - printf("CCP : Detected CCP device with ID = 0x%x\n", + CCP_LOG_DBG("CCP : Detected CCP device with ID = 0x%x\n", ccp_id[ccp_type].device_id); ret = ccp_probe_device(ccp_type, pci_dev); if (ret == 0) diff --git a/drivers/crypto/ccp/ccp_pci.c b/drivers/crypto/ccp/ccp_pci.c index 38029a9081..c941e222c7 100644 --- a/drivers/crypto/ccp/ccp_pci.c +++ b/drivers/crypto/ccp/ccp_pci.c @@ -11,6 +11,7 @@ #include #include "ccp_pci.h" +#include "ccp_pmd_private.h" static const char * const uio_module_names[] = { "igb_uio", @@ -41,7 +42,7 @@ ccp_check_pci_uio_module(void) rewind(fp); } fclose(fp); - printf("Insert igb_uio or uio_pci_generic kernel module(s)"); + CCP_LOG_DBG("Insert igb_uio or uio_pci_generic kernel module(s)"); return -1;/* uio not inserted */ } diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index 221a0a5235..bcb621234c 100644 --- a/drivers/crypto/ccp/rte_ccp_pmd.c +++ b/drivers/crypto/ccp/rte_ccp_pmd.c @@ -237,7 +237,7 @@ cryptodev_ccp_create(const char *name, goto init_error; } - printf("CCP : Crypto device count = %d\n", cryptodev_cnt); + CCP_LOG_DBG("CCP : Crypto device count = %d\n", cryptodev_cnt); dev->device = &pci_dev->device; dev->device->driver = &pci_drv->driver; dev->driver_id = ccp_cryptodev_driver_id; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:42.556945200 +0800 +++ 0051-crypto-ccp-remove-some-printf.patch 2023-02-27 14:08:40.769237000 +0800 @@ -1 +1 @@ -From e946ca8e727424b511fe4ea278d8bec76b800e7a Mon Sep 17 00:00:00 2001 +From 4e76b627566902b8b8667e52cac950ad34eb7f22 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e946ca8e727424b511fe4ea278d8bec76b800e7a ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org