From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49B1241D64 for ; Mon, 27 Feb 2023 08:07:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F0BB410EE; Mon, 27 Feb 2023 08:07:24 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04hn2248.outbound.protection.outlook.com [52.100.161.248]) by mails.dpdk.org (Postfix) with ESMTP id 8029140A7D for ; Mon, 27 Feb 2023 08:07:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3I2OEcD1g7Yy0GDCVCVcM32VY703ricfoTYkoov6TWe+zdiGqjy//57RYgmpb7ebfXSUPBgB0xZsTqtQSO3mZ82oMghOSJD7edvjUAz4pHDijoD3BT3/ih8chUdXt5x/uyLQfXeXrc5Gax2KrEOV+EJqu9ehoQwGl7BNngSJhBZ9ekpq3G/SAByKO8+OyvkKCMVp1DNeQFl+abJXg935Df0v7tUn8kSh3V98lNa7sVSVtGaEUkGp4O77yXLYAL66m09xb/pTh9HBd2binwRsmbMQHXNYHIM8/myzmQ2Z05U1MED18cYIHfIuibcQyEQcxqJdVIC3aCTl/waNUxHZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dhDY5PDP1M7TCBKqQ2L9NPth/EJ+8mr7/o5ISpm+qM4=; b=hdtxMZpizLp45PB0ItHxtOS27+MxTSMSf0TnltBLYMGVc6je09tDorx78deeih7NA7s+Ri/YUfiRS2zrZIsKFGpE01/DPmWnES36+3Lspxm2LciGBRb1S6pQfDgtqursUu8vDvOMfF3yPv6rK6YM1C1dJuBMheanwxtgWOxXfjtS+TvOzvinIGwNN8jaLrqcmQoU3p/acp+KaqCmuMmV8kcRmg0dZxuYSHY6tgizTD2yYeXNqt/vpXe+5OvdSiQ8Q3RxZA1nxuYtmtxXfBPlUA05RRgScNCgUpPYOi+GdaWUPIpgz383ghP8nNu5oHCczQof3XN1Y89MCREjejJx1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dhDY5PDP1M7TCBKqQ2L9NPth/EJ+8mr7/o5ISpm+qM4=; b=h3NOnz54aRzpaQ/wNNHxHPv8E2fQuZ8R0EHyjtGAn6LRCvaLAmUCGI41XijFgdt7QzZ/k5ts1Hy9DsGzGdP8zKNCJeeU46B9a6q6RCEqn7ffXGu+yyyUaPEyw4YPGzILTunOaBA40nZ7u4ceLwaY16JrShgraov7hcmT5Ee+eDnYFQjWy7Kp0EaFose9gmuaDpQjyIHAWrVsTJAceWH+PFyIRuihbb7ia68LPutCmk4aw/fbjwKpymxt0q1JYu/wPaRJ6dK62heU+542saDWx6N8lD3nt2Jp3oiMM2rSR3c3WYLa4FDdBWqjX7JXI2XjURnr15vYK0oQomVQwUeDvA== Received: from MW4PR04CA0240.namprd04.prod.outlook.com (2603:10b6:303:87::35) by PH7PR12MB5653.namprd12.prod.outlook.com (2603:10b6:510:132::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 07:07:20 +0000 Received: from CO1NAM11FT043.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::17) by MW4PR04CA0240.outlook.office365.com (2603:10b6:303:87::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.29 via Frontend Transport; Mon, 27 Feb 2023 07:07:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT043.mail.protection.outlook.com (10.13.174.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.14 via Frontend Transport; Mon, 27 Feb 2023 07:07:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Sun, 26 Feb 2023 23:06:58 -0800 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 26 Feb 2023 23:06:55 -0800 From: Xueming Li To: Stephen Hemminger CC: Tyler Retzlaff , Fan Zhang , Kai Ji , dpdk stable Subject: patch 'crypto/ipsec_mb: remove unnecessary null check' has been queued to stable release 22.11.2 Date: Mon, 27 Feb 2023 14:59:22 +0800 Message-ID: <20230227070107.15664-54-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230227070107.15664-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230227070107.15664-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT043:EE_|PH7PR12MB5653:EE_ X-MS-Office365-Filtering-Correlation-Id: a38ba06f-74af-47cb-4634-08db1891449d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mxfnAfNY87KZINNJZJ6qwNucQAw6y6RL2rwKqjrzLZVxM4fQot1c+QKT6APacvDozUrqFVXXpH5MbN46FlYi8Fdufjrz8YaDlwQca+81ipWucB1oHwW/e3Nf5Z9vDlGH4MC375xb8VhTvYwOSG1m+YTOLuTtwEzCgE1QvyKAn9cQ7Xk6i6SAfI/sMO3g71Fkk2Z8igPbiCTURb2xuvzd6OZ6yQ/0+F9NR7rCPb3uaWiPPhctT3dW9t8wH4UFsoJoxAS3w4Qhfl1JyNH5uAe/AfFNwLHByOry+wf4niMDyAD9w1fwWIfl3X9rWMTSnahzv2UAjk1ZBodU+s5Nrn+rCxcg+opL1TVK835SraJ+L8K7aKiR03lkG8pRbF6XdhEC6B+GNUarj79FbP0neEkwWaNgyGFEJXM0HcLzxr0aPENVFOJsrqhGIsAmX08oF+oWe9uStBTLt5zml5/o/7BqLTVNnt/6+r1wy19ky1NG9r1ylxIqvRRVZSMayocDBVYg/xg8B20OhKO2Aejz7lPOMzGM2c7zfXnTXPzm+4uhQCKkmdqttQ9Rrdw3v/zxNkpOg//C27aTo76FM6o49sHnaOF1dbHDnR45rCSqsYuByPfFRrkA9yh6/Y1eHeuwOik0D2FVfyqS5ei5oxAMWX/R07ubZanoIXR2ePtDYNoJDc56GWfL2zCp18D9XfG8dd0p5p2knJrBTuZGMCIThAxAvgCZQ0mPhwduTDatqRU2ul3Jq+/t9EuulaBNglsA6VS3NVDljKKxxU33vOR4L2X03mGpAbPLOKXMgCVMSUIKH7odPVW0IwILdISrpxZCO4C4LVA0m2PH4kQinW7/lR9OTZ7uDfqY1qYYzv98NnN1Sg0= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(376002)(346002)(451199018)(5400799012)(40470700004)(46966006)(36840700001)(6286002)(186003)(16526019)(40460700003)(82740400003)(7636003)(83380400001)(316002)(356005)(8936002)(6916009)(8676002)(4326008)(41300700001)(70206006)(336012)(2906002)(5660300002)(70586007)(34020700004)(36860700001)(6666004)(7696005)(55016003)(40480700001)(478600001)(1076003)(426003)(26005)(53546011)(47076005)(966005)(2616005)(36756003)(82310400005)(86362001)(54906003)(12100799018); DIR:OUT; SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 07:07:20.1977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a38ba06f-74af-47cb-4634-08db1891449d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT043.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5653 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/01/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=11f862d6051c0225043c55cd1aed9d169e54b73b Thanks. Xueming Li --- >From 11f862d6051c0225043c55cd1aed9d169e54b73b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 13 Jan 2023 10:44:25 -0800 Subject: [PATCH] crypto/ipsec_mb: remove unnecessary null check Cc: Xueming Li [ upstream commit 2245ccf74674e73dc4352fa348f0aa3958dcd67a ] The function rte_ring_free() accepts NULL as valid input like free() and other functions. Found with null_free_check.cocci. Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Fan Zhang Acked-by: Kai Ji --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 71e02cd051..3e52f95674 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -139,15 +139,12 @@ int ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) { struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id]; - struct rte_ring *r = NULL; if (!qp) return 0; if (rte_eal_process_type() == RTE_PROC_PRIMARY) { - r = rte_ring_lookup(qp->name); - if (r) - rte_ring_free(r); + rte_ring_free(rte_ring_lookup(qp->name)); #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM if (qp->mb_mgr) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-02-27 14:08:42.676390000 +0800 +++ 0055-crypto-ipsec_mb-remove-unnecessary-null-check.patch 2023-02-27 14:08:40.779237000 +0800 @@ -1 +1 @@ -From 2245ccf74674e73dc4352fa348f0aa3958dcd67a Mon Sep 17 00:00:00 2001 +From 11f862d6051c0225043c55cd1aed9d169e54b73b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2245ccf74674e73dc4352fa348f0aa3958dcd67a ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org