* [PATCH v1 1/2] test/bbdev: fix possible div by zero issue [not found] <20230309033624.61660-1-hernan.vargas@intel.com> @ 2023-03-09 3:36 ` Hernan Vargas 2023-03-16 14:09 ` Maxime Coquelin 2023-03-09 3:36 ` [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue Hernan Vargas 1 sibling, 1 reply; 4+ messages in thread From: Hernan Vargas @ 2023-03-09 3:36 UTC (permalink / raw) To: dev, gakhil, trix, maxime.coquelin Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, Hernan Vargas, stable Add extra check at function level to ensure num_ops cannot be 0. Coverity issue: 383647 Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index e56d314e93b5..15ebcdfc1556 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -3722,6 +3722,7 @@ bler_pmd_lcore_ldpc_dec(void *arg) TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), "BURST_SIZE should be <= %u", MAX_BURST); + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); rte_bbdev_info_get(tp->dev_id, &info); @@ -3856,6 +3857,7 @@ bler_pmd_lcore_turbo_dec(void *arg) TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), "BURST_SIZE should be <= %u", MAX_BURST); + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); rte_bbdev_info_get(tp->dev_id, &info); -- 2.37.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/2] test/bbdev: fix possible div by zero issue 2023-03-09 3:36 ` [PATCH v1 1/2] test/bbdev: fix possible div by zero issue Hernan Vargas @ 2023-03-16 14:09 ` Maxime Coquelin 0 siblings, 0 replies; 4+ messages in thread From: Maxime Coquelin @ 2023-03-16 14:09 UTC (permalink / raw) To: Hernan Vargas, dev, gakhil, trix Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, stable On 3/9/23 04:36, Hernan Vargas wrote: > Add extra check at function level to ensure num_ops cannot be 0. > > Coverity issue: 383647 > Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> > --- > app/test-bbdev/test_bbdev_perf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index e56d314e93b5..15ebcdfc1556 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -3722,6 +3722,7 @@ bler_pmd_lcore_ldpc_dec(void *arg) > > TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), > "BURST_SIZE should be <= %u", MAX_BURST); > + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); > > rte_bbdev_info_get(tp->dev_id, &info); > > @@ -3856,6 +3857,7 @@ bler_pmd_lcore_turbo_dec(void *arg) > > TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST), > "BURST_SIZE should be <= %u", MAX_BURST); > + TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0"); > > rte_bbdev_info_get(tp->dev_id, &info); > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue [not found] <20230309033624.61660-1-hernan.vargas@intel.com> 2023-03-09 3:36 ` [PATCH v1 1/2] test/bbdev: fix possible div by zero issue Hernan Vargas @ 2023-03-09 3:36 ` Hernan Vargas 2023-03-16 14:10 ` Maxime Coquelin 1 sibling, 1 reply; 4+ messages in thread From: Hernan Vargas @ 2023-03-09 3:36 UTC (permalink / raw) To: dev, gakhil, trix, maxime.coquelin Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, Hernan Vargas, stable Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> --- app/test-bbdev/test_bbdev_perf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 15ebcdfc1556..276bbf0a2e6d 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -5679,7 +5679,7 @@ static int offload_cost_test(struct active_device *ad, struct test_op_params *op_params) { - int iter; + int iter, ret; uint16_t burst_sz = op_params->burst_sz; const uint16_t num_to_process = op_params->num_to_process; const enum rte_bbdev_op_type op_type = test_vector.op_type; @@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, rte_get_tsc_hz()); struct rte_bbdev_stats stats = {0}; - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + TEST_ASSERT_SUCCESS(ret, + "Failed to get stats for queue (%u) of device (%u)", + queue_id, ad->dev_id); if (stats.enqueue_warn_count > 0) printf("Warning reported on the queue : %10"PRIu64"\n", stats.enqueue_warn_count); -- 2.37.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue 2023-03-09 3:36 ` [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue Hernan Vargas @ 2023-03-16 14:10 ` Maxime Coquelin 0 siblings, 0 replies; 4+ messages in thread From: Maxime Coquelin @ 2023-03-16 14:10 UTC (permalink / raw) To: Hernan Vargas, dev, gakhil, trix Cc: nicolas.chautru, qi.z.zhang, john.mcnamara, stable On 3/9/23 04:36, Hernan Vargas wrote: > Add check for return value from get_bbdev_queue_stats. > > Coverity issue: 383155 > Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> > --- > app/test-bbdev/test_bbdev_perf.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 15ebcdfc1556..276bbf0a2e6d 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -5679,7 +5679,7 @@ static int > offload_cost_test(struct active_device *ad, > struct test_op_params *op_params) > { > - int iter; > + int iter, ret; > uint16_t burst_sz = op_params->burst_sz; > const uint16_t num_to_process = op_params->num_to_process; > const enum rte_bbdev_op_type op_type = test_vector.op_type; > @@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, > rte_get_tsc_hz()); > > struct rte_bbdev_stats stats = {0}; > - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); > + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); > + TEST_ASSERT_SUCCESS(ret, > + "Failed to get stats for queue (%u) of device (%u)", > + queue_id, ad->dev_id); > if (stats.enqueue_warn_count > 0) > printf("Warning reported on the queue : %10"PRIu64"\n", > stats.enqueue_warn_count); Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Thanks, Maxime ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-16 14:10 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230309033624.61660-1-hernan.vargas@intel.com> 2023-03-09 3:36 ` [PATCH v1 1/2] test/bbdev: fix possible div by zero issue Hernan Vargas 2023-03-16 14:09 ` Maxime Coquelin 2023-03-09 3:36 ` [PATCH v1 2/2] test/bbdev: fix unchecked ret value issue Hernan Vargas 2023-03-16 14:10 ` Maxime Coquelin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).