From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EEE141E9F for ; Wed, 15 Mar 2023 15:36:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A7B140A7A; Wed, 15 Mar 2023 15:36:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AE95640141 for ; Wed, 15 Mar 2023 15:36:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0wkZCNKKehgBsZIQ9ziJLuFlsIfowSNffF0mGn7IEBA=; b=ZgSnRM+6s+JwztFsdkNGPrgbh+OGBR17DCyh4kdCxMgMJosn8sk0sJ2h9NgrwMf3DzARhj T3/sywRfqhhX+5Qou4GomNfpJQJtHHzJoco/9VhASv+EGezP5XYFnAcApnQWYFkU/Z9QKd nUi8dsB0Wu+omyo47qJqlBaSyFpG/rY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-344-iZxIviaWMvaNvbJ3ispnUw-1; Wed, 15 Mar 2023 10:36:49 -0400 X-MC-Unique: iZxIviaWMvaNvbJ3ispnUw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 62511884623; Wed, 15 Mar 2023 14:36:48 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2F4A40C6E69; Wed, 15 Mar 2023 14:36:47 +0000 (UTC) From: Kevin Traynor To: Thomas Monjalon Cc: Tyler Retzlaff , dpdk stable Subject: patch 'eal/windows: fix pedantic build' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:35:54 +0000 Message-Id: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0bc981bfdf8a2c636c415be2b7fc35d72ef33dfc Thanks. Kevin --- >From 0bc981bfdf8a2c636c415be2b7fc35d72ef33dfc Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 5 Jan 2023 16:18:38 +0100 Subject: [PATCH] eal/windows: fix pedantic build [ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] MinGW GCC 12 shows an illegal pointer conversion when included in a pedantic module: lib/eal/windows/include/pthread.h:137:41: error: ISO C forbids conversion of object pointer to function pointer type [-Werror=pedantic] 137 | hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, | ^ By using uintptr_t, the compiler is forced to accept the conversion. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Signed-off-by: Thomas Monjalon Acked-by: Tyler Retzlaff --- lib/eal/windows/include/pthread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eal/windows/include/pthread.h b/lib/eal/windows/include/pthread.h index 27fd2cca52..f7cf0e9ddf 100644 --- a/lib/eal/windows/include/pthread.h +++ b/lib/eal/windows/include/pthread.h @@ -135,5 +135,6 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc, RTE_SET_USED(threadattr); HANDLE hThread; - hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, + hThread = CreateThread(NULL, 0, + (LPTHREAD_START_ROUTINE)(uintptr_t)threadfunc, args, 0, (LPDWORD)threadid); if (hThread) { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.644678117 +0000 +++ 0001-eal-windows-fix-pedantic-build.patch 2023-03-15 14:30:20.529123504 +0000 @@ -1 +1 @@ -From 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b Mon Sep 17 00:00:00 2001 +From 0bc981bfdf8a2c636c415be2b7fc35d72ef33dfc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org