From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C200841E9F for ; Wed, 15 Mar 2023 15:37:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEFE842C4D; Wed, 15 Mar 2023 15:37:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CF9F240A7A for ; Wed, 15 Mar 2023 15:37:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l4NxanRu93SrjyV7BZ3EkUPQB0GR1HgiIRAQBKKjVCE=; b=fFi2rktfscfjA0HdJ66qidbAdvtubUjwglr/6RExd09QKHGwprSPDxi0HZ9qfhEK2ZYDuS UYxA3NhzE3cbK/k5kfIeFk6ynjvlnOV8dBWsqXxNiN0aVfaqFUzVVZ/1XsStDl6N+A/jSv 8JTckUI2YrBFjDh56X1Qyv0B48fZVzs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-302-3ke5HXrePf6EjRS5OmyKkQ-1; Wed, 15 Mar 2023 10:37:03 -0400 X-MC-Unique: 3ke5HXrePf6EjRS5OmyKkQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F809185A7A3; Wed, 15 Mar 2023 14:36:58 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9193040C6E67; Wed, 15 Mar 2023 14:36:57 +0000 (UTC) From: Kevin Traynor To: Michael Baum Cc: Matan Azrad , dpdk stable Subject: patch 'compress/mlx5: fix decompress xform validation' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:04 +0000 Message-Id: <20230315143640.677317-11-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/cb240b164c16f985675809c2594ff635979b32d2 Thanks. Kevin --- >From cb240b164c16f985675809c2594ff635979b32d2 Mon Sep 17 00:00:00 2001 From: Michael Baum Date: Tue, 21 Feb 2023 09:07:49 +0200 Subject: [PATCH] compress/mlx5: fix decompress xform validation [ upstream commit 12b4c48512326e810a5001f105287ee5c6fc6705 ] In xform creation, it first validate the xform according the capabilities. One of validations verifies that given "hash_algo" is "RTE_COMP_HASH_ALGO_NONE" for both compress and decompress xform objects. However, the validation for decompress checks it again for compress xform object. This patch changes it to verify decompress xform object. Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 14365ec020..8d92ed492e 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -315,5 +315,5 @@ mlx5_compress_xform_create(struct rte_compressdev *dev, return -ENOTSUP; } - if (xform->compress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { + if (xform->decompress.hash_algo != RTE_COMP_HASH_ALGO_NONE) { DRV_LOG(ERR, "SHA is not supported."); return -ENOTSUP; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.884736982 +0000 +++ 0011-compress-mlx5-fix-decompress-xform-validation.patch 2023-03-15 14:30:20.562123619 +0000 @@ -1 +1 @@ -From 12b4c48512326e810a5001f105287ee5c6fc6705 Mon Sep 17 00:00:00 2001 +From cb240b164c16f985675809c2594ff635979b32d2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 12b4c48512326e810a5001f105287ee5c6fc6705 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 430f769d41..06d1ff5b95 100644 +index 14365ec020..8d92ed492e 100644 @@ -30 +31 @@ -@@ -314,5 +314,5 @@ mlx5_compress_xform_create(struct rte_compressdev *dev, +@@ -315,5 +315,5 @@ mlx5_compress_xform_create(struct rte_compressdev *dev,