From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A32D41E9F for ; Wed, 15 Mar 2023 15:37:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9641342B8B; Wed, 15 Mar 2023 15:37:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1014C40141 for ; Wed, 15 Mar 2023 15:37:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SVU1E6BQcIXQmsuH5m3O+FBeEGf4vl8mtLg00W9oug=; b=P3L+zuaE4epZ6CZor72L19M1VkS5CmYepc5k3h8PhUhzjd7DA7+K4FUAGClWcYZ0HqKuEd NwdcSqj0sGv9+nBR/1OkzsaoWtjdKT79zTjqsLY9cCaqSCqyP9M/oIMVAZ4ZQ9FQm+KMut WtklROCW28WlJtz2YM0PjYJanseEfq4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-mY7J3ILIOjisZl6XRc_qSA-1; Wed, 15 Mar 2023 10:37:01 -0400 X-MC-Unique: mY7J3ILIOjisZl6XRc_qSA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C37B85CE6C; Wed, 15 Mar 2023 14:36:59 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7CD0C40C6E67; Wed, 15 Mar 2023 14:36:58 +0000 (UTC) From: Kevin Traynor To: Michael Baum Cc: Matan Azrad , dpdk stable Subject: patch 'compress/mlx5: fix output Adler-32 checksum offset' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:05 +0000 Message-Id: <20230315143640.677317-12-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/38c2a798fd1546e0ecba038730a38c1d08042974 Thanks. Kevin --- >From 38c2a798fd1546e0ecba038730a38c1d08042974 Mon Sep 17 00:00:00 2001 From: Michael Baum Date: Tue, 21 Feb 2023 09:07:50 +0200 Subject: [PATCH] compress/mlx5: fix output Adler-32 checksum offset [ upstream commit d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 ] After de/compress dequeue, the output checksum is copied into the op structure. The "output_checksum" field in op structure is "uint64_t" type, and the 32-bit checksums (CRC32, Adler-32) are copied into the lower 32 bits. When both CRC32 and Adler-32 are configured, CRC32 is copied into the lower 32 bits and Adler-32 into the upper 32 bits. However, in mlx5 PMD Adler-32 without CRC, is mistakenly copied into the upper 32 bits. This patch updates Adler-32 output checksum to be copied into the lower 32 bits. Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions") Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 8d92ed492e..76ad3de1f5 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -635,5 +635,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops, case RTE_COMP_CHECKSUM_ADLER32: op->output_chksum = (uint64_t)rte_be_to_cpu_32 - (opaq[idx].adler32) << 32; + (opaq[idx].adler32); break; case RTE_COMP_CHECKSUM_CRC32_ADLER32: -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.907413203 +0000 +++ 0012-compress-mlx5-fix-output-Adler-32-checksum-offset.patch 2023-03-15 14:30:20.564123626 +0000 @@ -1 +1 @@ -From d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 Mon Sep 17 00:00:00 2001 +From 38c2a798fd1546e0ecba038730a38c1d08042974 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -29 +30 @@ -index 06d1ff5b95..82088a7b8c 100644 +index 8d92ed492e..76ad3de1f5 100644 @@ -32 +33 @@ -@@ -634,5 +634,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops, +@@ -635,5 +635,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops,