From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D744141E9F for ; Wed, 15 Mar 2023 15:37:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2A68410FB; Wed, 15 Mar 2023 15:37:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6A56840FDF for ; Wed, 15 Mar 2023 15:37:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JbHqfx5+/6ged837ejm+CGmJ63U6OBztn6UYU9vnWiw=; b=g7iVAmdQR3GqFKf7izXBGutF1yRf9iFQ3zck7r2o4p+rDKMsuVDzzHOsJa8lPLRUauP13i /k4bQnPQ5eJPJ2hb3Ot/1wAIItrIkGun0qlEPlxZUc3WQIBgYWDxoz/XJ6mHP4Q6WSZPNx 7twzWreyi/BKm4HRFpfxEbAqM1g7s1U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531-ZQGQDjfWNcmtMoX1y9cOUw-1; Wed, 15 Mar 2023 10:37:04 -0400 X-MC-Unique: ZQGQDjfWNcmtMoX1y9cOUw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D06B884623; Wed, 15 Mar 2023 14:37:04 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB3FC40C6E67; Wed, 15 Mar 2023 14:37:03 +0000 (UTC) From: Kevin Traynor To: Krzysztof Karas Cc: Ferruh Yigit , dpdk stable Subject: patch 'ethdev: fix build with LTO' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:10 +0000 Message-Id: <20230315143640.677317-17-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/36cbdd704bef140db2e35afd727f090f0502f14f Thanks. Kevin --- >From 36cbdd704bef140db2e35afd727f090f0502f14f Mon Sep 17 00:00:00 2001 From: Krzysztof Karas Date: Mon, 20 Feb 2023 17:44:06 +0100 Subject: [PATCH] ethdev: fix build with LTO [ upstream commit cdd7ab072d1e662b1d06840447e7d1b8ab8946e3 ] When Link Time Optimization is enabled, compiler may complain about "id" in eth_representor_cmp() being uninitialized. To suppress the warning it is enough to add explicit initialization of the variable causing the issue. Fixes: df7547a6a2cc ("ethdev: add helper function to get representor ID") Signed-off-by: Krzysztof Karas Acked-by: Ferruh Yigit --- lib/ethdev/rte_class_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c index c8e8fc9244..ae6fac5207 100644 --- a/lib/ethdev/rte_class_eth.c +++ b/lib/ethdev/rte_class_eth.c @@ -69,5 +69,5 @@ eth_representor_cmp(const char *key __rte_unused, const struct rte_eth_dev_data *data = edev->data; struct rte_eth_devargs eth_da; - uint16_t id, nc, np, nf, i, c, p, f; + uint16_t id = 0, nc, np, nf, i, c, p, f; if ((data->dev_flags & RTE_ETH_DEV_REPRESENTOR) == 0) -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.020887965 +0000 +++ 0017-ethdev-fix-build-with-LTO.patch 2023-03-15 14:30:20.569123644 +0000 @@ -1 +1 @@ -From cdd7ab072d1e662b1d06840447e7d1b8ab8946e3 Mon Sep 17 00:00:00 2001 +From 36cbdd704bef140db2e35afd727f090f0502f14f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cdd7ab072d1e662b1d06840447e7d1b8ab8946e3 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -19 +19,0 @@ - .mailmap | 1 + @@ -21 +21 @@ - 2 files changed, 2 insertions(+), 1 deletion(-) + 1 file changed, 1 insertion(+), 1 deletion(-) @@ -23,10 +22,0 @@ -diff --git a/.mailmap b/.mailmap -index 8b84277954..69b6f4de1d 100644 ---- a/.mailmap -+++ b/.mailmap -@@ -717,4 +717,5 @@ Krishna Murthy - Krzysztof Galazka - Krzysztof Kanas -+Krzysztof Karas - Krzysztof Witek - Kuba Kozak @@ -34 +24 @@ -index 838b3a8f9f..b61dae849d 100644 +index c8e8fc9244..ae6fac5207 100644 @@ -37 +27 @@ -@@ -68,5 +68,5 @@ eth_representor_cmp(const char *key __rte_unused, +@@ -69,5 +69,5 @@ eth_representor_cmp(const char *key __rte_unused,