From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99C1641E9F for ; Wed, 15 Mar 2023 15:37:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9634C42BDA; Wed, 15 Mar 2023 15:37:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B049F410FB for ; Wed, 15 Mar 2023 15:37:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fvUazCEjqFvP/gO7HrCX1BW0JmiBTWyeIZPegsJ2L/k=; b=MeBdMOsoK0zKC5x+HgrXY5x+jTEY2LmKtaj/l3ev53wUvgSA9Wj/eT6eyIafYNC+exqZ2Z 2FnGk25psDQEqMvroPniJepDNhs0T0Ya5GdQlFJwcQIMD4hINL/B6/gcozweQLEpAZnKfU hYIf9KsuuZ/1QToAgg2X71m7BLlujOc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-J6ClQwawO6aYseY03YdrpQ-1; Wed, 15 Mar 2023 10:37:07 -0400 X-MC-Unique: J6ClQwawO6aYseY03YdrpQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A0DB985CE6A; Wed, 15 Mar 2023 14:37:06 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id C369740C6E68; Wed, 15 Mar 2023 14:37:05 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: Thomas Monjalon , Andrew Rybchenko , dpdk stable Subject: patch 'ethdev: remove telemetry Rx mbuf alloc failed field' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:12 +0000 Message-Id: <20230315143640.677317-19-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/096166c31c4a21b43ef32e93fb32278593194a42 Thanks. Kevin --- >From 096166c31c4a21b43ef32e93fb32278593194a42 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 28 Feb 2023 18:02:30 +0000 Subject: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field [ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ] 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to user via ethdev APIs but it is used internally to set "stats->rx_nombuf' which is exposed via ehtdev stat APIs. But telemetry exposes this field to user via "/ethdev/info", instead user can get 'rx_nombuf' value from stats via "/ethdev/stats". Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 0320694f82..3796cc02f6 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6371,6 +6371,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min", eth_dev->data->min_rx_buf_size); - rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail", - eth_dev->data->rx_mbuf_alloc_failed); rte_ether_format_addr(mac_addr, sizeof(mac_addr), eth_dev->data->mac_addrs); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.068130603 +0000 +++ 0019-ethdev-remove-telemetry-Rx-mbuf-alloc-failed-field.patch 2023-03-15 14:30:20.575123665 +0000 @@ -1 +1 @@ -From 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 Mon Sep 17 00:00:00 2001 +From 096166c31c4a21b43ef32e93fb32278593194a42 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 3814c202cd..3d137523a6 100644 +index 0320694f82..3796cc02f6 100644 @@ -29,2 +30,2 @@ -@@ -6643,6 +6643,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, - rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min", +@@ -6371,6 +6371,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, + rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min", @@ -32 +33 @@ -- rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail", +- rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",