From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A328641E9F for ; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70E0142D0E; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C6288410FB for ; Wed, 15 Mar 2023 15:37:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7oZzZPr8EbxR2842ZvM1CYcz8WwR+paP45oFDV31pKs=; b=VuHPfUZQlet+8JZm+C+YePpKOiVF0oirsNDnhkM2UNkssGDEEEs0G5KtpdO9X3sh0+/p+9 ZUBras6KwTFu1C5O2IynRb2Dt3mvNLOhYRuiAhEQOloXW5xLdZoCGe/iBROHJUiS/HlPfo fK6AHIYDwghL4+Tu7DKKXH6jGvRyBJk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-16-P9YHVlhwPaC0D2qlwNZulA-1; Wed, 15 Mar 2023 10:37:09 -0400 X-MC-Unique: P9YHVlhwPaC0D2qlwNZulA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A769485CE6B; Wed, 15 Mar 2023 14:37:08 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01DA040C6E67; Wed, 15 Mar 2023 14:37:07 +0000 (UTC) From: Kevin Traynor To: Kaiwen Deng Cc: Song Jiale , dpdk stable Subject: patch 'net/ixgbe: fix IPv6 mask in flow director' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:14 +0000 Message-Id: <20230315143640.677317-21-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/617735f8fb1b539ca9a97713f095fb077aa13441 Thanks. Kevin --- >From 617735f8fb1b539ca9a97713f095fb077aa13441 Mon Sep 17 00:00:00 2001 From: Kaiwen Deng Date: Fri, 3 Mar 2023 12:52:26 +0800 Subject: [PATCH] net/ixgbe: fix IPv6 mask in flow director [ upstream commit 444505f933f197bd064c7f801fa86e88d5edfce5 ] Rules without addr mask cannot be created together in ixgbe when setting IPv6 addr mask to default value as 0. This commit is to change the default value of IPv6 addr mask as '0xFF'. Fixes: cba954b7beda ("net/ixgbe: enable IPv6 mask in flow rules") Fixes: 7d629cacedee ("net/ixgbe: enable IPv6 for consistent API") Signed-off-by: Kaiwen Deng Tested-by: Song Jiale --- drivers/net/ixgbe/ixgbe_flow.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 44486c8e8e..6c5ca631d2 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -1646,8 +1646,4 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev, rule->mask.vlan_tci_mask = 0; rule->mask.flex_bytes_mask = 0; - rule->mask.dst_port_mask = 0; - rule->mask.src_port_mask = 0; - rule->mask.src_ipv6_mask = 0; - rule->mask.dst_ipv6_mask = 0; /** @@ -1923,7 +1919,7 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev, /* check src addr mask */ for (j = 0; j < 16; j++) { - if (ipv6_mask->hdr.src_addr[j] == UINT8_MAX) { - rule->mask.src_ipv6_mask |= 1 << j; - } else if (ipv6_mask->hdr.src_addr[j] != 0) { + if (ipv6_mask->hdr.src_addr[j] == 0) { + rule->mask.src_ipv6_mask &= ~(1 << j); + } else if (ipv6_mask->hdr.src_addr[j] != UINT8_MAX) { memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); rte_flow_error_set(error, EINVAL, @@ -1936,7 +1932,7 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev, /* check dst addr mask */ for (j = 0; j < 16; j++) { - if (ipv6_mask->hdr.dst_addr[j] == UINT8_MAX) { - rule->mask.dst_ipv6_mask |= 1 << j; - } else if (ipv6_mask->hdr.dst_addr[j] != 0) { + if (ipv6_mask->hdr.dst_addr[j] == 0) { + rule->mask.dst_ipv6_mask &= ~(1 << j); + } else if (ipv6_mask->hdr.dst_addr[j] != UINT8_MAX) { memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); rte_flow_error_set(error, EINVAL, -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.118017053 +0000 +++ 0021-net-ixgbe-fix-IPv6-mask-in-flow-director.patch 2023-03-15 14:30:20.582123689 +0000 @@ -1 +1 @@ -From 444505f933f197bd064c7f801fa86e88d5edfce5 Mon Sep 17 00:00:00 2001 +From 617735f8fb1b539ca9a97713f095fb077aa13441 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 444505f933f197bd064c7f801fa86e88d5edfce5 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -18 +18,0 @@ - .mailmap | 1 + @@ -20 +20 @@ - 2 files changed, 7 insertions(+), 10 deletions(-) + 1 file changed, 6 insertions(+), 10 deletions(-) @@ -22,10 +21,0 @@ -diff --git a/.mailmap b/.mailmap -index 69b6f4de1d..5b42f87d1e 100644 ---- a/.mailmap -+++ b/.mailmap -@@ -1254,4 +1254,5 @@ Solal Pirelli - Solganik Alexander - Somnath Kotur -+Song Jiale - Song Zhu - Sony Chacko @@ -33 +23 @@ -index 79c84044af..eac81ee489 100644 +index 44486c8e8e..6c5ca631d2 100644