From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EABF41E9F for ; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B06042B8E; Wed, 15 Mar 2023 15:37:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 74E2342C54 for ; Wed, 15 Mar 2023 15:37:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aXesn7rDKatuTD7DgiAAeATr7R0M2hHUiLVO5OwWuF4=; b=KSqU6bqk1gJGvRnLVN2WEqWuXL+3lznZ8vTGQaS0u+q27mj43guXEhdePrR+UIcT2Sb4M2 UptXvUXM+mm7SS3ZDODhHA/zqlcI/mZTWYeb7p/2aSHuShtk/TOX9+1FCQdvBoAxv8Id18 AbfcexJmD3+qeOWSdMtGWKgUu9xnhi8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-635-5vg0GVHnOmyFDfiPPBXqKg-1; Wed, 15 Mar 2023 10:37:10 -0400 X-MC-Unique: 5vg0GVHnOmyFDfiPPBXqKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4E6E4101A531; Wed, 15 Mar 2023 14:37:10 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id C042040C6E67; Wed, 15 Mar 2023 14:37:09 +0000 (UTC) From: Kevin Traynor To: Nithin Dabilpuram Cc: dpdk stable Subject: patch 'common/cnxk: add memory clobber to steor and ldeor' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:16 +0000 Message-Id: <20230315143640.677317-23-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5eeee34bf76e4b7c17f689eb85880626ec5a66b2 Thanks. Kevin --- >From 5eeee34bf76e4b7c17f689eb85880626ec5a66b2 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Fri, 3 Mar 2023 13:40:12 +0530 Subject: [PATCH] common/cnxk: add memory clobber to steor and ldeor [ upstream commit a032b598b30daa9c2f01a6d7de07c87adba05dab ] To avoid compiler reordering stores to LMT line and ldeor, add clobber attribute to ldeor, steor etc. Fixes: 014a9e222bac ("common/cnxk: add model init and IO handling API") Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_io.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h index fe5f7f46d0..d533d6cda6 100644 --- a/drivers/common/cnxk/roc_io.h +++ b/drivers/common/cnxk/roc_io.h @@ -112,5 +112,6 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "ldeor xzr, %x[rf], [%[rs]]" : [rf] "=r"(result) - : [rs] "r"(io_address)); + : [rs] "r"(io_address) + : "memory"); return result; } @@ -123,5 +124,6 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "ldeorl xzr,%x[rf],[%[rs]]" : [rf] "=r"(result) - : [rs] "r"(io_address)); + : [rs] "r"(io_address) + : "memory"); return result; } @@ -132,5 +134,6 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "steor %x[d], [%[rs]]" ::[d] "r"(data), - [rs] "r"(io_address)); + [rs] "r"(io_address) + : "memory"); } @@ -140,5 +143,6 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "steorl %x[d], [%[rs]]" ::[d] "r"(data), - [rs] "r"(io_address)); + [rs] "r"(io_address) + : "memory"); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.167225265 +0000 +++ 0023-common-cnxk-add-memory-clobber-to-steor-and-ldeor.patch 2023-03-15 14:30:20.585123700 +0000 @@ -1 +1 @@ -From a032b598b30daa9c2f01a6d7de07c87adba05dab Mon Sep 17 00:00:00 2001 +From 5eeee34bf76e4b7c17f689eb85880626ec5a66b2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a032b598b30daa9c2f01a6d7de07c87adba05dab ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 1e5c1f8c04..af1a10cd66 100644 +index fe5f7f46d0..d533d6cda6 100644 @@ -21 +22 @@ -@@ -131,5 +131,6 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) +@@ -112,5 +112,6 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) @@ -29 +30 @@ -@@ -142,5 +143,6 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) +@@ -123,5 +124,6 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) @@ -37 +38 @@ -@@ -151,5 +153,6 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) +@@ -132,5 +134,6 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) @@ -45 +46 @@ -@@ -159,5 +162,6 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address) +@@ -140,5 +143,6 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address)