From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8CD2641E9F for ; Wed, 15 Mar 2023 15:37:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 876E442BAC; Wed, 15 Mar 2023 15:37:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0742F40EE4 for ; Wed, 15 Mar 2023 15:37:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vsd3JgQPhgmLUxEVpq2p3l3Df03Pyzalp82kdJIT6a0=; b=NX1H1oyHwJsfNAIH4N6ZCmdJrgYOZYqBG+BYlpWF0xnp9Hs7KCL+kd/DrOvhzkfWWIJWp6 GToIKeBa5H8rJgpFkIhIq/sXRQcR8RNdtRWl6GGYAAn//+FviXVq3+E+ZOtJZG2V0r4t5O OUWJBmh+qrh0dB7MrfNz+3QceLHSnfw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-443-qkpPayu6Nh-Ioys2qamndQ-1; Wed, 15 Mar 2023 10:37:17 -0400 X-MC-Unique: qkpPayu6Nh-Ioys2qamndQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A800738149A7; Wed, 15 Mar 2023 14:37:16 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22F4840C6E67; Wed, 15 Mar 2023 14:37:16 +0000 (UTC) From: Kevin Traynor To: Chengwen Feng Cc: dpdk stable Subject: patch 'raw/skeleton: fix empty devargs parsing' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:23 +0000 Message-Id: <20230315143640.677317-30-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/d15e8526b03faa9f22aa8c3c456c1f6b30d234e0 Thanks. Kevin --- >From d15e8526b03faa9f22aa8c3c456c1f6b30d234e0 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:12 +0000 Subject: [PATCH] raw/skeleton: fix empty devargs parsing [ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. self_test). Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Signed-off-by: Chengwen Feng --- drivers/raw/skeleton/skeleton_rawdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index 16ecae3d92..a49e000146 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -660,4 +660,6 @@ skeldev_get_selftest(const char *key __rte_unused, { int *flag = opaque; + if (value == NULL || opaque == NULL) + return -EINVAL; *flag = atoi(value); return 0; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.326447105 +0000 +++ 0030-raw-skeleton-fix-empty-devargs-parsing.patch 2023-03-15 14:30:20.595123734 +0000 @@ -1 +1 @@ -From 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 Mon Sep 17 00:00:00 2001 +From d15e8526b03faa9f22aa8c3c456c1f6b30d234e0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index b2ca1cc5cd..53fe49f936 100644 +index 16ecae3d92..a49e000146 100644 @@ -25 +26 @@ -@@ -665,4 +665,6 @@ skeldev_get_selftest(const char *key __rte_unused, +@@ -660,4 +660,6 @@ skeldev_get_selftest(const char *key __rte_unused,