From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8329941E9F for ; Wed, 15 Mar 2023 15:37:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6052B42D0B; Wed, 15 Mar 2023 15:37:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F224A40141 for ; Wed, 15 Mar 2023 15:37:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pod8D2DvTaqLGe5UudpVK7vcjSjVKjCGypo9ydz5tlA=; b=WQFkTY14Nyxj8Nt308BnRSN5RjijPzaoRhL8kHUb28cfxfs2Rlnw+pt3fksqVJiwUKMMwc NJeIhsRO4SR4s6kWQMaZF0D37j/LWjU4qrS6U5LgHNzELqQqRwkI3dA/MvMJ8AVVSEr8Rx tpwpgmrLco6I82UL9prItectCvR8bFE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-393-dw4yRcq_Ny-4OUt6sr7zyA-1; Wed, 15 Mar 2023 10:37:18 -0400 X-MC-Unique: dw4yRcq_Ny-4OUt6sr7zyA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94ED41C1298E; Wed, 15 Mar 2023 14:37:17 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7B5940C6E67; Wed, 15 Mar 2023 14:37:16 +0000 (UTC) From: Kevin Traynor To: Yogesh Jangra Cc: Cristian Dumitrescu , dpdk stable Subject: patch 'table: fix action selector group size log2 setting' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:24 +0000 Message-Id: <20230315143640.677317-31-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c07485a1c1770c484483a104c905336f7ca3b0ba Thanks. Kevin --- >From c07485a1c1770c484483a104c905336f7ca3b0ba Mon Sep 17 00:00:00 2001 From: Yogesh Jangra Date: Thu, 9 Mar 2023 13:58:42 +0000 Subject: [PATCH] table: fix action selector group size log2 setting [ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ] The incorrect variable for the number of groups was used, so in the case of values not power of 2 the incorrect result was produced. Fixes: f7598a62d114 ("table: support selector table") Signed-off-by: Yogesh Jangra Acked-by: Cristian Dumitrescu --- lib/table/rte_swx_table_selector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/table/rte_swx_table_selector.c b/lib/table/rte_swx_table_selector.c index 541ebc2213..5d8e013286 100644 --- a/lib/table/rte_swx_table_selector.c +++ b/lib/table/rte_swx_table_selector.c @@ -234,5 +234,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params) for (i = 0; i < 32; i++) - if (params->n_members_per_group_max == 1U << i) + if (t->params.n_members_per_group_max == 1U << i) t->n_members_per_group_max_log2 = i; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.349567962 +0000 +++ 0031-table-fix-action-selector-group-size-log2-setting.patch 2023-03-15 14:30:20.596123738 +0000 @@ -1 +1 @@ -From 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 Mon Sep 17 00:00:00 2001 +From c07485a1c1770c484483a104c905336f7ca3b0ba Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 44bcb29f5c1b5b5af1942dee58ba16fba78c35f0 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index ad99f18453..18e021fe6f 100644 +index 541ebc2213..5d8e013286 100644 @@ -22 +23 @@ -@@ -233,5 +233,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params) +@@ -234,5 +234,5 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params)