From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D0D441E9F for ; Wed, 15 Mar 2023 15:37:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 374CA42C24; Wed, 15 Mar 2023 15:37:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3693842BB1 for ; Wed, 15 Mar 2023 15:37:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppY9Qs2+VeR0MBLuC7RJai84W0MbtHFQcfBU/cxv6Io=; b=Enim1NqFLWPzQexIqOavZyQMi6d7DLyDK6+K1clj7tEPAuSAIvho6v8d0idUSsJ+yJWsEg CCeFApOKPe2xtfwoZRQplFbFwRv10+MXcrlrCTodWl9H2mVo0tOLORJ99k2Owl55kIIKbr 0w32kVEHMbR6MXeIcF4IXY6c5hp3DK0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-vRHLFFQTMsCeuMsZswLkFA-1; Wed, 15 Mar 2023 10:37:19 -0400 X-MC-Unique: vRHLFFQTMsCeuMsZswLkFA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42822800B23; Wed, 15 Mar 2023 14:37:19 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id B460040C6E67; Wed, 15 Mar 2023 14:37:18 +0000 (UTC) From: Kevin Traynor To: Gerry Gribbon Cc: dpdk stable Subject: patch 'regex/mlx5: fix doorbell record' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:26 +0000 Message-Id: <20230315143640.677317-33-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/5b765d83bba06bd887d263d077bc7cdb5b7b56e1 Thanks. Kevin --- >From 5b765d83bba06bd887d263d077bc7cdb5b7b56e1 Mon Sep 17 00:00:00 2001 From: Gerry Gribbon Date: Tue, 21 Feb 2023 07:49:57 +0000 Subject: [PATCH] regex/mlx5: fix doorbell record [ upstream commit b15d75b2872efce397d827dac78692a919358302 ] We were writing a value that should represent the number of items to be processed by hardware. The value being written was off by 1 (N*4)+3; The value should be (N*4) + 4 simplified to (N+1)*4 Fixes: 5dfa003db53f ("common/mlx5: fix post doorbell barrier") Signed-off-by: Gerry Gribbon --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c index 4edd56d045..32a9181fb3 100644 --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c @@ -175,6 +175,6 @@ send_doorbell(struct mlx5_regex_priv *priv, struct mlx5_regex_hw_qp *qp) (priv->has_umr ? MLX5_REGEX_UMR_WQE_SIZE : 0); uint8_t *wqe = (uint8_t *)(uintptr_t)qp->qp_obj.wqes + wqe_offset; - uint32_t actual_pi = (priv->has_umr ? (qp->db_pi * 4 + 3) : qp->db_pi) & - MLX5_REGEX_MAX_WQE_INDEX; + uint32_t actual_pi = (priv->has_umr ? ((1 + qp->db_pi) * 4) : qp->db_pi) + & MLX5_REGEX_MAX_WQE_INDEX; /* Or the fm_ce_se instead of set, avoid the fence be cleared. */ -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.395151464 +0000 +++ 0033-regex-mlx5-fix-doorbell-record.patch 2023-03-15 14:30:20.598123745 +0000 @@ -1 +1 @@ -From b15d75b2872efce397d827dac78692a919358302 Mon Sep 17 00:00:00 2001 +From 5b765d83bba06bd887d263d077bc7cdb5b7b56e1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b15d75b2872efce397d827dac78692a919358302 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 6c87afa923..8e5f8c9c95 100644 +index 4edd56d045..32a9181fb3 100644 @@ -22 +23 @@ -@@ -212,6 +212,6 @@ send_doorbell(struct mlx5_regex_priv *priv, struct mlx5_regex_hw_qp *qp) +@@ -175,6 +175,6 @@ send_doorbell(struct mlx5_regex_priv *priv, struct mlx5_regex_hw_qp *qp)