From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF7CC41E9F for ; Wed, 15 Mar 2023 15:37:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBEE24161A; Wed, 15 Mar 2023 15:37:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6EF5042D1A for ; Wed, 15 Mar 2023 15:37:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWoI5HukSMgqJRhSSt+kt3ddKlDSslbhndMS+rdsb70=; b=AcQHamPwqQgU0KABH9VV7gLbWmyRhXzNtH0X1E7kfCAnZoXG9uY4jUxglWVQWD4xtQa6H1 xHDUGBp5IZEFieGAGUX3uZve3A/2yvPo0aMvFon6UJMHBe95OKi4RdBAeamQcxg8prGco+ yhg5hw3JM88mt9W1tZMCnvOoTkfx63o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-Ai-QumA_Pu-9y8rZnUGkAw-1; Wed, 15 Mar 2023 10:37:26 -0400 X-MC-Unique: Ai-QumA_Pu-9y8rZnUGkAw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B099858289; Wed, 15 Mar 2023 14:37:26 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C62F40C6E68; Wed, 15 Mar 2023 14:37:25 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix possible truncation of hash key when config' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:32 +0000 Message-Id: <20230315143640.677317-39-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f9e58fd51a32408f7b9ab566ea7e5e3329df8b34 Thanks. Kevin --- >From f9e58fd51a32408f7b9ab566ea7e5e3329df8b34 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Fri, 10 Mar 2023 17:35:03 +0800 Subject: [PATCH] net/hns3: fix possible truncation of hash key when config [ upstream commit bb38316e738ad6009b3f20b3abfaf27ea8cb0202 ] The hash key length of hns3 driver is obtained from firmware. If the length is a multiple of HNS3_RSS_HASH_KEY_NUM (16), the last part of hash key will be truncated. Fixes: 88347111eb53 ("net/hns3: refactor set RSS hash algorithm and key interface") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 23c367d16a..6f62f32a27 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -302,5 +302,6 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, req->hash_config |= (idx << HNS3_RSS_HASH_KEY_OFFSET_B); - if (idx == max_bd_num - 1) + if (idx == max_bd_num - 1 && + (key_len % HNS3_RSS_HASH_KEY_NUM) != 0) cur_key_size = key_len % HNS3_RSS_HASH_KEY_NUM; else -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.536835124 +0000 +++ 0039-net-hns3-fix-possible-truncation-of-hash-key-when-co.patch 2023-03-15 14:30:20.610123787 +0000 @@ -1 +1 @@ -From bb38316e738ad6009b3f20b3abfaf27ea8cb0202 Mon Sep 17 00:00:00 2001 +From f9e58fd51a32408f7b9ab566ea7e5e3329df8b34 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bb38316e738ad6009b3f20b3abfaf27ea8cb0202 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index d6e0754273..2011c18b9b 100644 +index 23c367d16a..6f62f32a27 100644