From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CF0841E9F for ; Wed, 15 Mar 2023 15:36:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 988DF40A7A; Wed, 15 Mar 2023 15:36:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7585840A7A for ; Wed, 15 Mar 2023 15:36:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nWUXdjyJXJKVZnSLPD8wcx1QfpcKUiIvWauiJaIIXNQ=; b=QdHm5fnO9wTGaJ6Prbb3gq5X75X2z3hzctqxFr0YIflnTSEqlf6n7A9WZM4CijskMS1c2F ZXfqFpGQc7i9XVllSOxqYy6kpIo+USjIazqhiLD6YsMvic+xtYeM1L+l3HIzxd3b5BMEuc +xX7/iH9sjSkBtztmhFYWHvaeG7AdkY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-592-svMESUlBMOm28W6nGH22xg-1; Wed, 15 Mar 2023 10:36:51 -0400 X-MC-Unique: svMESUlBMOm28W6nGH22xg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 034D6185A78F; Wed, 15 Mar 2023 14:36:51 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75C4C40C6E69; Wed, 15 Mar 2023 14:36:50 +0000 (UTC) From: Kevin Traynor To: Volodymyr Fialko Cc: dpdk stable Subject: patch 'event/cnxk: fix SSO cleanup' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:35:57 +0000 Message-Id: <20230315143640.677317-4-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/349431b3fb2a6f027036913019396c3286fe104c Thanks. Kevin --- >From 349431b3fb2a6f027036913019396c3286fe104c Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Thu, 2 Mar 2023 11:58:32 +0100 Subject: [PATCH] event/cnxk: fix SSO cleanup [ upstream commit c31a3b37bb26c2f7f270592c8976072b510869dd ] dev_fini() can return EAGAIN in case if LF is active(used by other devices). Ignoring return code leads to early free of resources that are still in use. Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup") Signed-off-by: Volodymyr Fialko --- drivers/event/cnxk/cnxk_eventdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c index 46a788ef4e..d543fdd14e 100644 --- a/drivers/event/cnxk/cnxk_eventdev.c +++ b/drivers/event/cnxk/cnxk_eventdev.c @@ -637,7 +637,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev) cnxk_tim_fini(); roc_sso_rsrc_fini(&dev->sso); - roc_sso_dev_fini(&dev->sso); - return 0; + return roc_sso_dev_fini(&dev->sso); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.713247972 +0000 +++ 0004-event-cnxk-fix-SSO-cleanup.patch 2023-03-15 14:30:20.537123532 +0000 @@ -1 +1 @@ -From c31a3b37bb26c2f7f270592c8976072b510869dd Mon Sep 17 00:00:00 2001 +From 349431b3fb2a6f027036913019396c3286fe104c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c31a3b37bb26c2f7f270592c8976072b510869dd ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 5f1fa1e96d..cb9ba5d353 100644 +index 46a788ef4e..d543fdd14e 100644 @@ -22 +23 @@ -@@ -671,7 +671,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev) +@@ -637,7 +637,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)