patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Huisong Li <lihuisong@huawei.com>
Cc: Dongdong Liu <liudongdong3@huawei.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/hns3: fix possible truncation of redirection table' has been queued to stable release 21.11.4
Date: Wed, 15 Mar 2023 14:36:33 +0000	[thread overview]
Message-ID: <20230315143640.677317-40-ktraynor@redhat.com> (raw)
In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/abeba16e38adec4961b08f97c6a238538dd456ea

Thanks.

Kevin

---
From abeba16e38adec4961b08f97c6a238538dd456ea Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong@huawei.com>
Date: Fri, 10 Mar 2023 17:35:04 +0800
Subject: [PATCH] net/hns3: fix possible truncation of redirection table

[ upstream commit 4729376e555b58a739e6e231d403ca3b029ad92c ]

The size of the redirection table is obtained from firmware. If the size
isn't a multiple of HNS3_RSS_CFG_TBL_SIZE, the redirection table from
user will be truncated.

Fixes: c37ca66f2b27 ("net/hns3: support RSS")

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
 drivers/net/hns3/hns3_rss.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c
index 6f62f32a27..e94fabccc3 100644
--- a/drivers/net/hns3/hns3_rss.c
+++ b/drivers/net/hns3/hns3_rss.c
@@ -330,4 +330,5 @@ hns3_set_rss_indir_table(struct hns3_hw *hw, uint16_t *indir, uint16_t size)
 {
 	struct hns3_rss_indirection_table_cmd *req;
+	uint16_t max_bd_num, cfg_tbl_size;
 	struct hns3_cmd_desc desc;
 	uint8_t qid_msb_off;
@@ -338,6 +339,6 @@ hns3_set_rss_indir_table(struct hns3_hw *hw, uint16_t *indir, uint16_t size)
 
 	req = (struct hns3_rss_indirection_table_cmd *)desc.data;
-
-	for (i = 0; i < size / HNS3_RSS_CFG_TBL_SIZE; i++) {
+	max_bd_num = DIV_ROUND_UP(size, HNS3_RSS_CFG_TBL_SIZE);
+	for (i = 0; i < max_bd_num; i++) {
 		hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_RSS_INDIR_TABLE,
 					  false);
@@ -345,5 +346,11 @@ hns3_set_rss_indir_table(struct hns3_hw *hw, uint16_t *indir, uint16_t size)
 				rte_cpu_to_le_16(i * HNS3_RSS_CFG_TBL_SIZE);
 		req->rss_set_bitmap = rte_cpu_to_le_16(HNS3_RSS_SET_BITMAP_MSK);
-		for (j = 0; j < HNS3_RSS_CFG_TBL_SIZE; j++) {
+
+		if (i == max_bd_num - 1 && (size % HNS3_RSS_CFG_TBL_SIZE) != 0)
+			cfg_tbl_size = size % HNS3_RSS_CFG_TBL_SIZE;
+		else
+			cfg_tbl_size = HNS3_RSS_CFG_TBL_SIZE;
+
+		for (j = 0; j < cfg_tbl_size; j++) {
 			q_id = indir[i * HNS3_RSS_CFG_TBL_SIZE + j];
 			req->rss_result_l[j] = q_id & 0xff;
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:21.559779994 +0000
+++ 0040-net-hns3-fix-possible-truncation-of-redirection-tabl.patch	2023-03-15 14:30:20.611123790 +0000
@@ -1 +1 @@
-From 4729376e555b58a739e6e231d403ca3b029ad92c Mon Sep 17 00:00:00 2001
+From abeba16e38adec4961b08f97c6a238538dd456ea Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4729376e555b58a739e6e231d403ca3b029ad92c ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org
@@ -20 +21 @@
-index 2011c18b9b..ed397587b5 100644
+index 6f62f32a27..e94fabccc3 100644


  parent reply	other threads:[~2023-03-15 14:37 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 14:35 patch 'eal/windows: fix pedantic build' " Kevin Traynor
2023-03-15 14:35 ` patch 'doc: add gpudev to the Doxygen index' " Kevin Traynor
2023-03-15 14:35 ` patch 'doc: fix reference to event timer header' " Kevin Traynor
2023-03-15 14:35 ` patch 'event/cnxk: fix SSO cleanup' " Kevin Traynor
2023-03-15 14:35 ` patch 'test/bbdev: fix crash for non supported HARQ length' " Kevin Traynor
2023-03-15 14:35 ` patch 'test/bbdev: extend HARQ tolerance' " Kevin Traynor
2023-03-15 14:36 ` patch 'test/bbdev: remove check for invalid opaque data' " Kevin Traynor
2023-03-15 14:36 ` patch 'vhost: fix OOB access for invalid vhost ID' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/virtio: deduce IP length for TSO checksum' " Kevin Traynor
2023-03-15 14:36 ` patch 'examples/ipsec-secgw: fix auth IV length' " Kevin Traynor
2023-03-15 14:36 ` patch 'compress/mlx5: fix decompress xform validation' " Kevin Traynor
2023-03-15 14:36 ` patch 'compress/mlx5: fix output Adler-32 checksum offset' " Kevin Traynor
2023-03-15 14:36 ` patch 'compress/mlx5: fix queue setup for partial transformations' " Kevin Traynor
2023-03-15 14:36 ` patch 'app/testpmd: fix Tx preparation in checksum engine' " Kevin Traynor
2023-03-15 14:36 ` patch 'app/testpmd: fix packet count in IEEE 1588 " Kevin Traynor
2023-03-15 14:36 ` patch 'app/testpmd: fix packet transmission in noisy VNF " Kevin Traynor
2023-03-15 14:36 ` patch 'ethdev: fix build with LTO' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/nfp: fix getting RSS configuration' " Kevin Traynor
2023-03-15 14:36 ` patch 'ethdev: remove telemetry Rx mbuf alloc failed field' " Kevin Traynor
2023-03-15 14:36 ` patch 'app/testpmd: fix secondary process packet forwarding' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/ixgbe: fix IPv6 mask in flow director' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/cnxk: fix LBK BPID usage' " Kevin Traynor
2023-03-15 14:36 ` patch 'common/cnxk: add memory clobber to steor and ldeor' " Kevin Traynor
2023-03-15 14:36 ` patch 'kvargs: add API documentation for process callback' " Kevin Traynor
2023-03-15 14:36 ` patch 'compressdev: fix empty devargs parsing' " Kevin Traynor
2023-03-15 14:36 ` patch 'cryptodev: " Kevin Traynor
2023-03-15 14:36 ` patch 'net/hns3: " Kevin Traynor
2023-03-15 14:36 ` patch 'net/virtio: " Kevin Traynor
2023-03-15 14:36 ` patch 'dma/skeleton: " Kevin Traynor
2023-03-15 14:36 ` patch 'raw/skeleton: " Kevin Traynor
2023-03-15 14:36 ` patch 'table: fix action selector group size log2 setting' " Kevin Traynor
2023-03-15 14:36 ` patch 'regex/mlx5: utilize all available queue pairs' " Kevin Traynor
2023-03-15 14:36 ` patch 'regex/mlx5: fix doorbell record' " Kevin Traynor
2023-03-15 14:36 ` patch 'common/sfc_efx/base: add MAE mark reset action' " Kevin Traynor
2023-03-15 14:36 ` patch 'kni: fix possible starvation when mbufs are exhausted' " Kevin Traynor
2023-03-15 14:36 ` patch 'cmdline: make rdline status not private' " Kevin Traynor
2023-03-15 14:36 ` patch 'cmdline: handle EOF as quit' " Kevin Traynor
2023-03-15 14:36 ` patch 'mem: fix heap ID in telemetry' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/hns3: fix possible truncation of hash key when config' " Kevin Traynor
2023-03-15 14:36 ` Kevin Traynor [this message]
2023-03-15 14:36 ` patch 'net/hns3: use hardware config to report redirection table' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/hns3: separate setting " Kevin Traynor
2023-03-15 14:36 ` patch 'net/hns3: separate setting and clearing RSS rule' " Kevin Traynor
2023-03-15 14:36 ` patch 'net/mlx5: fix Windows build with MinGW GCC 12' " Kevin Traynor
2023-03-15 14:36 ` patch 'app/crypto-perf: fix test file memory leak' " Kevin Traynor
2023-03-15 14:36 ` patch 'app/flow-perf: fix division or module by zero' " Kevin Traynor
2023-03-15 14:36 ` patch 'mailmap: add list of contributors' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230315143640.677317-40-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=lihuisong@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).