From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A5DE41E9F for ; Wed, 15 Mar 2023 15:37:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80A6C4161A; Wed, 15 Mar 2023 15:37:37 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6BE5B42D20 for ; Wed, 15 Mar 2023 15:37:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mAFVDqEtlpTGSMzwbPFDxTPWQK+Xmky4c34kYGqF5Uk=; b=ITrML5S44eQbVVEs0cVhzcS66LobInZUqhr/ujEQmS+mAUNHOme94FDqC4deKhSukZWBrc vpsxrF0pK1EQV00Gz3/KEhJmoIjGpGG28xbSpZrSAUk5MRWdHxCxE9pu+QqBtJWhF/CsHS VcvBkxTGkY/Gxv65tOcBnCs16M+GK9o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-D_L6UfW9OQSt5YVK7_TGLg-1; Wed, 15 Mar 2023 10:37:33 -0400 X-MC-Unique: D_L6UfW9OQSt5YVK7_TGLg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4773F858F09; Wed, 15 Mar 2023 14:37:33 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80DF040C6E67; Wed, 15 Mar 2023 14:37:32 +0000 (UTC) From: Kevin Traynor To: Mohammad Iqbal Ahmad Cc: Wisam Jaddo , dpdk stable Subject: patch 'app/flow-perf: fix division or module by zero' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:36:39 +0000 Message-Id: <20230315143640.677317-46-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/27b61d8f7b039519d2a7c31fe92a63c1dc10377a Thanks. Kevin --- >From 27b61d8f7b039519d2a7c31fe92a63c1dc10377a Mon Sep 17 00:00:00 2001 From: Mohammad Iqbal Ahmad Date: Tue, 24 Jan 2023 16:08:03 +0530 Subject: [PATCH] app/flow-perf: fix division or module by zero [ upstream commit 132d39dcab370b2112e0a24ab1c94036b40b9557 ] Fix division or module by zero reported by coverity scan. Coverity issue: 373870 Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Signed-off-by: Mohammad Iqbal Ahmad Acked-by: Wisam Jaddo --- app/test-flow-perf/main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index f375097028..13d1c849bf 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -836,5 +836,10 @@ args_parse(int argc, char **argv) if (strcmp(lgopts[opt_idx].name, "rules-batch") == 0) { - rules_batch = atoi(optarg); + n = atoi(optarg); + if (n > 0) + rules_batch = n; + else + rte_exit(EXIT_FAILURE, + "flow rules-batch should be > 0\n"); } if (strcmp(lgopts[opt_idx].name, -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:21.700661925 +0000 +++ 0046-app-flow-perf-fix-division-or-module-by-zero.patch 2023-03-15 14:30:20.621123825 +0000 @@ -1 +1 @@ -From 132d39dcab370b2112e0a24ab1c94036b40b9557 Mon Sep 17 00:00:00 2001 +From 27b61d8f7b039519d2a7c31fe92a63c1dc10377a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 132d39dcab370b2112e0a24ab1c94036b40b9557 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +15,0 @@ - .mailmap | 1 + @@ -17 +17 @@ - 2 files changed, 7 insertions(+), 1 deletion(-) + 1 file changed, 6 insertions(+), 1 deletion(-) @@ -19,10 +18,0 @@ -diff --git a/.mailmap b/.mailmap -index aaa15deff9..4018f0fc47 100644 ---- a/.mailmap -+++ b/.mailmap -@@ -925,4 +925,5 @@ Mit Matelske - Mohamad Noor Alim Hussin - Mohammad Abdul Awal -+Mohammad Iqbal Ahmad - Mohammed Gamal - Mohsin Kazmi @@ -30 +20 @@ -index 4a9206803a..e0ef78a840 100644 +index f375097028..13d1c849bf 100644 @@ -33 +23 @@ -@@ -849,5 +849,10 @@ args_parse(int argc, char **argv) +@@ -836,5 +836,10 @@ args_parse(int argc, char **argv)