From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABFEB41E9F for ; Wed, 15 Mar 2023 15:36:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 746F842B71; Wed, 15 Mar 2023 15:36:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E3D3340141 for ; Wed, 15 Mar 2023 15:36:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+JFwguYvVvtRrhg3WwsEQ5pAlIk13kMo/GxZtXtHvXA=; b=fh+TKj7w7ntaXnYx3hBf11/fbSB5pbtw83MvgDQCBSWQuN7BxpduEDD133cT0xmGQnurNN o7Z80kZjzVojj2xXi3lHP1ki3ZqQ11wYqCqNG5x8cMv84VDT00rRfBJS7X2gCegXwJCjqI pZtqbJMsqc7wJO2XWMbEBXaiCChssO0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-112-34HrcGL1PBChEudYtqMeGA-1; Wed, 15 Mar 2023 10:36:52 -0400 X-MC-Unique: 34HrcGL1PBChEudYtqMeGA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1135185CE66; Wed, 15 Mar 2023 14:36:52 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4324740C6E6E; Wed, 15 Mar 2023 14:36:51 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'test/bbdev: fix crash for non supported HARQ length' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:35:58 +0000 Message-Id: <20230315143640.677317-5-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f77e413c9147a5f76f141987ebdb8f316f8afed3 Thanks. Kevin --- >From f77e413c9147a5f76f141987ebdb8f316f8afed3 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 2 Mar 2023 12:21:55 -0800 Subject: [PATCH] test/bbdev: fix crash for non supported HARQ length [ upstream commit bee9ac50e5da1f573dfb3c647687da15326d7c3e ] Fix segmentation fault happening in corner case in test-bbdev. This fault could happen when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd2763 ("app/bbdev: support HARQ validation") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 0fa119a502..b861a7abad 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -77,5 +77,5 @@ #define HARQ_INCR 32768 /* Headroom for filler LLRs insertion in HARQ buffer */ -#define FILLER_HEADROOM 1024 +#define FILLER_HEADROOM 2048 /* Constants from K0 computation from 3GPP 38.212 Table 5.4.2.1-2 */ #define N_ZC_1 66 /* N = 66 Zc for BG 1 */ @@ -1969,7 +1969,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, if (data_len > deRmOutSize) data_len = deRmOutSize; - if (data_len > orig_op->segments[i].length) - data_len = orig_op->segments[i].length; } + if (data_len > orig_op->segments[i].length) + data_len = orig_op->segments[i].length; /* * HARQ output can have minor differences -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.735693520 +0000 +++ 0005-test-bbdev-fix-crash-for-non-supported-HARQ-length.patch 2023-03-15 14:30:20.544123556 +0000 @@ -1 +1 @@ -From bee9ac50e5da1f573dfb3c647687da15326d7c3e Mon Sep 17 00:00:00 2001 +From f77e413c9147a5f76f141987ebdb8f316f8afed3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bee9ac50e5da1f573dfb3c647687da15326d7c3e ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 45e1780df7..027f32cbf1 100644 +index 0fa119a502..b861a7abad 100644 @@ -23 +24 @@ -@@ -85,5 +85,5 @@ +@@ -77,5 +77,5 @@ @@ -30 +31 @@ -@@ -2112,7 +2112,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -1969,7 +1969,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,