From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F134A41E9F for ; Wed, 15 Mar 2023 15:36:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E06D942BB1; Wed, 15 Mar 2023 15:36:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 04BD140141 for ; Wed, 15 Mar 2023 15:36:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678891016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7wgSxT+3qU6LOfcfEoiOe/TmzKpUvPaZUMYe17dLlnI=; b=dra+G+vMy1FQL1yKe91vqWOCPgTam/7ANtwEF7lPpaaDVlbpCA/jWVfO/MKhvSXiYIkNt0 K6wrrvSe8ZmdGXeDD6hJg918IjnqEMdJnJt4Qi1uBGuKtuBou4zeu0QWwEeirbp3mnIJ+Z EVYD8iYhx7Yz0/+OOVQtLeQmVD7qToY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-EhaQXxh2NSmAA-jXnwmYog-1; Wed, 15 Mar 2023 10:36:53 -0400 X-MC-Unique: EhaQXxh2NSmAA-jXnwmYog-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0938E8028AD; Wed, 15 Mar 2023 14:36:53 +0000 (UTC) Received: from rh.Home (unknown [10.39.192.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F57040C6E69; Wed, 15 Mar 2023 14:36:52 +0000 (UTC) From: Kevin Traynor To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'test/bbdev: extend HARQ tolerance' has been queued to stable release 21.11.4 Date: Wed, 15 Mar 2023 14:35:59 +0000 Message-Id: <20230315143640.677317-6-ktraynor@redhat.com> In-Reply-To: <20230315143640.677317-1-ktraynor@redhat.com> References: <20230315143640.677317-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/20/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8a36f3995a571361dd50d03c67a6fa2f793d9b19 Thanks. Kevin --- >From 8a36f3995a571361dd50d03c67a6fa2f793d9b19 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 2 Mar 2023 12:21:56 -0800 Subject: [PATCH] test/bbdev: extend HARQ tolerance [ upstream commit 39b601c462b8192b8f1c98fe26b604430ebcc8e4 ] HARQ memory implementation could have different size assumptions. Extending HARQ tolerance to cover different implementations. Fixes: 335c11fd2763 ("app/bbdev: support HARQ validation") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index b861a7abad..7e76f92bf1 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -88,4 +88,5 @@ #define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */ +#define HARQ_MEM_TOLERANCE 256 static struct test_bbdev_vector test_vector; @@ -1948,6 +1949,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, total_data_size += orig_op->segments[i].length; - TEST_ASSERT(orig_op->segments[i].length < - (uint32_t)(data_len + 64), + TEST_ASSERT(orig_op->segments[i].length < (uint32_t)(data_len + HARQ_MEM_TOLERANCE), "Length of segment differ in original (%u) and filled (%u) op", orig_op->segments[i].length, data_len); @@ -1955,4 +1955,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, harq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset); + /* Cannot compare HARQ output data for such cases */ + if ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION) + || (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION))) + break; + if (!(ldpc_cap_flags & RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS @@ -2030,5 +2035,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, /* Validate total mbuf pkt length */ uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset; - TEST_ASSERT(total_data_size < pkt_len + 64, + TEST_ASSERT(total_data_size < pkt_len + HARQ_MEM_TOLERANCE, "Length of data differ in original (%u) and filled (%u) op", total_data_size, pkt_len); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 14:30:20.762118189 +0000 +++ 0006-test-bbdev-extend-HARQ-tolerance.patch 2023-03-15 14:30:20.549123574 +0000 @@ -1 +1 @@ -From 39b601c462b8192b8f1c98fe26b604430ebcc8e4 Mon Sep 17 00:00:00 2001 +From 8a36f3995a571361dd50d03c67a6fa2f793d9b19 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 39b601c462b8192b8f1c98fe26b604430ebcc8e4 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 027f32cbf1..74e7e13940 100644 +index b861a7abad..7e76f92bf1 100644 @@ -22 +23 @@ -@@ -96,4 +96,5 @@ +@@ -88,4 +88,5 @@ @@ -28 +29 @@ -@@ -2091,6 +2092,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -1948,6 +1949,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, @@ -36 +37 @@ -@@ -2098,4 +2098,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -1955,4 +1955,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, @@ -46 +47 @@ -@@ -2173,5 +2178,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -2030,5 +2035,5 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,