From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1096741EA5 for ; Wed, 15 Mar 2023 23:46:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D868540A7A; Wed, 15 Mar 2023 23:46:35 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id 022AE40141 for ; Wed, 15 Mar 2023 23:46:33 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id j19-20020a05600c191300b003eb3e1eb0caso2001413wmq.1 for ; Wed, 15 Mar 2023 15:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VoJ8A6679lgkKjK0tQc9ao+UvzRdOIoJe5WPdn/G774=; b=cg4FRMB9L7/cjiCTkBugigT4gKNioyNSd0JHys1uIoi8cVe8CyIbEfPopvNRFszz8A Z4Dux4VI+mIagZ+2HnYk9iU1bmfKGN7zN7huYw5ERq+xPXAYKbjn2lEwt6wRAzJOBumn LqZtGn9WKvvalxf8q76o2p3Q9OLOWDWOwS7Uw7rdczPGr9/mKrvvvg0A0mwRCja+tGLA YWF3880iSpvLv8ldfPGWjU+xxZySqs9ktJxSKwsmDYo6OVpByx9kf1HdoI2kgKC47zux 4uUYe6Bt7jt2qdkYykSYOTVwbBVUrq8VSboV21DYBAsYQrGIHMHf6duvNmGPm6Aqz04M M0rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VoJ8A6679lgkKjK0tQc9ao+UvzRdOIoJe5WPdn/G774=; b=ZAR+w66U9rK7st/n0LJpTLftOKY1aW1KBrUzOeFZo13YefkFimK5kjl9hq3Iz0fkps cY0FB2l0rIV79hmy7tHtvNBs6+V49zL3vovXsTJdYY86AzKQ2MB+tEJXYiaS1L7wmf2a 4V3m6y7IKT5GnL5MNRQFMJwgIRSErH8KvoEUwK9W4RJy6C33/s1IxPqE4eUi6fyhjFhf Cd4kvBGxVRJNRiNbs4Qhyook6+v7O9ytxbk36PbX3yi/xmodSnlPl4VDdizKXuu1NrZN 9UupD3FrHjfYNZgMGcLI0qmVrvGqoTObECKjIIadxc155CzfPyAzG9bM7sCQ/YBYxl7a wHUg== X-Gm-Message-State: AO0yUKW34kgAchTJ7JqC+nWkEAiqUrArXRmzd7MND3KDFLEnfLJAOnuL oSttGwLmqpXCd7EHWWz0TzKtKOKmvmFr7Q== X-Google-Smtp-Source: AK7set9mV6wDnFZ4Pg+AvR1xreY5wC6rOt2PyGfhIa3d+7JklNJOhE7KfI0cMsajhZE/QjB9WBf4Mw== X-Received: by 2002:a05:600c:3504:b0:3ea:d620:579b with SMTP id h4-20020a05600c350400b003ead620579bmr18547481wmq.0.1678920393273; Wed, 15 Mar 2023 15:46:33 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id g8-20020a5d4888000000b002d1959d2cf7sm913632wrq.111.2023.03.15.15.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:46:32 -0700 (PDT) From: luca.boccassi@gmail.com To: Thomas Monjalon Cc: Tyler Retzlaff , dpdk stable Subject: patch 'eal/windows: fix pedantic build' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:45:52 +0000 Message-Id: <20230315224631.1025649-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230223093715.3926893-71-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0ccc2b5cf0ade8a6e64fef7ac9edd13e052e6ffe Thanks. Luca Boccassi --- >From 0ccc2b5cf0ade8a6e64fef7ac9edd13e052e6ffe Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 5 Jan 2023 16:18:38 +0100 Subject: [PATCH] eal/windows: fix pedantic build [ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] MinGW GCC 12 shows an illegal pointer conversion when included in a pedantic module: lib/eal/windows/include/pthread.h:137:41: error: ISO C forbids conversion of object pointer to function pointer type [-Werror=pedantic] 137 | hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, | ^ By using uintptr_t, the compiler is forced to accept the conversion. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Signed-off-by: Thomas Monjalon Acked-by: Tyler Retzlaff --- lib/librte_eal/windows/include/pthread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h index 27fd2cca52..f7cf0e9ddf 100644 --- a/lib/librte_eal/windows/include/pthread.h +++ b/lib/librte_eal/windows/include/pthread.h @@ -134,7 +134,8 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc, { RTE_SET_USED(threadattr); HANDLE hThread; - hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, + hThread = CreateThread(NULL, 0, + (LPTHREAD_START_ROUTINE)(uintptr_t)threadfunc, args, 0, (LPDWORD)threadid); if (hThread) { SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:49.711012572 +0000 +++ 0001-eal-windows-fix-pedantic-build.patch 2023-03-15 22:44:49.463847745 +0000 @@ -1 +1 @@ -From 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b Mon Sep 17 00:00:00 2001 +From 0ccc2b5cf0ade8a6e64fef7ac9edd13e052e6ffe Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ - lib/eal/windows/include/pthread.h | 3 ++- + lib/librte_eal/windows/include/pthread.h | 3 ++- @@ -26 +27 @@ -diff --git a/lib/eal/windows/include/pthread.h b/lib/eal/windows/include/pthread.h +diff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h @@ -28,2 +29,2 @@ ---- a/lib/eal/windows/include/pthread.h -+++ b/lib/eal/windows/include/pthread.h +--- a/lib/librte_eal/windows/include/pthread.h ++++ b/lib/librte_eal/windows/include/pthread.h