From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EF4041EA5 for ; Wed, 15 Mar 2023 23:47:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39F67410DD; Wed, 15 Mar 2023 23:47:06 +0100 (CET) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mails.dpdk.org (Postfix) with ESMTP id 7E9F840141 for ; Wed, 15 Mar 2023 23:47:04 +0100 (CET) Received: by mail-wr1-f53.google.com with SMTP id y14so6018564wrq.4 for ; Wed, 15 Mar 2023 15:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yxHA4p7817n25NARfX3k+CzuS0XUCVy9YKT65AKGHYE=; b=qzIC+iMDx0K7btkcu5MsxC0EN2XYOM9rcyBTN0Si+FoOmgQsG7paXqImCIbplVCn3J A3lgokSBhd/M+zDxWHzMCzPaWMja+enEXh44UlDFbSW7xFtdWkXQ5k6e3MqtsnsH4YAh drj5CtCdX8B15OAKMKy/R53rqPg+ATOdrJNzOkIQtrfJmLs4yWuti5pK+Q5iRf1Gsx07 eitVMJlHfx9iKwPcQ+hgcbq2NA1LDpCbQKes8/emydwaO7crjCIwl76Q1tdenOFSUWVy WvdcQcq3oo0dki/drHgbn1y15LLgS7kbzQbWU8FvmPhAFFqWVZHh+t4awDDM0OqoiUy3 htVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yxHA4p7817n25NARfX3k+CzuS0XUCVy9YKT65AKGHYE=; b=px5PVVjQ5H/YqYrgURpJpinVJQxPja8hh9Ny4mk0BEWCe+xKmnAPU0qsrgfthHRL3p xciOS8GjhDqc24Uc9/vAvaYcJV1mqGtKBOKh2T6ceGjMTAARfcQFKhr8ubTEKpudB8CN /HKndCJaQkiqQ6Kozt1r64MTmXo2DUbj80nOo+VcUkYpMkgqaF0Lk5DNrHh2rSeCsece bMaihsaRtpp+Ayh8Th9acLk5drGws1baBxMKImvxZEVdHPpSV+7dRSoLebE9PmuE/3Fy 6D/KxhVTVegoztJ0QGe5QawcZmR5aY/FWszc1U6ItwHuJTrGN7WJmKcTrcm04bkEYnWH Mqqg== X-Gm-Message-State: AO0yUKWbZnsykzNFBiQG4tsbekoLcVtFWEsJwREBuwR+MGQjxVRLLtWo i+G32uyb91OVj8SCXnpFgrg0C+1SfS+J0w== X-Google-Smtp-Source: AK7set+pFd8QhpitDw9DdwgmVOoXBJHe1KlTWKMlmUR/nnMASjDucRwxIh5pn18FP5FCANwnpNTong== X-Received: by 2002:a5d:4d04:0:b0:2ce:a8e4:bb79 with SMTP id z4-20020a5d4d04000000b002cea8e4bb79mr2759360wrt.53.1678920424202; Wed, 15 Mar 2023 15:47:04 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id t14-20020a05600c198e00b003ed29899dfdsm3367426wmq.21.2023.03.15.15.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:47:03 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix packet transmission in noisy VNF engine' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:46:02 +0000 Message-Id: <20230315224631.1025649-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/bad17c2433b7c934b81ed961bd4ddf78b9aa3521 Thanks. Luca Boccassi --- >From bad17c2433b7c934b81ed961bd4ddf78b9aa3521 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 20 Feb 2023 19:34:57 +0100 Subject: [PATCH] app/testpmd: fix packet transmission in noisy VNF engine [ upstream commit c2acd2db16cba89f403a980da5f4b6764085b01d ] nb_rx relates to the number of packets received from the driver. nb_tx is the total number of packets transmitted by this forward engine. Fix the retry stage, for dequeued packets, as it was incorrectly passing nb_rx / nb_tx as bounds of the tmp_pkts[] array, and fix tx stats accordingly. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- app/test-pmd/noisy_vnf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c index d70940006d..1be5f77efe 100644 --- a/app/test-pmd/noisy_vnf.c +++ b/app/test-pmd/noisy_vnf.c @@ -213,9 +213,10 @@ flush: sent = rte_eth_tx_burst(fs->tx_port, fs->tx_queue, tmp_pkts, nb_deqd); if (unlikely(sent < nb_deqd) && fs->retry_enabled) - nb_tx += do_retry(nb_rx, nb_tx, tmp_pkts, fs); - inc_tx_burst_stats(fs, nb_tx); + sent += do_retry(nb_deqd, sent, tmp_pkts, fs); + inc_tx_burst_stats(fs, sent); fs->fwd_dropped += drop_pkts(tmp_pkts, nb_deqd, sent); + nb_tx += sent; ncf->prev_time = rte_get_timer_cycles(); } } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:50.259993645 +0000 +++ 0011-app-testpmd-fix-packet-transmission-in-noisy-VNF-eng.patch 2023-03-15 22:44:49.523849003 +0000 @@ -1 +1 @@ -From c2acd2db16cba89f403a980da5f4b6764085b01d Mon Sep 17 00:00:00 2001 +From bad17c2433b7c934b81ed961bd4ddf78b9aa3521 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c2acd2db16cba89f403a980da5f4b6764085b01d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index ce5a3e5e69..0e72dc034f 100644 +index d70940006d..1be5f77efe 100644 @@ -26 +27 @@ -@@ -217,9 +217,10 @@ flush: +@@ -213,9 +213,10 @@ flush: @@ -38 +39 @@ - end: + }