From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A459741EA5 for ; Wed, 15 Mar 2023 23:47:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 938FC40A7A; Wed, 15 Mar 2023 23:47:21 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id D803940141 for ; Wed, 15 Mar 2023 23:47:19 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id k25-20020a7bc419000000b003ed23114fa7so1991632wmi.4 for ; Wed, 15 Mar 2023 15:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SYu6cdDet+5v3LB68fpmlJqGRdiU/csXeLetsJt0u78=; b=jewCxrexIxcKnRno/oU27SF1D41qX5rqj715A5evnG5wMaX61xDWdTcYqZ51EZSvXU hriAEYe8ncurLfyxqx0Mxd2+HQMZKv0sdRSMmZDE+EpsDs1fFObUSqzvKUDV4k/fSjNq l+FzXs5CQw7YqTwl5+w8lcCVVV3a4rIiMQ5GOG7Cw1TtWfP1NcP9FWkDrkktjTI0/32t PFRFaRP+BSetsZAJkBqFKN5+9pAKlf3YQHTXpDmhrstURGbzKeZdy2ZPpxkdrzRb+CfD brYLZqFw+kSh9jSYxom+6ZJM6gKdXl1c6JY21F569PSwbBUdGy9u2+gNFiMLz/bWcQd0 V/hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SYu6cdDet+5v3LB68fpmlJqGRdiU/csXeLetsJt0u78=; b=LQ5o9cWCA+z3jQ0aKdqAFe1xSDPPhXnN6dEu+qiOTjdGmJEP6DN+15TWuWFR2iIzJq ENbNYl5dkv51+2Bfqucd2w15Im39lfauujeJrlIUMcQtK3m/3UyJPfLciyITbC5+vLkO dps/1ZQmBXyNhc+3yurN08wg7qd6IWI8kttl3GRYKOGWgc4g3ZNRKEHzHqtYOUL14H6x DNpF4eehDRO7S47O/kPbPMfAxFYQPSOMiCw5fuzXTnGDL4hN9zyIoKU257qYNdZ21s6/ VM80eL0F7T7uv8kEwka+OauQKZ+GcxGNVLnqwn7AA2owxI5k2UJFjnoGDYuRkV3iLWMa AzXg== X-Gm-Message-State: AO0yUKX09iHqdDHtiYb/kV44YUsvifz9+DE4IeV7EmPTDp/lJyGsSj1G mKIYwudt/1AkCQ5mWxnsb3U= X-Google-Smtp-Source: AK7set/U9XUY64rXFN2Z+yV3o/7m+nO8We8bPUv3CXF7KAMJMZZunvSvo5n0pmrUNGHC5KToc3UVuA== X-Received: by 2002:a05:600c:cc6:b0:3ed:2949:9847 with SMTP id fk6-20020a05600c0cc600b003ed29499847mr9444041wmb.10.1678920439628; Wed, 15 Mar 2023 15:47:19 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id z19-20020a1c4c13000000b003ed246c1d28sm3306775wmf.44.2023.03.15.15.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:47:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: Olivier Matz , dpdk stable Subject: patch 'kvargs: add API documentation for process callback' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:46:07 +0000 Message-Id: <20230315224631.1025649-16-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0929f2bd19ef9c4a3775d392d37ac1459382c1cb Thanks. Luca Boccassi --- >From 0929f2bd19ef9c4a3775d392d37ac1459382c1cb Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:04 +0000 Subject: [PATCH] kvargs: add API documentation for process callback [ upstream commit 52ab17efdecf935792ee1d0cb749c0dbd536c083 ] The rte_kvargs_process() is used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function (which prototype is arg_handler_t) parameter 'value' is NULL when parsing 'only keys'. But there is no detailed definition of 'value' may be NULL, so this patch adds it. Signed-off-by: Chengwen Feng Acked-by: Olivier Matz --- lib/librte_kvargs/rte_kvargs.h | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/librte_kvargs/rte_kvargs.h b/lib/librte_kvargs/rte_kvargs.h index 5b2e164287..a53da40278 100644 --- a/lib/librte_kvargs/rte_kvargs.h +++ b/lib/librte_kvargs/rte_kvargs.h @@ -36,7 +36,19 @@ extern "C" { /** separator character used between key and value */ #define RTE_KVARGS_KV_DELIM "=" -/** Type of callback function used by rte_kvargs_process() */ +/** + * Callback prototype used by rte_kvargs_process(). + * + * @param key + * The key to consider, it will not be NULL. + * @param value + * The value corresponding to the key, it may be NULL (e.g. only with key) + * @param opaque + * An opaque pointer coming from the caller. + * @return + * - >=0 handle key success. + * - <0 on error. + */ typedef int (*arg_handler_t)(const char *key, const char *value, void *opaque); /** A key/value association */ -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:50.556810137 +0000 +++ 0016-kvargs-add-API-documentation-for-process-callback.patch 2023-03-15 22:44:49.567849926 +0000 @@ -1 +1 @@ -From 52ab17efdecf935792ee1d0cb749c0dbd536c083 Mon Sep 17 00:00:00 2001 +From 0929f2bd19ef9c4a3775d392d37ac1459382c1cb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 52ab17efdecf935792ee1d0cb749c0dbd536c083 ] + @@ -14,2 +15,0 @@ -Cc: stable@dpdk.org - @@ -19 +19 @@ - lib/kvargs/rte_kvargs.h | 14 +++++++++++++- + lib/librte_kvargs/rte_kvargs.h | 14 +++++++++++++- @@ -22,4 +22,4 @@ -diff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h -index 359a9f5b09..4900b750bc 100644 ---- a/lib/kvargs/rte_kvargs.h -+++ b/lib/kvargs/rte_kvargs.h +diff --git a/lib/librte_kvargs/rte_kvargs.h b/lib/librte_kvargs/rte_kvargs.h +index 5b2e164287..a53da40278 100644 +--- a/lib/librte_kvargs/rte_kvargs.h ++++ b/lib/librte_kvargs/rte_kvargs.h