From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AA2641EA5 for ; Wed, 15 Mar 2023 23:47:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4594142BC9; Wed, 15 Mar 2023 23:47:25 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id 3C4C540141 for ; Wed, 15 Mar 2023 23:47:24 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso2302778wmo.0 for ; Wed, 15 Mar 2023 15:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihi43WP6c+yAHc7t04kBNw608C95riDllQ6JyPMw0gs=; b=l/feNHWRsXvgjYnFlqrJbAkUGW4VPO0+G4BheErm+M/miwk2rs0wMhbXMTVP8LwiAg /WDxLtf5EkLFfGP0T1vL5T9eZfEfzJ3/U8F/d3xhgsbVwJp2fzlWfzP1acJIXayjDaiv p/upPcne+SOx+ZQKudSLp13vCBfmVXCpPvbT4nwXDjzVgdFoVTXmD7LwgPZvqeW8wqar MefmEnDrVQGxEBqQ3AWNJFrdfKOsDYdHBXQZJcUwIxyXdwia8NCfZdIzkjf9lGC26g+D lsS9lMYktZg71LDlwXSQcNtVXz5IGQaE2CPik3Zw4dulv6HKzxqw/zyJOP3Q0t7QBakP Cv2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihi43WP6c+yAHc7t04kBNw608C95riDllQ6JyPMw0gs=; b=VdZ2gHyxmaX3Dsu1ecOtKtkUKItgCYxH+GJCxTg/dOwdWNVUI+r3Rf1STDnbO2qRi5 P6XWeTNoR2ZtbPr3coIVLTYF6awlDcdg0KoZ9KpFCcshszdG8cHFZxpP2FRzdoEKncJS /hS6nofnqVc2nbP4a0Q5VQDRwhHTIqciUkm6ml0BTgJ1i1BygOQL4Bc3RgXOT01UPFgm 7LD6yHj74WX0hARpVlbR9+HvMTmWQuLf4rZi8ypA3Qhx6OMGi9pclUAzgJ8iUilO8akX k1tL8DXLCzwr0vzulUGp0UOlkPiKvoRXz9TdCNbYCVDEBjgeweQtw5ap9IamGTLowhHw zdVA== X-Gm-Message-State: AO0yUKUGscChfpoKLfykDWrmp6CjZ/XGmtLlyRebV+ezaK9e4MfhIHNa CcK7JVL3O6x9Fs4Rho8MfnlO2xoQImzrSA== X-Google-Smtp-Source: AK7set9fn57Hj2eqLYTbPqUv5WQ/lTGY1hD5cVcDMnJ0gMj1/DbVPhMN+sKe8UTTcN+qla2VmAi3QA== X-Received: by 2002:a1c:f213:0:b0:3ea:d611:f8 with SMTP id s19-20020a1cf213000000b003ead61100f8mr20789192wmc.38.1678920443855; Wed, 15 Mar 2023 15:47:23 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id f10-20020adffcca000000b002cea8f07813sm5793272wrs.81.2023.03.15.15.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:47:23 -0700 (PDT) From: luca.boccassi@gmail.com To: Chengwen Feng Cc: dpdk stable Subject: patch 'raw/skeleton: fix empty devargs parsing' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:46:11 +0000 Message-Id: <20230315224631.1025649-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/bbedd033a8eb0c80f184b54507610decf179c52f Thanks. Luca Boccassi --- >From bbedd033a8eb0c80f184b54507610decf179c52f Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:12 +0000 Subject: [PATCH] raw/skeleton: fix empty devargs parsing [ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. self_test). Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") Signed-off-by: Chengwen Feng --- drivers/raw/skeleton/skeleton_rawdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c index aa3beaad18..ebb9075dd9 100644 --- a/drivers/raw/skeleton/skeleton_rawdev.c +++ b/drivers/raw/skeleton/skeleton_rawdev.c @@ -659,6 +659,8 @@ skeldev_get_selftest(const char *key __rte_unused, void *opaque) { int *flag = opaque; + if (value == NULL || opaque == NULL) + return -EINVAL; *flag = atoi(value); return 0; } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:50.783085494 +0000 +++ 0020-raw-skeleton-fix-empty-devargs-parsing.patch 2023-03-15 22:44:49.579850177 +0000 @@ -1 +1 @@ -From 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 Mon Sep 17 00:00:00 2001 +From bbedd033a8eb0c80f184b54507610decf179c52f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index b2ca1cc5cd..53fe49f936 100644 +index aa3beaad18..ebb9075dd9 100644 @@ -25 +26 @@ -@@ -664,6 +664,8 @@ skeldev_get_selftest(const char *key __rte_unused, +@@ -659,6 +659,8 @@ skeldev_get_selftest(const char *key __rte_unused,