From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4F4041EA5 for ; Wed, 15 Mar 2023 23:47:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0A8A4282D; Wed, 15 Mar 2023 23:47:55 +0100 (CET) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id B575940141 for ; Wed, 15 Mar 2023 23:47:54 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id az3-20020a05600c600300b003ed2920d585so1999272wmb.2 for ; Wed, 15 Mar 2023 15:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sVzokHRscPnA0ZxFYGuPfj/A1HrQUTrmF8aWZtrtvS8=; b=ZxeLKRS5Kb7ypqbeHj65ImIc9Q1r2XTqijAqzw7IV9H4SaMDoBjqMrO6IN1Gee0Ft4 Y1a9m59th2Yf/PeHmpow3LiwmrO4/ZtsCLqtT4ak73uPRFuOX/cypttiE7ZK9j83Ybsl /cHAEcmfJbwrJKuH/p652mKeeoQ2Dkoa5vGSXbZz+ZOIuH/hHmD8VvXddIjtudwQnLKn 4RGYuIWOJ2qnasnUgr36vcDEir1m+u+O2n9eeTXam+giv5cLsqGyV/4DJhgMsynlJoD5 B98p3ZGWomaRtvZJWdmNtkDe4sg21wV4RCW026+Xh687kU8Z+IBQYqVgtnQsfZ6Q3VT+ oaqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sVzokHRscPnA0ZxFYGuPfj/A1HrQUTrmF8aWZtrtvS8=; b=BZXKQyDPz6bLEJYLns/FwdlHbuqtcATlEE8apYdnzNFwruKZkikI1egLGs94NU4XyH px06loat/c3lNBFwLOCUW5mdLpdxyhi8Uhn3AjHeHlKU+5+uA7mZo6S3jHXFsOQnSe1O C2AuZXY80QpLnEwIHillnljkiXfYtesQLF66sIbNRKeg8zu72WvJhIkkunPRVaRrMtmP j+q0l3xY2TzQyuE6MJ/i5TVY5BWMu1tvLNtmkqqqT1uGIKZuor6bpEKBNvHYbWdQq+MC jTjL+zjPXXRfHWQfDnipu8Smfe0nf/zq5VXa3bdtUnmQzIRhpRWhzJZfufMIAZD1E7vg s6rQ== X-Gm-Message-State: AO0yUKWY30SU1v042KxFwNWXtuJ1lILlG/M/RIJMuxvwpAPdSH2ksXtD 4N9R8MNra2/dWRi/Lc6j0BnMu81qMM6EiQ== X-Google-Smtp-Source: AK7set/XpmLebBpjKB4LNBQyf3BRV9jK/Sh2svD4jYJj1W5B8XvileP7onRKVmRTBjE+ZJdVwtW1Cw== X-Received: by 2002:a05:600c:1ca3:b0:3ed:2606:d236 with SMTP id k35-20020a05600c1ca300b003ed2606d236mr10053635wms.38.1678920474334; Wed, 15 Mar 2023 15:47:54 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id y25-20020a1c4b19000000b003ed2a3eab71sm3079013wma.31.2023.03.15.15.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:47:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: separate setting hash key' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:46:21 +0000 Message-Id: <20230315224631.1025649-30-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/9e3cfd993627eb4d4c1292df7bf74ae9b8912dc0 Thanks. Luca Boccassi --- >From 9e3cfd993627eb4d4c1292df7bf74ae9b8912dc0 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Fri, 10 Mar 2023 17:35:09 +0800 Subject: [PATCH] net/hns3: separate setting hash key [ upstream commit fe9cc8b88babd0911d91dc194b35c7c352e2bf7b ] The settings of hash key comes from the ethdev ops (like, dev_configure and rss_hash_update) and rte_flow API. For the ethdev ops, driver has to save it to rss_info::key in hns3_hw structure so as to it can be restored when reset is triggered. While rte_flow API no need to use this field to save, they has a global flow_rss_list to maintain all rules which save hash key. And hash key can be restored by this rule information during the reset phase. Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_rss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c index 4b5d6f6e2b..a67795b6ad 100644 --- a/drivers/net/hns3/hns3_rss.c +++ b/drivers/net/hns3/hns3_rss.c @@ -376,8 +376,7 @@ hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo, return ret; } } - /* Update the shadow RSS key with user specified */ - memcpy(hw->rss_info.key, key, hw->rss_key_size); + return 0; } @@ -672,6 +671,8 @@ hns3_dev_rss_hash_update(struct rte_eth_dev *dev, key, hw->rss_key_size); if (ret) goto set_algo_key_fail; + /* Update the shadow RSS key with user specified */ + memcpy(hw->rss_info.key, key, hw->rss_key_size); } rte_spinlock_unlock(&hw->lock); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:51.350181617 +0000 +++ 0030-net-hns3-separate-setting-hash-key.patch 2023-03-15 22:44:49.635851351 +0000 @@ -1 +1 @@ -From fe9cc8b88babd0911d91dc194b35c7c352e2bf7b Mon Sep 17 00:00:00 2001 +From 9e3cfd993627eb4d4c1292df7bf74ae9b8912dc0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fe9cc8b88babd0911d91dc194b35c7c352e2bf7b ] + @@ -14,2 +15,0 @@ -Cc: stable@dpdk.org - @@ -23 +23 @@ -index dcd42b554a..401e3adfdf 100644 +index 4b5d6f6e2b..a67795b6ad 100644 @@ -26 +26 @@ -@@ -376,8 +376,7 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo, +@@ -376,8 +376,7 @@ hns3_set_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,