From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9D6941EA5 for ; Wed, 15 Mar 2023 23:48:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A49DD410FB; Wed, 15 Mar 2023 23:48:26 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id E50AF40141 for ; Wed, 15 Mar 2023 23:48:22 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id c8-20020a05600c0ac800b003ed2f97a63eso1994832wmr.3 for ; Wed, 15 Mar 2023 15:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8FCTF58eNQSo1pLD2lmtriy4dCJqXsjVI2MTnzaP7gs=; b=cOAnRoCfd5JHumwK2lxNiIgq/0v2dIK+vSPSeiWM4/0e5HP4T6HIsl5Vs5oeVjIx0Q ZfTwLTRfjSY9nFY43StOxZir1KRqLv+HspWvZ3MC7a2zieiDktKIybZLLZ1bDyXPPR9e 3m+Shwnt2O7wCkZC14OT4nHDuiNVXlEwP7Oe5RqEmTOlgwgMAQifBI80U9oegKDO6M0D fiCNrZ+Q8jYZBsK8I6MVdjHn+I15LvkDvVabKZMMcCt1AnhzF7H37qicBTr9khcBel0U bJkJz/dy0Dz1Tq2VPR8qw1NwbvRQRkKwDuOfQ7PtJxxxPbog3T8WgdDVBc6gXti5lmiT O3Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920502; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8FCTF58eNQSo1pLD2lmtriy4dCJqXsjVI2MTnzaP7gs=; b=7S/VjL/BD0EcmSCkVSIuZa0ar9A6AvnV8PA6DQoZztJaxQ713aPZTEwQRVW2t7IuMA ln3ZR9/EBa94kSSf/3qDzesqp4rx6Q+esf0mDUbawDAGyE3p5iJ/cbjAAeObTxOjUmfu v9ISHea2SguXvNGQGvTT+MPce8Ydrt0rpytqYWUNvK/+LEpjEEuea7W/T9fRQX8/1w0L AVksXttIoD9yRQecQScyeEjicEMnolj7adTH5tl14rVepboPBGsc9YJBtFzU/MEjSMGn 4BmI6F4KbYEWf9kcnL9dpLpMrMSQufG5rqMtxgWUkrdc1yxQIxJ8Z4AmcwG+7Oqo4frL ix4w== X-Gm-Message-State: AO0yUKWX2MA2AFdD4ew13IGA7A2u0Yw5Ur9Vkjt19/+WUszOlja+jFlz neRsq+xu/tD27GEfFlAPh64= X-Google-Smtp-Source: AK7set/RcR0fGdsD0Azw63rHseQVhZXJtv1iRPVu/mzz9il2m5qtdG9Bvi+JEndk29GKZpco3cQH6g== X-Received: by 2002:a05:600c:a04:b0:3eb:2b69:c3c4 with SMTP id z4-20020a05600c0a0400b003eb2b69c3c4mr21469061wmp.36.1678920502660; Wed, 15 Mar 2023 15:48:22 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id s11-20020a05600c45cb00b003e206cc7237sm3533497wmo.24.2023.03.15.15.48.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:48:22 -0700 (PDT) From: luca.boccassi@gmail.com To: Ciara Power Cc: Akhil Goyal , dpdk stable Subject: patch 'app/crypto-perf: fix test file memory leak' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:46:29 +0000 Message-Id: <20230315224631.1025649-38-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/59852707e77878d03d1253ffa2ab283055b790e0 Thanks. Luca Boccassi --- >From 59852707e77878d03d1253ffa2ab283055b790e0 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 10 Mar 2023 13:20:17 +0000 Subject: [PATCH] app/crypto-perf: fix test file memory leak [ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ] A memory leak was detected using the AddressSanitizer tool, when running the crypto-perf application with a test vector file. The strdup function used returns a pointer to a null-terminated byte string, which must be freed after use. This patch frees the pointer in an error case, and also after a successful run. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Ciara Power Acked-by: Akhil Goyal --- app/test-crypto-perf/cperf_options_parsing.c | 1 + app/test-crypto-perf/cperf_test_vector_parsing.c | 1 + 2 files changed, 2 insertions(+) diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c index e84f56cfaa..372cae343a 100644 --- a/app/test-crypto-perf/cperf_options_parsing.c +++ b/app/test-crypto-perf/cperf_options_parsing.c @@ -496,6 +496,7 @@ parse_test_file(struct cperf_options *opts, if (access(opts->test_file, F_OK) != -1) return 0; RTE_LOG(ERR, USER1, "Test vector file doesn't exist\n"); + free(opts->test_file); return -1; } diff --git a/app/test-crypto-perf/cperf_test_vector_parsing.c b/app/test-crypto-perf/cperf_test_vector_parsing.c index 1e9dfcfff0..1fe11df27b 100644 --- a/app/test-crypto-perf/cperf_test_vector_parsing.c +++ b/app/test-crypto-perf/cperf_test_vector_parsing.c @@ -28,6 +28,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts) rte_free(vector->cipher_key.data); rte_free(vector->auth_key.data); rte_free(vector->ciphertext.data); + free(opts->test_file); } rte_free(vector); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:51.800110186 +0000 +++ 0038-app-crypto-perf-fix-test-file-memory-leak.patch 2023-03-15 22:44:49.667852022 +0000 @@ -1 +1 @@ -From 430c35730e09dea162b7830b4719285eb6f36364 Mon Sep 17 00:00:00 2001 +From 59852707e77878d03d1253ffa2ab283055b790e0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 430c35730e09dea162b7830b4719285eb6f36364 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 8c9f632590..26136a52ae 100644 +index e84f56cfaa..372cae343a 100644 @@ -27 +28 @@ -@@ -519,6 +519,7 @@ parse_test_file(struct cperf_options *opts, +@@ -496,6 +496,7 @@ parse_test_file(struct cperf_options *opts, @@ -36 +37 @@ -index 98e46c3381..737d61d4af 100644 +index 1e9dfcfff0..1fe11df27b 100644 @@ -39 +40 @@ -@@ -30,6 +30,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts) +@@ -28,6 +28,7 @@ free_test_vector(struct cperf_test_vector *vector, struct cperf_options *opts)