From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F2FC41EA5 for ; Wed, 15 Mar 2023 23:46:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51D914282D; Wed, 15 Mar 2023 23:46:38 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id DE59340141 for ; Wed, 15 Mar 2023 23:46:36 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id l12so10409130wrm.10 for ; Wed, 15 Mar 2023 15:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678920396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mHXSj34rxMzqj1nr2GPnvBxnOLY/IdlOPPszkYXzSo4=; b=jZGiZH5KlQnOiwDhJfwenRIjMEI4bqSrzCKgAahLiAF1MpCHtEp4b9OVMygWbPUuEK bk0r8ZqCQnheAThlVk7WUUn5o+smHtP6DFp4VsCooPCvW9g3DiUljVyUbcv0eYILe+G3 6LUL/v6H4EHNtEU1V0ysQk4pz+pw5iqAEBwEX1P7IXPOrBN95UNqIzMNeMoqubWbReQV k5muuDU+rwT4IZejupRAvzlHch16UaRIqXNKYdILLbj2WS76x0FreTQe2hhSUOMXGcw1 nMxCw4IY0sLCvL+aP+b1MliiNGgr+Zns7opJmNOY/peAsNgo5g8Fpn4dDdO9V/UkVfwh 7ZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678920396; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mHXSj34rxMzqj1nr2GPnvBxnOLY/IdlOPPszkYXzSo4=; b=DMFKHPy/0v0c/ugxoOglElSbx6q1qNBebUAyKFjzT51TWN8CFIHW7OGodoCCRZGMXO P2JIpbGJmjRziVTk2fgqNkoTQMcRlEXIYlP/TNvIumyaelA82o07wkVs/WPad9QYjZJA XVfDVwaKDu7+18wI0nG61pUSRu2xGqskGk1Qofk6OnlTyWHwOAgd4tjMLAKvV+lJqbnO K53UkBG51WZmSLYeQhG3y63DjaGlBFkKTaw1EGyUo+ApWr2kyDk1ziq9zfGsJg9LLeVe bIn3XNySny5dUhPcC0/O69p56fj18qnBbOJXfnHRIBqYnhLzQBwiEu8Mdf9h58Yi7Xx4 zkTA== X-Gm-Message-State: AO0yUKWUwtTST9kP87Bp8rRqLldjcOQ7cDexHVyreGuLiYu7MXQRHryU OTJ5q6lesHvnLyjXwgFhPsw= X-Google-Smtp-Source: AK7set/VY43cAjfRwJKdC5jlcSI+tF4jTSSxiHPIGmVdm4P7Yuc5btVXPdK5hKcxBdP1Y5HedhaWWg== X-Received: by 2002:a5d:56c8:0:b0:2cf:ebaa:31a0 with SMTP id m8-20020a5d56c8000000b002cfebaa31a0mr3203459wrw.54.1678920396625; Wed, 15 Mar 2023 15:46:36 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id i2-20020a5d55c2000000b002c53f6c7599sm5633769wrw.29.2023.03.15.15.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:46:36 -0700 (PDT) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'test/bbdev: extend HARQ tolerance' has been queued to stable release 20.11.8 Date: Wed, 15 Mar 2023 22:45:55 +0000 Message-Id: <20230315224631.1025649-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315224631.1025649-1-luca.boccassi@gmail.com> References: <20230223093715.3926893-71-luca.boccassi@gmail.com> <20230315224631.1025649-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/83969dbe773464e827abf2816346532b372486dd Thanks. Luca Boccassi --- >From 83969dbe773464e827abf2816346532b372486dd Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Thu, 2 Mar 2023 12:21:56 -0800 Subject: [PATCH] test/bbdev: extend HARQ tolerance [ upstream commit 39b601c462b8192b8f1c98fe26b604430ebcc8e4 ] HARQ memory implementation could have different size assumptions. Extending HARQ tolerance to cover different implementations. Fixes: 335c11fd2763 ("app/bbdev: support HARQ validation") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 5f8bd91ac7..7c29b4bcee 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -87,6 +87,7 @@ #define K0_3_1 56 /* K0 fraction numerator for rv 3 and BG 1 */ #define K0_3_2 43 /* K0 fraction numerator for rv 3 and BG 2 */ +#define HARQ_MEM_TOLERANCE 256 static struct test_bbdev_vector test_vector; /* Switch between PMD and Interrupt for throughput TC */ @@ -1904,13 +1905,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, uint16_t data_len = rte_pktmbuf_data_len(m) - offset; total_data_size += orig_op->segments[i].length; - TEST_ASSERT(orig_op->segments[i].length < - (uint32_t)(data_len + 64), + TEST_ASSERT(orig_op->segments[i].length < (uint32_t)(data_len + HARQ_MEM_TOLERANCE), "Length of segment differ in original (%u) and filled (%u) op", orig_op->segments[i].length, data_len); harq_orig = (int8_t *) orig_op->segments[i].addr; harq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset); + /* Cannot compare HARQ output data for such cases */ + if ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION) + || (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION))) + break; + if (!(ldpc_cap_flags & RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS ) || (ops_ld->op_flags & @@ -1986,7 +1991,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, /* Validate total mbuf pkt length */ uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset; - TEST_ASSERT(total_data_size < pkt_len + 64, + TEST_ASSERT(total_data_size < pkt_len + HARQ_MEM_TOLERANCE, "Length of data differ in original (%u) and filled (%u) op", total_data_size, pkt_len); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-15 22:44:49.870332790 +0000 +++ 0004-test-bbdev-extend-HARQ-tolerance.patch 2023-03-15 22:44:49.487848248 +0000 @@ -1 +1 @@ -From 39b601c462b8192b8f1c98fe26b604430ebcc8e4 Mon Sep 17 00:00:00 2001 +From 83969dbe773464e827abf2816346532b372486dd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 39b601c462b8192b8f1c98fe26b604430ebcc8e4 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 027f32cbf1..74e7e13940 100644 +index 5f8bd91ac7..7c29b4bcee 100644 @@ -22 +23 @@ -@@ -95,6 +95,7 @@ +@@ -87,6 +87,7 @@ @@ -30 +31 @@ -@@ -2090,13 +2091,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -1904,13 +1905,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, @@ -50 +51 @@ -@@ -2172,7 +2177,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, +@@ -1986,7 +1991,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,