From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD30842800 for ; Wed, 22 Mar 2023 01:42:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B859942B7E; Wed, 22 Mar 2023 01:42:19 +0100 (CET) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id BB7C540F18 for ; Wed, 22 Mar 2023 01:42:17 +0100 (CET) Received: by mail-wr1-f41.google.com with SMTP id m2so15435035wrh.6 for ; Tue, 21 Mar 2023 17:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679445737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qi4qVQWrNhy8es4Kmu9oR1vWU1FFQH5oaXHwZDmEFeA=; b=nmCXKeKAhEbz6bqW75UcZ5NRUhV5LYgusBO6aam/NbjQbou6lumRsuE4tOu7MER5IV DsPF9nlia0OapUHrv86Q+JccIlZl+tvRkRekm9s9CS05IjHB8+n5opC/hnSqOZNpBSYk uBtggS9/0dTF3hOFnV7RsQwdM2/WLF97QhUSvwJuExP+uX4t3SyF3jkFg4Ba3xbY1OO/ Mue+S+72XhRYkvo8iNSeW5KpmyoihUwbU4C6jXpnSm2+MyxpqkquSykksP+auiviwTTl EsFshyFQ52umUbTvl+Zd6P8GHL1coEWVKSioYOfCJJLUQtWUgx+tYjnDwd/wOQivldOh qAGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679445737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qi4qVQWrNhy8es4Kmu9oR1vWU1FFQH5oaXHwZDmEFeA=; b=kIBc44ufVtdwccVSR666PixI7YZ7zBHPBDy3VPruByZVYrN+2yk5pkL+4xEA2ISVTt gTbnSpe5vzo4vAejs530rae1C4mRvhcyZj0s/+RXxiDAfv1JZbE3lfJVAhLPDgh9cvK0 D+dhnSecjhuZ9CPkFn6TPEou1AHvsCydyB2AHZX3jLdFsRP7OSCW0Nlx+byASt9Xpw95 WsIuDN51FYjvKnnjE/z8Z6xN/nZHXI48JJLy7JzT3rxRFOnaZ4bY1VR/vGmhGrrEzsP2 HUQXJyeEvxziuHsHwBA52sJeJzurVAQfQTihkOvv9SJBNyBqrnuceavUR4oIklUWNDuQ uhcw== X-Gm-Message-State: AO0yUKWwdetSWMeWnrCkZSmmJUD1ZuQNFk7SSc9gboaC6qG4/oX5tHvy +z+1Qp1UXlU10gjvqrQb2o4= X-Google-Smtp-Source: AK7set97JMjv3M2eUdHoP+KXyb6CS5AeJc2d0+PdHXFLG5a6ZGtogosXwjp2GQYl5G29elE1fiFrDw== X-Received: by 2002:adf:f5cd:0:b0:2cf:6089:2408 with SMTP id k13-20020adff5cd000000b002cf60892408mr427906wrp.0.1679445737294; Tue, 21 Mar 2023 17:42:17 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id x2-20020a5d60c2000000b002cfe71153b4sm12503845wrt.60.2023.03.21.17.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 17:42:16 -0700 (PDT) From: luca.boccassi@gmail.com To: Hernan Vargas Cc: Maxime Coquelin , dpdk stable Subject: patch 'app/bbdev: check statistics failure' has been queued to stable release 20.11.8 Date: Wed, 22 Mar 2023 00:41:45 +0000 Message-Id: <20230322004155.2333903-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230322004155.2333903-1-luca.boccassi@gmail.com> References: <20230315224631.1025649-39-luca.boccassi@gmail.com> <20230322004155.2333903-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/23/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/cca066629471a2c227828ad1ec3965a64b3373d2 Thanks. Luca Boccassi --- >From cca066629471a2c227828ad1ec3965a64b3373d2 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Wed, 8 Mar 2023 19:36:24 -0800 Subject: [PATCH] app/bbdev: check statistics failure [ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 1675b90c79..019798214d 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -4703,7 +4703,7 @@ offload_cost_test(struct active_device *ad, printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n"); return TEST_SKIPPED; #else - int iter; + int iter, ret; uint16_t burst_sz = op_params->burst_sz; const uint16_t num_to_process = op_params->num_to_process; const enum rte_bbdev_op_type op_type = test_vector.op_type; @@ -4794,7 +4794,10 @@ offload_cost_test(struct active_device *ad, rte_get_tsc_hz()); struct rte_bbdev_stats stats = {0}; - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + TEST_ASSERT_SUCCESS(ret, + "Failed to get stats for queue (%u) of device (%u)", + queue_id, ad->dev_id); if (op_type != RTE_BBDEV_OP_LDPC_DEC) { TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process, "Mismatch in enqueue count %10"PRIu64" %d", -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-21 21:56:37.423196547 +0000 +++ 0009-app-bbdev-check-statistics-failure.patch 2023-03-21 21:56:37.064806882 +0000 @@ -1 +1 @@ -From ce1b62899167f6e2c49d8496afa43a9162167c6b Mon Sep 17 00:00:00 2001 +From cca066629471a2c227828ad1ec3965a64b3373d2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 15ebcdfc15..276bbf0a2e 100644 +index 1675b90c79..019798214d 100644 @@ -22,4 +23,4 @@ -@@ -5679,7 +5679,7 @@ static int - offload_cost_test(struct active_device *ad, - struct test_op_params *op_params) - { +@@ -4703,7 +4703,7 @@ offload_cost_test(struct active_device *ad, + printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n"); + return TEST_SKIPPED; + #else @@ -31 +32 @@ -@@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, +@@ -4794,7 +4794,10 @@ offload_cost_test(struct active_device *ad, @@ -40,3 +41,3 @@ - if (stats.enqueue_warn_count > 0) - printf("Warning reported on the queue : %10"PRIu64"\n", - stats.enqueue_warn_count); + if (op_type != RTE_BBDEV_OP_LDPC_DEC) { + TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process, + "Mismatch in enqueue count %10"PRIu64" %d",