From: Erez Shitrit <erezsh@nvidia.com>
To: <dev@dpdk.org>
Cc: <stable@dpdk.org>, Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: [PATCH v4] net/mlx5/hws: fix saving of jumbo tag for deletion
Date: Wed, 22 Mar 2023 16:44:13 +0200 [thread overview]
Message-ID: <20230322144413.656047-1-erezsh@nvidia.com> (raw)
In-Reply-To: <20230322101621.642765-3-erezsh@nvidia.com>
In cases with more than one STE we didn't update the whole tag
of the match jumbo STE, Instead of 11B we kept only 8B like in
regular STE.
The ste_attr that keeps that indication was not updated at the
last iteration.
Now we indicate it is a jumbo frame before saving the tag for
future deletion of it.
Fixes: 405242c52dd5 ("net/mlx5/hws: add rule object")
Cc: stable@dpdk.org
Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
Reviewed-by: Alex Vesker <valex@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_rule.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c
index 9d5e5b11a5..2418ca0b26 100644
--- a/drivers/net/mlx5/hws/mlx5dr_rule.c
+++ b/drivers/net/mlx5/hws/mlx5dr_rule.c
@@ -116,6 +116,9 @@ static void
mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule,
struct mlx5dr_send_ste_attr *ste_attr)
{
+ struct mlx5dr_match_template *mt = rule->matcher->mt;
+ bool is_jumbo = mlx5dr_matcher_mt_is_jumbo(mt);
+
if (unlikely(mlx5dr_matcher_req_fw_wqe(rule->matcher))) {
uint8_t *src_tag;
@@ -136,7 +139,7 @@ mlx5dr_rule_save_delete_info(struct mlx5dr_rule *rule,
return;
}
- if (ste_attr->wqe_tag_is_jumbo)
+ if (is_jumbo)
memcpy(rule->tag.jumbo, ste_attr->wqe_data->jumbo, MLX5DR_JUMBO_TAG_SZ);
else
memcpy(rule->tag.match, ste_attr->wqe_data->tag, MLX5DR_MATCH_TAG_SZ);
--
2.18.2
next prev parent reply other threads:[~2023-03-22 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 10:16 [PATCH] net/mlx5/hws: fix bug in pattern creation Erez Shitrit
2023-03-22 10:16 ` [PATCH] net/mlx5/hws: fix shared context to use local defaults Erez Shitrit
2023-03-22 12:26 ` Raslan Darawsheh
2023-03-22 14:42 ` [PATCH v4] " Erez Shitrit
2023-03-23 7:20 ` Raslan Darawsheh
2023-03-22 10:16 ` [PATCH] net/mlx5/hws: fix saving of jumbo tag for deletion Erez Shitrit
2023-03-22 14:44 ` Erez Shitrit [this message]
2023-03-23 7:20 ` [PATCH v4] " Raslan Darawsheh
2023-03-22 14:41 ` [PATCH v4] net/mlx5/hws: fix bug in pattern creation Erez Shitrit
2023-03-23 7:19 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322144413.656047-1-erezsh@nvidia.com \
--to=erezsh@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).