From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7138942805 for ; Wed, 22 Mar 2023 18:29:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64952427F2; Wed, 22 Mar 2023 18:29:53 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id C8E5040A84; Wed, 22 Mar 2023 18:29:50 +0100 (CET) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32MGiV3q026147; Wed, 22 Mar 2023 17:29:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=V6JCnK3mNYfQ/lJWY05cHTlwf4yiVVXxI7MAurf+CC8=; b=c8nV2WZhyhHA73rXTs6k0JCdvW4JUYjYGZLwh5PitU/aYQweUfZDte0bsR0O6VzonyDG CWfgrZeKVJWT2Qy/uZKdPROJuf/Byb9CZm0m0dj4t/r5+fvVRTBNcS1RQ3PsU4tBb5Tc T/zDOCy0yl1uMVOG7ls8qsXUNtmdPfSV3M3yUD2vR0b3VKRP/yFoXMlr+yS/DzcFDoyZ F9g/JqHsmSyFIIM+gWJZ6p3Dgg6P1v0g8Qyh4mLRrEGpdaq+2B3O8YeqLGq2osR9G4lM nyfH9ah70Tvu8K0s9Fspy9o0q2WxbEt9P0sA4KQktFccRObN5asucwvC6h6ozFp1Qw5I cQ== Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pg5f596fk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 17:29:49 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32MEk3Ip002219; Wed, 22 Mar 2023 17:29:49 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma05wdc.us.ibm.com (PPS) with ESMTPS id 3pd4x79er6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 17:29:49 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32MHTlRA39387478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Mar 2023 17:29:48 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B9D3C58063; Wed, 22 Mar 2023 17:29:47 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 686FB5805D; Wed, 22 Mar 2023 17:29:47 +0000 (GMT) Received: from ltc19u30.pok.stglabs.ibm.com (unknown [9.114.224.51]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Mar 2023 17:29:47 +0000 (GMT) From: David Christensen To: dev@dpdk.org Cc: David Christensen , stable@dpdk.org, Thinh Tran Subject: [PATCH] acl: fix autotest failures on ppc64le with gcc 11 Date: Wed, 22 Mar 2023 13:29:33 -0400 Message-Id: <20230322172933.461482-1-drc@linux.vnet.ibm.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BcGtLsHMggUR2XajGB6yB8Nltg1FgkSS X-Proofpoint-GUID: BcGtLsHMggUR2XajGB6yB8Nltg1FgkSS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_14,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 spamscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303220117 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Original acl implementation of Altivec optimized code included an explicit -O2 optimization level for a particular inlined function. When DPDK is built with the default -O3 optimization level on gcc 11.x or later, the resulting code may generate a segmentation fault as observed in acl_autotest. Since there is no explicit reason given for the local function optimization level in the original commit, and testing with gcc versions 8.x through 12.x results in working code at all -O optimization settings, the local optimization is removed. Bugzilla ID: 1197 Cc: stable@dpdk.org Signed-off-by: David Christensen Tested-by: Thinh Tran --- lib/acl/acl_run_altivec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h index 4dfe7a14b4..4556e1503b 100644 --- a/lib/acl/acl_run_altivec.h +++ b/lib/acl/acl_run_altivec.h @@ -102,7 +102,7 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms, /* * Process 4 transitions (in 2 XMM registers) in parallel */ -static inline __attribute__((optimize("O2"))) xmm_t +static __rte_always_inline xmm_t transition4(xmm_t next_input, const uint64_t *trans, xmm_t *indices1, xmm_t *indices2) { -- 2.31.1