From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53AC442814 for ; Wed, 29 Mar 2023 03:05:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AD8340F18; Wed, 29 Mar 2023 03:05:17 +0200 (CEST) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mails.dpdk.org (Postfix) with ESMTP id 48583410D3 for ; Wed, 29 Mar 2023 03:05:16 +0200 (CEST) Received: by mail-wm1-f52.google.com with SMTP id d11-20020a05600c3acb00b003ef6e6754c5so5037803wms.5 for ; Tue, 28 Mar 2023 18:05:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680051916; x=1682643916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pz2ml0LlNJHu2hKa3dkk1VP97fml2h97Gr+9arIbuy4=; b=X4G5LTKCPSb1XscWyFtPIftHocKp4Wdm0aJbQzXV0WUOPFg/3LuXHrUHXHpHpuaKYC q5O6wOHyl1zA8ZXrbIHh4Ohc5HrHi32CmpuEIvkVQH3vEXaQxtC4qs5v/aWkfRncLLQa 6VrIJccd6lrTGgGxkka8q+vTTL0Qzsb9hS6/jQLj3Sv/+okdxNW8wh2JI5Zfkox6ePnY YBfLdh82jeTg+5HE9uOFiXqyqBd53uF5lMHXmDeGvpt2rbiLh9cdwRbLWr72F+TXiP0n nN7+/IV8RTyrtxWyhOazdL92xL+WYWeW8x182AfkOx1nHBj+uoCd6+nE1Vkwt2j4Aoaq xqeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680051916; x=1682643916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pz2ml0LlNJHu2hKa3dkk1VP97fml2h97Gr+9arIbuy4=; b=Vio8hNfiHAGYDfvBdX/yJUMAfj/OskPHbltIOAsjLcC+UNY+aPKbs8SnE0Hf8WYSmY OeMjIufbGJjzW70TuuRM/TB6YixNV1DydLh+K8hpWPgFEXNeq1qodMbkgINfJZmgxdx5 83VLxTVgIM4UitKWGzAiG3xBXzGWFxQrIzkybAgC/WDPOiVi/eetlVQgEddWPo/ce5u1 +KxhpTtKP4pF/5MF1GHnvQW8TkDI54jUZac11y6iGYJA7Qa7iE+sGOA52ZIk+y0pDPRH DVnNxjcVK0KKHX1Li4d86pgoMPStrHa6oPG96D9/JPPot1PYctc6GgylnuaZNPEtkqGB kM7w== X-Gm-Message-State: AO0yUKVjZyRzdG6DI8BGG6kq1VAvS+PArU2arIRC78VWN09BTud9gc3P Dxmzs3jNaLfEpgY8fmBiqHRgOl1Ee7c= X-Google-Smtp-Source: AK7set9UMAbYIC/n27ufbFsqHefPpK7bDBnpH+244F0TDRPi3g6F/T72y+lkzu3uJVYpaq8Helk1ww== X-Received: by 2002:a05:600c:254:b0:3ed:38e7:af59 with SMTP id 20-20020a05600c025400b003ed38e7af59mr13151275wmj.39.1680051915763; Tue, 28 Mar 2023 18:05:15 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id e13-20020a056000120d00b002d7a75a2c20sm21491270wrx.80.2023.03.28.18.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 18:05:14 -0700 (PDT) From: luca.boccassi@gmail.com To: David Christensen Cc: Thinh Tran , dpdk stable Subject: patch 'acl: fix crash on PPC64 with GCC 11' has been queued to stable release 20.11.8 Date: Wed, 29 Mar 2023 02:04:44 +0100 Message-Id: <20230329010446.563852-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230329010446.563852-1-luca.boccassi@gmail.com> References: <20230322004155.2333903-19-luca.boccassi@gmail.com> <20230329010446.563852-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/01561c4dfd3ce08b058f4b42a45db1da4349381b Thanks. Luca Boccassi --- >From 01561c4dfd3ce08b058f4b42a45db1da4349381b Mon Sep 17 00:00:00 2001 From: David Christensen Date: Wed, 22 Mar 2023 13:29:33 -0400 Subject: [PATCH] acl: fix crash on PPC64 with GCC 11 [ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ] Original ACL implementation of Altivec optimized code included an explicit -O2 optimization level for a particular inlined function. When DPDK is built with the default -O3 optimization level on gcc 11.x or later, the resulting code may generate a segmentation fault as observed in acl_autotest. Since there is no explicit reason given for the local function optimization level in the original commit, and testing with gcc versions 8.x through 12.x results in working code at all -O optimization settings, the local optimization is removed. Bugzilla ID: 1197 Signed-off-by: David Christensen Tested-by: Thinh Tran --- lib/librte_acl/acl_run_altivec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_acl/acl_run_altivec.h b/lib/librte_acl/acl_run_altivec.h index 24a41eec17..317a036c84 100644 --- a/lib/librte_acl/acl_run_altivec.h +++ b/lib/librte_acl/acl_run_altivec.h @@ -102,7 +102,7 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms, /* * Process 4 transitions (in 2 XMM registers) in parallel */ -static inline __attribute__((optimize("O2"))) xmm_t +static __rte_always_inline xmm_t transition4(xmm_t next_input, const uint64_t *trans, xmm_t *indices1, xmm_t *indices2) { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-29 01:31:22.959200805 +0100 +++ 0008-acl-fix-crash-on-PPC64-with-GCC-11.patch 2023-03-29 01:31:22.506039977 +0100 @@ -1 +1 @@ -From 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 Mon Sep 17 00:00:00 2001 +From 01561c4dfd3ce08b058f4b42a45db1da4349381b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ - lib/acl/acl_run_altivec.h | 2 +- + lib/librte_acl/acl_run_altivec.h | 2 +- @@ -26,4 +27,4 @@ -diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h -index 4dfe7a14b4..4556e1503b 100644 ---- a/lib/acl/acl_run_altivec.h -+++ b/lib/acl/acl_run_altivec.h +diff --git a/lib/librte_acl/acl_run_altivec.h b/lib/librte_acl/acl_run_altivec.h +index 24a41eec17..317a036c84 100644 +--- a/lib/librte_acl/acl_run_altivec.h ++++ b/lib/librte_acl/acl_run_altivec.h