patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'examples/qos_sched: fix config entries in wrong sections' has been queued to stable release 21.11.4
Date: Thu, 30 Mar 2023 09:35:53 +0100	[thread overview]
Message-ID: <20230330083600.473876-1-ktraynor@redhat.com> (raw)

Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/02/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/a2a827725722a853d51f54f16c9ad1b7e9fc7df6

Thanks.

Kevin

---
From a2a827725722a853d51f54f16c9ad1b7e9fc7df6 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson@intel.com>
Date: Tue, 21 Mar 2023 13:13:49 +0000
Subject: [PATCH] examples/qos_sched: fix config entries in wrong sections

[ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ]

When specifying the QoS config, the profiles to be used for each pipe
within a subport must be specified in the subport section, not in the
section for the subport profile itself. Similarly for subport profiles,
those should be specified in the port section.

Fixes: de3cfa2c9823 ("sched: initial import")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 examples/qos_sched/profile.cfg    | 4 ++--
 examples/qos_sched/profile_ov.cfg | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg
index 8da5777538..20b8b20f23 100644
--- a/examples/qos_sched/profile.cfg
+++ b/examples/qos_sched/profile.cfg
@@ -27,4 +27,6 @@ number of pipes per subport = 4096
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
+
 [subport profile 0]
 tb rate = 1250000000           ; Bytes per second
@@ -47,6 +49,4 @@ tc 12 rate = 1250000000        ; Bytes per second
 tc period = 10                 ; Milliseconds
 
-pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index 14c89ae340..b6fe21ee1e 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -7,4 +7,6 @@ frame overhead = 24
 number of subports per port = 1
 
+subport 0-8 = 0
+
 ; Subport configuration
 [subport 0]
@@ -12,5 +14,5 @@ number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
-subport 0-8 = 0
+pipe 0-31 = 0               ; These pipes are configured with pipe profile 0
 
 [subport profile 0]
@@ -33,6 +35,4 @@ tc 12 rate = 8400000         ; Bytes per second
 tc period = 10              ; Milliseconds
 
-pipe 0-31 = 0               ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-30 09:30:45.297194890 +0100
+++ 0001-examples-qos_sched-fix-config-entries-in-wrong-secti.patch	2023-03-30 09:30:45.228229225 +0100
@@ -1 +1 @@
-From 86dfed2a8ed704e013f054985a92d46f07ff48d1 Mon Sep 17 00:00:00 2001
+From a2a827725722a853d51f54f16c9ad1b7e9fc7df6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -17,5 +18,3 @@
- examples/qos_sched/profile.cfg     | 6 +++---
- examples/qos_sched/profile_ov.cfg  | 6 +++---
- examples/qos_sched/profile_pie.cfg | 6 +++---
- examples/qos_sched/profile_red.cfg | 6 +++---
- 4 files changed, 12 insertions(+), 12 deletions(-)
+ examples/qos_sched/profile.cfg    | 4 ++--
+ examples/qos_sched/profile_ov.cfg | 6 +++---
+ 2 files changed, 5 insertions(+), 5 deletions(-)
@@ -24 +23 @@
-index e8de101b6c..00d4c7c1a5 100644
+index 8da5777538..20b8b20f23 100644
@@ -41,6 +39,0 @@
-@@ -72,3 +72,3 @@ tc period = 40                ; Milliseconds
- tc 12 oversubscription weight = 1
- 
--tc 12 wrr weights = 1 1 1 1
-\ No newline at end of file
-+tc 12 wrr weights = 1 1 1 1
@@ -69,50 +61,0 @@
--
- ; Pipe configuration
- [pipe profile 0]
-diff --git a/examples/qos_sched/profile_pie.cfg b/examples/qos_sched/profile_pie.cfg
-index 241f748b33..bbc09d912b 100644
---- a/examples/qos_sched/profile_pie.cfg
-+++ b/examples/qos_sched/profile_pie.cfg
-@@ -22,4 +22,6 @@ frame overhead = 24
- number of subports per port = 1
- 
-+subport 0-8 = 0                ; These subports are configured with subport profile 0
-+
- ; Subport configuration
- [subport 0]
-@@ -27,5 +29,5 @@ number of pipes per subport = 4096
- queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
- 
--subport 0-8 = 0                ; These subports are configured with subport profile 0
-+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
- 
- [subport profile 0]
-@@ -49,6 +51,4 @@ tc 12 rate = 1250000000        ; Bytes per second
- tc period = 10                 ; Milliseconds
- 
--pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
--
- ; Pipe configuration
- [pipe profile 0]
-diff --git a/examples/qos_sched/profile_red.cfg b/examples/qos_sched/profile_red.cfg
-index 4486d2799e..cee1470fd7 100644
---- a/examples/qos_sched/profile_red.cfg
-+++ b/examples/qos_sched/profile_red.cfg
-@@ -22,4 +22,6 @@ frame overhead = 24
- number of subports per port = 1
- 
-+subport 0-8 = 0                ; These subports are configured with subport profile 0
-+
- ; Subport configuration
- [subport 0]
-@@ -27,5 +29,5 @@ number of pipes per subport = 4096
- queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
- 
--subport 0-8 = 0                ; These subports are configured with subport profile 0
-+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
- 
- [subport profile 0]
-@@ -49,6 +51,4 @@ tc 12 rate = 1250000000        ; Bytes per second
- tc period = 10                 ; Milliseconds
- 
--pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0


             reply	other threads:[~2023-03-30  8:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-30  8:35 Kevin Traynor [this message]
2023-03-30  8:35 ` patch 'net/mlx5: fix build with GCC 12 and ASan' " Kevin Traynor
2023-03-30  8:35 ` patch 'net/mlx5: fix CQE dump for Tx' " Kevin Traynor
2023-03-30  8:35 ` patch 'net/mlx5: fix sysfs port name translation' " Kevin Traynor
2023-03-30  8:35 ` patch 'test/crypto: fix statistics error messages' " Kevin Traynor
2023-03-30  8:35 ` patch 'pdump: fix build with GCC 12' " Kevin Traynor
2023-03-30  8:35 ` patch 'acl: fix crash on PPC64 with GCC 11' " Kevin Traynor
2023-03-30  8:36 ` patch 'doc: fix pipeline example path in user guide' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230330083600.473876-1-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).