From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DD8242850 for ; Thu, 30 Mar 2023 10:36:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35BE6410D3; Thu, 30 Mar 2023 10:36:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C20FB40685 for ; Thu, 30 Mar 2023 10:36:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680165369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L2cohvvANl8s9LfjGwImnDahGHCYDlvicS9Gzda308Q=; b=FKGLf2wBLAhj+0yt5EgvGEr6L3+1WbhQC8sf7+EzWmsEqBZJO/IjoBfgAbKHddvdZvuw/0 /qs3QKUkEZCMGX4Ymya3Lujsfcljjv3WN3HkFjuL67fIyzQG+Z8cwK9L0751V/SlD/jaFc xJoYKlk7AfySqX8L+rPOW2NIS9tHUmM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-QZKGMfeHM2aC6jYw_w5H3Q-1; Thu, 30 Mar 2023 04:36:05 -0400 X-MC-Unique: QZKGMfeHM2aC6jYw_w5H3Q-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 392F8280D594; Thu, 30 Mar 2023 08:36:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 92B0D40521FD; Thu, 30 Mar 2023 08:36:04 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Cristian Dumitrescu , dpdk stable Subject: patch 'examples/qos_sched: fix config entries in wrong sections' has been queued to stable release 21.11.4 Date: Thu, 30 Mar 2023 09:35:53 +0100 Message-Id: <20230330083600.473876-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/02/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a2a827725722a853d51f54f16c9ad1b7e9fc7df6 Thanks. Kevin --- >From a2a827725722a853d51f54f16c9ad1b7e9fc7df6 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 21 Mar 2023 13:13:49 +0000 Subject: [PATCH] examples/qos_sched: fix config entries in wrong sections [ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ] When specifying the QoS config, the profiles to be used for each pipe within a subport must be specified in the subport section, not in the section for the subport profile itself. Similarly for subport profiles, those should be specified in the port section. Fixes: de3cfa2c9823 ("sched: initial import") Signed-off-by: Bruce Richardson Acked-by: Cristian Dumitrescu --- examples/qos_sched/profile.cfg | 4 ++-- examples/qos_sched/profile_ov.cfg | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg index 8da5777538..20b8b20f23 100644 --- a/examples/qos_sched/profile.cfg +++ b/examples/qos_sched/profile.cfg @@ -27,4 +27,6 @@ number of pipes per subport = 4096 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 + [subport profile 0] tb rate = 1250000000 ; Bytes per second @@ -47,6 +49,4 @@ tc 12 rate = 1250000000 ; Bytes per second tc period = 10 ; Milliseconds -pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 - ; Pipe configuration [pipe profile 0] diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg index 14c89ae340..b6fe21ee1e 100644 --- a/examples/qos_sched/profile_ov.cfg +++ b/examples/qos_sched/profile_ov.cfg @@ -7,4 +7,6 @@ frame overhead = 24 number of subports per port = 1 +subport 0-8 = 0 + ; Subport configuration [subport 0] @@ -12,5 +14,5 @@ number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 -subport 0-8 = 0 +pipe 0-31 = 0 ; These pipes are configured with pipe profile 0 [subport profile 0] @@ -33,6 +35,4 @@ tc 12 rate = 8400000 ; Bytes per second tc period = 10 ; Milliseconds -pipe 0-31 = 0 ; These pipes are configured with pipe profile 0 - ; Pipe configuration [pipe profile 0] -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-30 09:30:45.297194890 +0100 +++ 0001-examples-qos_sched-fix-config-entries-in-wrong-secti.patch 2023-03-30 09:30:45.228229225 +0100 @@ -1 +1 @@ -From 86dfed2a8ed704e013f054985a92d46f07ff48d1 Mon Sep 17 00:00:00 2001 +From a2a827725722a853d51f54f16c9ad1b7e9fc7df6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17,5 +18,3 @@ - examples/qos_sched/profile.cfg | 6 +++--- - examples/qos_sched/profile_ov.cfg | 6 +++--- - examples/qos_sched/profile_pie.cfg | 6 +++--- - examples/qos_sched/profile_red.cfg | 6 +++--- - 4 files changed, 12 insertions(+), 12 deletions(-) + examples/qos_sched/profile.cfg | 4 ++-- + examples/qos_sched/profile_ov.cfg | 6 +++--- + 2 files changed, 5 insertions(+), 5 deletions(-) @@ -24 +23 @@ -index e8de101b6c..00d4c7c1a5 100644 +index 8da5777538..20b8b20f23 100644 @@ -41,6 +39,0 @@ -@@ -72,3 +72,3 @@ tc period = 40 ; Milliseconds - tc 12 oversubscription weight = 1 - --tc 12 wrr weights = 1 1 1 1 -\ No newline at end of file -+tc 12 wrr weights = 1 1 1 1 @@ -69,50 +61,0 @@ -- - ; Pipe configuration - [pipe profile 0] -diff --git a/examples/qos_sched/profile_pie.cfg b/examples/qos_sched/profile_pie.cfg -index 241f748b33..bbc09d912b 100644 ---- a/examples/qos_sched/profile_pie.cfg -+++ b/examples/qos_sched/profile_pie.cfg -@@ -22,4 +22,6 @@ frame overhead = 24 - number of subports per port = 1 - -+subport 0-8 = 0 ; These subports are configured with subport profile 0 -+ - ; Subport configuration - [subport 0] -@@ -27,5 +29,5 @@ number of pipes per subport = 4096 - queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 - --subport 0-8 = 0 ; These subports are configured with subport profile 0 -+pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 - - [subport profile 0] -@@ -49,6 +51,4 @@ tc 12 rate = 1250000000 ; Bytes per second - tc period = 10 ; Milliseconds - --pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 -- - ; Pipe configuration - [pipe profile 0] -diff --git a/examples/qos_sched/profile_red.cfg b/examples/qos_sched/profile_red.cfg -index 4486d2799e..cee1470fd7 100644 ---- a/examples/qos_sched/profile_red.cfg -+++ b/examples/qos_sched/profile_red.cfg -@@ -22,4 +22,6 @@ frame overhead = 24 - number of subports per port = 1 - -+subport 0-8 = 0 ; These subports are configured with subport profile 0 -+ - ; Subport configuration - [subport 0] -@@ -27,5 +29,5 @@ number of pipes per subport = 4096 - queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 - --subport 0-8 = 0 ; These subports are configured with subport profile 0 -+pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0 - - [subport profile 0] -@@ -49,6 +51,4 @@ tc 12 rate = 1250000000 ; Bytes per second - tc period = 10 ; Milliseconds - --pipe 0-4095 = 0 ; These pipes are configured with pipe profile 0