From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1E9742850 for ; Thu, 30 Mar 2023 10:36:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE2F942B71; Thu, 30 Mar 2023 10:36:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9AFC5410F3 for ; Thu, 30 Mar 2023 10:36:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680165375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GMGz/71N0hp96ymeMjZB6UnLBDD6Xk7MMouiHokcvXE=; b=LUEN9q1pqpN37WmfeIJplS53Z5R0fcTLBzINSNHcfDobL9TW7WI0+9CMdr2PjQs7Kfwxad NbZvP3TewTH/n1UrHevPOJonDoYobH1Lttyg/09gJwUu71Zk2RQsVCNFf4eso/IAghpNYx yc5Iyy3kCA+/iVXJX1NoaySvcYe7RX8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-iJTawEDGNAmLeqPfFMAcOA-1; Thu, 30 Mar 2023 04:36:11 -0400 X-MC-Unique: iJTawEDGNAmLeqPfFMAcOA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D0E43C10ECD; Thu, 30 Mar 2023 08:36:11 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 565B040521FD; Thu, 30 Mar 2023 08:36:10 +0000 (UTC) From: Kevin Traynor To: David Christensen Cc: Thinh Tran , dpdk stable Subject: patch 'acl: fix crash on PPC64 with GCC 11' has been queued to stable release 21.11.4 Date: Thu, 30 Mar 2023 09:35:59 +0100 Message-Id: <20230330083600.473876-7-ktraynor@redhat.com> In-Reply-To: <20230330083600.473876-1-ktraynor@redhat.com> References: <20230330083600.473876-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/02/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/27af78b522f13ed10453373a87c0db6389c9a6cd Thanks. Kevin --- >From 27af78b522f13ed10453373a87c0db6389c9a6cd Mon Sep 17 00:00:00 2001 From: David Christensen Date: Wed, 22 Mar 2023 13:29:33 -0400 Subject: [PATCH] acl: fix crash on PPC64 with GCC 11 [ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ] Original ACL implementation of Altivec optimized code included an explicit -O2 optimization level for a particular inlined function. When DPDK is built with the default -O3 optimization level on gcc 11.x or later, the resulting code may generate a segmentation fault as observed in acl_autotest. Since there is no explicit reason given for the local function optimization level in the original commit, and testing with gcc versions 8.x through 12.x results in working code at all -O optimization settings, the local optimization is removed. Bugzilla ID: 1197 Signed-off-by: David Christensen Tested-by: Thinh Tran --- lib/acl/acl_run_altivec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h index 4dfe7a14b4..4556e1503b 100644 --- a/lib/acl/acl_run_altivec.h +++ b/lib/acl/acl_run_altivec.h @@ -103,5 +103,5 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms, * Process 4 transitions (in 2 XMM registers) in parallel */ -static inline __attribute__((optimize("O2"))) xmm_t +static __rte_always_inline xmm_t transition4(xmm_t next_input, const uint64_t *trans, xmm_t *indices1, xmm_t *indices2) -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-03-30 09:30:45.465810753 +0100 +++ 0008-acl-fix-crash-on-PPC64-with-GCC-11.patch 2023-03-30 09:30:45.275229273 +0100 @@ -1 +1 @@ -From 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 Mon Sep 17 00:00:00 2001 +From 27af78b522f13ed10453373a87c0db6389c9a6cd Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org