patches for DPDK stable branches
 help / color / mirror / Atom feed
From: <eagostini@nvidia.com>
To: <dev@dpdk.org>
Cc: <stable@dpdk.org>, <thomas@monjalon.net>,
	Elena Agostini <eagostini@nvidia.com>, <xiaoyun.li@intel.com>
Subject: [PATCH v2] net: fix return type of IPv6 L4 packet checksum
Date: Thu, 6 Apr 2023 09:49:44 +0000	[thread overview]
Message-ID: <20230406094944.821106-1-eagostini@nvidia.com> (raw)
In-Reply-To: <20230406092129.820449-1-eagostini@nvidia.com>

From: Elena Agostini <eagostini@nvidia.com>

Function returns 0 or -1 but the return type is uint16_t.

Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")
Cc: xiaoyun.li@intel.com

Signed-off-by: Elena Agostini <eagostini@nvidia.com>

---
V2:
   added fixline and fixed cc address
---
---
 lib/net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index a310e9d498..e7106256aa 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
  *   Return 0 if the checksum is correct, else -1.
  */
 __rte_experimental
-static inline uint16_t
+static inline int
 rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
 				  const struct rte_ipv4_hdr *ipv4_hdr,
 				  uint16_t l4_off)
-- 
2.34.1


       reply	other threads:[~2023-04-06  9:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230406092129.820449-1-eagostini@nvidia.com>
2023-04-06  9:49 ` eagostini [this message]
2023-04-12  8:22   ` Thomas Monjalon
2023-04-12  8:26     ` Thomas Monjalon
2023-04-12  8:24   ` [PATCH v3] net: fix return type of IPv4 " eagostini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230406094944.821106-1-eagostini@nvidia.com \
    --to=eagostini@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).