From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6522F428F8 for ; Sun, 9 Apr 2023 17:35:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58AB042D0C; Sun, 9 Apr 2023 17:35:01 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by mails.dpdk.org (Postfix) with ESMTP id B8F7542D0C for ; Sun, 9 Apr 2023 17:34:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oav+g3kf9GWHkmufuQiozO3MFBVHTq3gG1AMTnBKZSBltLByZcdevhej4yHnXIXsGMkgCXjd/CSKiQDb6TyQD24+wB+EOo+Iy4bWqCJGiFd81pcCTtly9jD/0v/q5XrvZQluFRKpw9xe1DfHXzkJaBR6AkmrPenBtZ+BEFKpXuKZ3akUqfDHiH7JscGL1kjDBr+iNDcqzrbBhbkKg883Rk34BVD0r18mBKt5z81Q/5uH51+R0fPsX0ZCdWhjBAd2uge1XNsNxHX+djyHXjtbB4JSw+4frZqmnH7UaQrNqg4vzryu4b8BEFP/u0fHlSk110bLKRr8qI+gK9iUoxYjVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q9tbKm+XAkk7c7Xr58uHgFhyv3zKUYFidML4BRzRy70=; b=NMb2/LICngPMXcW6ZrE96MqXzrns+b+LQLc8ix6ajrk14WaC2qfXQI3Z5r/ozCHcUPXLH0Xm4EGSZz3rznl0W9hdXaKpfD9BdCGr7Jq9UKsQ4jXxRY2iboVXSbz97v73f2bCF/6JFl9Pp8e5+rLtTSr8JVfkyeHhHflkzvVTg0WBFiQnp7J8cYY5s7hIIExl+Ejn8YeTxkAzjJf3aGPN4fNL9RzpmNeKQ75q3Ho7ORt/wT5CKG/h8hBr/pdmg6KBlaY1vRyj+poUIAUpTzTV7mAtAhMKvFo3YPSS/jciPr1Q5JsfTnMSEDMeQiasxO0ccpQT+qAbTUFqOzNuapiHAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9tbKm+XAkk7c7Xr58uHgFhyv3zKUYFidML4BRzRy70=; b=Q/AuoLI+06FTETpwwg/aHEH6ACIHw+ycuejGvv44lMFar86zw1fEtH9/r/jLInBcfvOSWQsikHWsjwcAvnImPf5nTLGmAi1fCiAQY0ZV8DN6aW8Z3JXCaEpt/k8UeN9+laIsUk7CYWNjuRhrcemn43R/rZsaDdG7mVpERQASvHdystvvnMh+dbxVcaswSGglqKc4AXF/O22aTAAtVC+9gWQu6Bz5amsdn0JwXa0FKwtGH64Ck5FLUrxEk7J/R6MOrKxKPPOsGsT+zCl2KoQITp6npdeFcUCSemhGk55lDjBuXID+vVnPgyshCDd40NdGUS6Ybv2ca2iIXByfduCp1Q== Received: from BN9PR03CA0312.namprd03.prod.outlook.com (2603:10b6:408:112::17) by CH2PR12MB4071.namprd12.prod.outlook.com (2603:10b6:610:7b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:34:58 +0000 Received: from BN8NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:408:112:cafe::76) by BN9PR03CA0312.outlook.office365.com (2603:10b6:408:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:34:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT107.mail.protection.outlook.com (10.13.176.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.22 via Frontend Transport; Sun, 9 Apr 2023 15:34:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:34:47 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:34:46 -0700 From: Xueming Li To: Hernan Vargas CC: Maxime Coquelin , dpdk stable Subject: patch 'app/bbdev: check statistics failure' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:56 +0800 Message-ID: <20230409152529.5308-109-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT107:EE_|CH2PR12MB4071:EE_ X-MS-Office365-Filtering-Correlation-Id: 80e4dd7a-07a0-452e-926f-08db390ff9d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J/UowQU/dDkwV95oHnqXyo1gDC8YmOyljji03nMovHgz7+Q85Wp4WqaT12nCqwDfIaAMAgvE58gnF+fqgcePDuMe0oZ+ddrQyZdBqs671dc/Tk/E9HOTve7iBgX4tJk5fHRWQMxyUNImmWxVCzI6cfWvDHrzeQ/4nZWn1hYX+bEHmd6EjRN4t8Xo6SwTgKHqeAXk6xNOjE77s/KRrUtu1GKR62dpWtwQ3OM95z+S/ot47S3ahxaXAzcQuCxRZCFaAIOZfBLj8h4vlljhH+o+lBLIBdcB+fC8hIwSee8GcAV2XfpRsksGl34RZ+qTKTTgPkEYIBlTWbX86/Bpbnr0RNT1EHrBK6ESXHGuV4Ucx6JfS7fRBhDjYuoO4gH4Yv67qxfI5aT3Kv8uc889u2SAzLJS1axHQU1/5VYQ5K4bVEcVPCgD5hJFaeU9/P3vBK9KKmt5UPQQw1g2kdZGfLwhQw8oKG9VPzMsxPHZJuOIzv87zWiKgsRjz1Qe3OVc5v183pT0UfzyoTl8tH+x2ttdHR4FeqMqt1Ql7HbKQQwi2cccdne4Y3gImxEq7OfNgxShM/b4hpEe8y7NxUsDCjvSmC8xepUCfvRAhwj85gQAk+ZfBb+JzWLariHwsY1aZYRMBXEqTCwUZVrX334B24xZoqx4nsfqGqzC4JUxCf27Rw9xkIuyXCz9shl8d+ie6HWwZY1BiB6B7fOd/DEoJiRuEbpxyeTyfBCMihEF6KkDTgh/Rzj5iQVvkfxXVxdFa2GM/tQBMiMmrcdXSw6GezfdMgN6J0vWebsK7oMbh5ZkzA8I6r8PTgUXmXQOdPhB7/9RoUas1d1rXf4iJ2vKrLqx8A== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(478600001)(7696005)(54906003)(316002)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(966005)(6666004)(2906002)(4326008)(70586007)(70206006)(8676002)(6916009)(41300700001)(8936002)(5660300002)(82310400005)(7636003)(356005)(82740400003)(86362001)(55016003)(40480700001)(36756003)(40460700003)(47076005)(83380400001)(2616005)(426003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:34:57.9489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 80e4dd7a-07a0-452e-926f-08db390ff9d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4071 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/b80c949b77809e9c7026af726a0a878c0a43c278 Thanks. Xueming Li --- >From b80c949b77809e9c7026af726a0a878c0a43c278 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Wed, 8 Mar 2023 19:36:24 -0800 Subject: [PATCH] app/bbdev: check statistics failure Cc: Xueming Li [ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] Add check for return value from get_bbdev_queue_stats. Coverity issue: 383155 Fixes: c25604355a15 ("app/bbdev: add explicit check for counters") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 0f441ace4d..f77ebc4b47 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -5382,7 +5382,7 @@ offload_cost_test(struct active_device *ad, printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n"); return TEST_SKIPPED; #else - int iter; + int iter, ret; uint16_t burst_sz = op_params->burst_sz; const uint16_t num_to_process = op_params->num_to_process; const enum rte_bbdev_op_type op_type = test_vector.op_type; @@ -5477,7 +5477,10 @@ offload_cost_test(struct active_device *ad, rte_get_tsc_hz()); struct rte_bbdev_stats stats = {0}; - get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + ret = get_bbdev_queue_stats(ad->dev_id, queue_id, &stats); + TEST_ASSERT_SUCCESS(ret, + "Failed to get stats for queue (%u) of device (%u)", + queue_id, ad->dev_id); if (op_type != RTE_BBDEV_OP_LDPC_DEC) { TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process, "Mismatch in enqueue count %10"PRIu64" %d", -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:41.548782800 +0800 +++ 0108-app-bbdev-check-statistics-failure.patch 2023-04-09 21:45:38.759042200 +0800 @@ -1 +1 @@ -From ce1b62899167f6e2c49d8496afa43a9162167c6b Mon Sep 17 00:00:00 2001 +From b80c949b77809e9c7026af726a0a878c0a43c278 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ce1b62899167f6e2c49d8496afa43a9162167c6b ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 15ebcdfc15..276bbf0a2e 100644 +index 0f441ace4d..f77ebc4b47 100644 @@ -22,4 +24,4 @@ -@@ -5679,7 +5679,7 @@ static int - offload_cost_test(struct active_device *ad, - struct test_op_params *op_params) - { +@@ -5382,7 +5382,7 @@ offload_cost_test(struct active_device *ad, + printf("Set RTE_BBDEV_OFFLOAD_COST to 'y' to turn the test on.\n"); + return TEST_SKIPPED; + #else @@ -31 +33 @@ -@@ -5774,7 +5774,10 @@ offload_cost_test(struct active_device *ad, +@@ -5477,7 +5477,10 @@ offload_cost_test(struct active_device *ad, @@ -40,3 +42,3 @@ - if (stats.enqueue_warn_count > 0) - printf("Warning reported on the queue : %10"PRIu64"\n", - stats.enqueue_warn_count); + if (op_type != RTE_BBDEV_OP_LDPC_DEC) { + TEST_ASSERT_SUCCESS(stats.enqueued_count != num_to_process, + "Mismatch in enqueue count %10"PRIu64" %d",