From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3F22428F8 for ; Sun, 9 Apr 2023 17:34:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BEB7342B8E; Sun, 9 Apr 2023 17:34:54 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55]) by mails.dpdk.org (Postfix) with ESMTP id B59124067E for ; Sun, 9 Apr 2023 17:34:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kvGdd556tpSAcMjIfYIdqvnea/ztlgZzR/6qkVneOkGyLoLQOJuByQokkDM4oKybXgpaTWEU9mxS6ECdJ9XlrgKgqe/GG9xJILbrZjTs0pVYwfKulxOONLdO/D+rFMt13yW3W0K7pYGau641rrHFExsx7ICgv7M8jtRA4T3SbPwYdtzI/C6JhiyyDeDaCZx1Up+Tqj9IljekOrFEyEkMEhf/RCC96PMVtbFrHQAw65lUZNQw27Y6Rq+Hgk/ylKIiSZt7CGBKT4XHgLrYwZYAmyfHSn11MoxT3AyD9HTtEpwj+1msZ59Oc0hPDnaVQnYurnxHoDSs92HIyIDHrkXv6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S0d4LNXc96xsl8Bz4xlIU+qW6hNRbSjilz7BOn0h6HU=; b=NtqICque20vWTJ8W/n0xquBEzb9XF+gdxtQ4XpTYsxrs03oJpVqCgTqqpjLz68MyZj0Wel2TjyeEQCgDv831R709lSv+pPBcofZIm2T2UpT5T/RoHugxrVsD6dLQkV2qBoh1RClS6p4WpPlpRfEPtMZ8n7IkprPFA634M1VBD7g665ehmM2QRW5/gEwdBQQj2N5wRfleWPAQXZinPm/l3YZuqtPXOnhPKKv1ILDibybwI8/PnzzBuJvgfTIc0e7+onKV/YsrU4CG1h0bXuGlrWgyL1e8IN70/lIE0TgkobHx84oj1jFHqn7eNYObjxMEDCc4Fwm/Rkbw8bqhez0I8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0d4LNXc96xsl8Bz4xlIU+qW6hNRbSjilz7BOn0h6HU=; b=cjJLlvvHS1y3AtOAQF9NYN3ANpxKVmKXy05pgZEWWS8Jmwnd2tKDJxBuiYShDsco33Zd020ddf+MhiLf72/jB3Dt5Lmrb6xFFskR18pGae2FyFUsYCm1rGapX28+iflQ/mYNu9bc11LTNN6ETh2QBnKiTzDQjj2jcxIgUaE4jWZxhItrDYEldrgeauejC1pIabPhMU4ip8JThBRA5OybqgLI7iC4KjMmb2mRfm8TMUphPVJ3ZU5JgvUxbuZ2ILzypXuOzG0EafsgCriRvuvRqM2M2mmxn90MxnJEhG+UKDIQQGFg3NR3BdZNdSYPK6eePJZ47WtAtrwN5+S+I5/keg== Received: from MW4PR04CA0232.namprd04.prod.outlook.com (2603:10b6:303:87::27) by SA1PR12MB8947.namprd12.prod.outlook.com (2603:10b6:806:386::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Sun, 9 Apr 2023 15:34:50 +0000 Received: from CO1NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::1c) by MW4PR04CA0232.outlook.office365.com (2603:10b6:303:87::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:34:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT025.mail.protection.outlook.com (10.13.175.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:34:50 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:34:49 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:34:47 -0700 From: Xueming Li To: David Marchand CC: Chenbo Xia , dpdk stable Subject: patch 'net/vhost: add missing newline in logs' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:57 +0800 Message-ID: <20230409152529.5308-110-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT025:EE_|SA1PR12MB8947:EE_ X-MS-Office365-Filtering-Correlation-Id: dbb3b095-9872-4c22-5609-08db390ff553 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: evMF9aiN/idE6nI5cMVAVu3d+lWy3pt6z+ElltoHxpQiTkJX1ixHbl5UZPv+CFovepXhNcF1bY5pqlYX2G6XAfzRtdZPSB757whiS9dUtRrgUhw05ywJeqgLu1XCewyfVo6OQCAkADXiLRK4OHig+Ky2Bx6gOgZrlktMlIX6exDDsRuZ11N0uEAyThvjab2W9uUwf0uQDqWFVOvt5gDV4cejGq4VFUd+nJI2906XdS4G0axEzkTD6SFyu7VqvHcMdORcePKpBPoCwI3bGs44fkpKY4y+APdpKnMZ5z6UsIKRbH0S3n/cJKEw12ReH4matbQxGN+JIOf+I9+kuwd8xCZvHZX1PDLTyw2H4PESU0vXXl8ugNViX4xk5X26l+aK0v2ZXLj3OvqLYME5n8eWB4o9EpaX3XK81F6uQyI7sDTVJAIH5mSCHJ0SDK1kwhfQLosuU0K4pQnvedDRo5SJvOr3Kv1Nga2Rn7p6XjHXoEVSzn4GUeEFQ0l0ueJOtWY3uhkYIkYR8W2Fyo4Ef88xrQxyfhEPSWVN5KUh07MbB2nZ7wV7xphuN9yMkQkPtbGF9HWQdK6HA++pGNnPeGi74WagfQRLe3WFIPZKGu8kXGhGEHsIpwqHbZjIjBcqo7134eU3xdvtbiSBFreC9YbB2Y5FKpZI+ictKPlQ8deOqEfr0Tv6AsaGSXc8WoGH2CREqftKg2zbXa4RJDDq4mGR2cdL4CMFTo6QztwtFZcQQxQnGT0NF8vC/fU36zQigDQDLB65EaKhI9cfWrRDbvUYCgPrqfRvTfVkXE/zDCSbldaKb2i6C9+0DH55VE6e7H/ezj/WtqA3max+M4s98Z017g== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(396003)(136003)(376002)(451199021)(40470700004)(36840700001)(46966006)(86362001)(36756003)(316002)(41300700001)(8676002)(70206006)(4326008)(966005)(6916009)(7696005)(70586007)(54906003)(478600001)(40480700001)(55016003)(82310400005)(5660300002)(8936002)(2906002)(36860700001)(82740400003)(356005)(7636003)(16526019)(6286002)(186003)(6666004)(53546011)(1076003)(26005)(336012)(2616005)(426003)(47076005)(83380400001)(40460700003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:34:50.5291 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dbb3b095-9872-4c22-5609-08db390ff553 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8947 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/9736b58d621dcc684a567d4372509b2d318bfe71 Thanks. Xueming Li --- >From 9736b58d621dcc684a567d4372509b2d318bfe71 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 9 Mar 2023 13:37:50 +0100 Subject: [PATCH] net/vhost: add missing newline in logs Cc: Xueming Li [ upstream commit d539a20b7561d9e97d13f9b43d74ec030bd1a4ba ] Fixes: 3f8ff12821e4 ("vhost: support interrupt mode") Fixes: 8f1750f42e2d ("net/vhost: perform SW checksum in Rx path") Fixes: 8ba1723783b2 ("net/vhost: perform SW checksum in Tx path") Signed-off-by: David Marchand Reviewed-by: Chenbo Xia --- drivers/net/vhost/rte_eth_vhost.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index b152279fac..e8b0ed4f0b 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -297,7 +297,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) if (internal->features & (1ULL << VIRTIO_NET_F_CSUM)) { if (!(rxmode->offloads & (RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM))) { - VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance."); + VHOST_LOG(NOTICE, "Rx csum will be done in SW, may impact performance.\n"); internal->rx_sw_csum = true; } } @@ -305,7 +305,7 @@ vhost_dev_csum_configure(struct rte_eth_dev *eth_dev) if (!(internal->features & (1ULL << VIRTIO_NET_F_GUEST_CSUM))) { if (txmode->offloads & (RTE_ETH_TX_OFFLOAD_UDP_CKSUM | RTE_ETH_TX_OFFLOAD_TCP_CKSUM)) { - VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance."); + VHOST_LOG(NOTICE, "Tx csum will be done in SW, may impact performance.\n"); internal->tx_sw_csum = true; } } @@ -646,7 +646,7 @@ eth_rxq_intr_disable(struct rte_eth_dev *dev, uint16_t qid) ret = rte_vhost_get_vhost_vring(vq->vid, (qid << 1) + 1, &vring); if (ret < 0) { - VHOST_LOG(ERR, "Failed to get rxq%d's vring", qid); + VHOST_LOG(ERR, "Failed to get rxq%d's vring\n", qid); return ret; } VHOST_LOG(INFO, "Disable interrupt for rxq%d\n", qid); @@ -851,7 +851,7 @@ new_device(int vid) if (dev_conf->intr_conf.rxq) { if (eth_vhost_install_intr(eth_dev) < 0) { VHOST_LOG(INFO, - "Failed to install interrupt handler."); + "Failed to install interrupt handler.\n"); return -1; } } @@ -1191,7 +1191,7 @@ eth_dev_start(struct rte_eth_dev *eth_dev) if (dev_conf->intr_conf.rxq) { if (eth_vhost_install_intr(eth_dev) < 0) { VHOST_LOG(INFO, - "Failed to install interrupt handler."); + "Failed to install interrupt handler.\n"); return -1; } } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:41.575998000 +0800 +++ 0109-net-vhost-add-missing-newline-in-logs.patch 2023-04-09 21:45:38.759042200 +0800 @@ -1 +1 @@ -From d539a20b7561d9e97d13f9b43d74ec030bd1a4ba Mon Sep 17 00:00:00 2001 +From 9736b58d621dcc684a567d4372509b2d318bfe71 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d539a20b7561d9e97d13f9b43d74ec030bd1a4ba ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index 9c609b45a3..198bf4d1f4 100644 +index b152279fac..e8b0ed4f0b 100644