From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB0E7428F8 for ; Sun, 9 Apr 2023 17:26:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACCD841156; Sun, 9 Apr 2023 17:26:45 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2052.outbound.protection.outlook.com [40.107.93.52]) by mails.dpdk.org (Postfix) with ESMTP id 64BAE40EDE for ; Sun, 9 Apr 2023 17:26:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRYhRRq6HAS5o1JhY/6fHprHxN3x6P2veLFf4sxAJY+SfsrRLyDhSNep8eQhGL6vOTo751PYfr5emSwv2GI6qzl54MgZ4snkNpbqedVmWF0S5tGqzzLFfww27F/Z8GQTSCCieItALSKSjZvhUbGK6IJmAYrAceTIiSh7eXMCgbt8kxehVPEwp+2ds6/ANM6mke43gk4vsVn7gBEmRpIG4/Fes3TCZu408v0arC3Z6LaxFtkHNaXTXEmqeJ4qh3KRHCG7BQSZ/m68I8Tst00StQSWwne5f+W8f/StmKXyXu6gehlWsDjWukpR9fJWASooUYGiLdXwdwglDjnRlG3kxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FyS747EzXV4Ca9zf8uAC0lsGjtuXMmlJlgsuQuoRv0k=; b=niT8e5W6SDc9uRED7hjgy8+OKqUl48mxdCYzEvaq/Q4VVIDyCld6FM8FpReLO2TVAhhuC7R6yZ/LvKuCCgXkCjWplcvfQcRlYL7fUsNYLF4zykViNCkYmPgGijKFBZpXVAqt+oFi8CCzWKgZ/rGNOgiQGlM8nukEf1urQWaxM8/Ai+DAb28NHlFDiTDAx7z/KUWj+grRfYUxB7i9ySC0FxdFZrZ/iRK/ujC/C5QFixIIMRvLjrLz/L+8vNRR4JnEGKaxw6ZoOKDwHEvHcjJAPvtwLZXpim6G1sGS1yaM8I/SNHeDaJslfvjCR23ctUkLFwrZh2VXebkZDVMCHOdmSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FyS747EzXV4Ca9zf8uAC0lsGjtuXMmlJlgsuQuoRv0k=; b=OQLiPZKTwYEYZrQVpssoe0aTGo9TD02oSHBF/T30yGIchnufV4L9UP894yIrz4YGBc/Mk+Mfa8V8PaFokSS0d1oR7wj28GMOUNtpUcqMJJX2vKe8/Sd7cEOALByhXChHBQyx8DO16C9/EscQbk7PG5hpu4NggeaNIhAyb25ITKZH8uKVgB2/I2gapDjyXsMXJkjshj0AS9SjB6zVag1vLhQFSMTrSPoYlStVLEEJSqPOV3yO7tAcntGsmcAjI7mW5Fxnuj8+h9G+xJ06hIT2/PR5VJm5SS4oFUbPxHBmRNqAGwR07tzHJnk8M6fAQXVSvOeBHYVOdnuDcQHLI0ODHg== Received: from MW4PR04CA0375.namprd04.prod.outlook.com (2603:10b6:303:81::20) by DS0PR12MB8573.namprd12.prod.outlook.com (2603:10b6:8:162::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Sun, 9 Apr 2023 15:26:42 +0000 Received: from CO1NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::6d) by MW4PR04CA0375.outlook.office365.com (2603:10b6:303:81::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:26:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT028.mail.protection.outlook.com (10.13.175.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:26:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:26:40 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:26:39 -0700 From: Xueming Li To: Hernan Vargas CC: Maxime Coquelin , dpdk stable Subject: patch 'baseband/acc: fix check after deref and dead code' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:23:20 +0800 Message-ID: <20230409152529.5308-13-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT028:EE_|DS0PR12MB8573:EE_ X-MS-Office365-Filtering-Correlation-Id: df02528a-8b7e-4775-cdfa-08db390ed20d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PfbhAgFJn8f8uAKNYXMFPE/mtkV6ktBiaVypSfj44jHZUcRUOn6O8p6wJEb7SuW4V418Vw/bHg+UYIhRJGqunSvr5/6SZMHo0WTY/0zGOtyuSK+kfmgmxNyYEf3xt2SsashZ2susppD7h81lfm4gPf5ss+aulWaanDzRn2Bqgh2pv3/orgFzrlHFjqhEhx0ojVdNUkWqa5dmOoK4XAt7VNiJHfxKvM6rXJ+mQ2Lh1ZzK+6e0BOVgOfBNREkvYUREyz3DM7LNA8WaNGd7jBxjKcg0iOJFhw2YK8iAyD6BCJWkCJqFWfWVpb2vibd8/pWIppibHHieQPN/s4FOTb9BENa/2QvBR2JEcCoD3v5fW6oghlYxRpOBmXLL8xhjpXxvU5twDYCBd8hpQ2i3lB3hxxzgPXx4lozdjEGO6LSOqBK83R6LeBP68T8YCDnKGEm8gy/ugKh9q6yy4pFDF3RpqSxGu38/pjCs6HX0om1Oe+24wv0R/Eck07Yx1o+EFHMRLfjmx1Nkqz5zth2q0HDocP0m0vSo5wE6SmnPDSBv7MYVR4J/SC/PSkkZbbCI5zKg/VXPo3bGx3l0NrJIoyR6NhM5E7Mlh2Y+Gfya85L1t+aZDptYGEo95nroXGARYIqzS2GgVbfCPl79Z+naXMyGa7undUVQrxI0rHItUx1LbfPgX4lX5ebPmxyq+WaosRYKxWZcSnkQ0OKCkTbn5CMsvHJHzBa9+1UwtHxVdOb5N1PWGpFx29x6du12URhrDkXwMZVK9iTWLipugNMvMsHmmouF8ocwcVDX8OkJJia/5GSxN/kEAu60ljmXocbpTXiG7xYhVXX6xVoA34B2b0OR2w== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(478600001)(7696005)(54906003)(316002)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(6666004)(966005)(2906002)(4326008)(70586007)(70206006)(5660300002)(8676002)(6916009)(41300700001)(8936002)(82310400005)(7636003)(356005)(82740400003)(55016003)(86362001)(40480700001)(36756003)(40460700003)(47076005)(83380400001)(2616005)(426003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:26:41.8565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df02528a-8b7e-4775-cdfa-08db390ed20d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8573 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/4bdaf5003136cbd9105fc53062924f2a2d72ab81 Thanks. Xueming Li --- >From 4bdaf5003136cbd9105fc53062924f2a2d72ab81 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Wed, 22 Feb 2023 08:40:41 -0800 Subject: [PATCH] baseband/acc: fix check after deref and dead code Cc: Xueming Li [ upstream commit 01eac6204617cdc60b67934a627dbf0b9b2d5e0f ] Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a98 ("baseband/acc100: add ring companion address") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 1ca95f4440..7757db81fe 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -4124,8 +4124,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, struct rte_bbdev_enc_op *op; union acc_dma_desc *desc; - if (q == NULL) - return 0; #ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely(ops == 0)) return 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:39.149745400 +0800 +++ 0012-baseband-acc-fix-check-after-deref-and-dead-code.patch 2023-04-09 21:45:38.589042200 +0800 @@ -1 +1 @@ -From 01eac6204617cdc60b67934a627dbf0b9b2d5e0f Mon Sep 17 00:00:00 2001 +From 4bdaf5003136cbd9105fc53062924f2a2d72ab81 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 01eac6204617cdc60b67934a627dbf0b9b2d5e0f ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 40b5eaf089..e485381a3f 100644 +index 1ca95f4440..7757db81fe 100644 @@ -23,2 +25 @@ -@@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, - int ret, cbm; +@@ -4124,8 +4124,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, @@ -25,0 +27 @@ + union acc_dma_desc *desc;