From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89BCC428F8 for ; Sun, 9 Apr 2023 17:37:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8374540A80; Sun, 9 Apr 2023 17:37:07 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2064.outbound.protection.outlook.com [40.107.102.64]) by mails.dpdk.org (Postfix) with ESMTP id 32F9841149 for ; Sun, 9 Apr 2023 17:37:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJA1Ws/EYcld/LQkbo13qbv9Rkunaw9XxbBYD9Uz1T97V9qfVW20UPWfL9z+93UcwtT2WXA3oFUwri2bP3VO//9Hm5u6Wrq+XBKS6vdWYOFKTKS1mjvu8UuYqP7zJ6kE20Vct5w24uJBEe2GdtuLC8lADpdUFec8pwY/MVC5di3ZXdLPdAjdT4n/Q54E4M+LxxOYTXji5rHb2AiCiSIsFSR5BHWiL9RPzVjrLrBbkOPRk7JEU/4aIewSHXqHFsJ0NosBz+EgJjWGeLmHNXJm+cJQURBpc0F85p2cufDHycr4GMEaV4UyyUHMV05BCCcKwrkCKSJbFi68cTuyWPEJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B8qsFAkqRptFDsa44v6Jgv3cBpd45RiNkbjzOozoBjA=; b=WYyaocYDhv77/CAT7lBpC+BGd48QfYcNpQN9HEco97HSBbNNAybVZSYhen/1LHb8TpfeFYQT1Z54KBb3ra0VTuTgj5YGLFsU7/zec7kixHERrLz0GFd8PD1ak1UOygOa1+2si6G4yQx9YeiV5pg8SGVbKAkDAFCVj3BIQYGPzJm00kHKfRGm9lMqUm0wl4JKEEMGmBQh02p5xXrBczCfj/lSKj2PTvWGPeKS/05JH+LnkGIUsLXYrgVm1+BgVflriDjqXYbG38cCOO7Fep0bNoVFXzl2APsh0lp52mLAjshj3lELEnW/ofFQSyuYLnE0/NYo6aFI1M4ID3Qa/FrmyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B8qsFAkqRptFDsa44v6Jgv3cBpd45RiNkbjzOozoBjA=; b=NiZdeYEpBmrB8JjHlqqHkbqldwhkcCGe/k/UD5jz1adXWV4P0TFnj3VatOsUFRT2d8mrvEkeeVwJc3eNEbmA931U0CjImbDlOs2vPmzFQfLFh46mVO8Dzfap6jzuTEGYMQX0UmCkbQmbZAHGB9zQE/Z32I6xecEKkkQyDHNPxhXK1BGM8pw3rZtEeDe4zTRQS/Zl3WM/HuOqPR+rR153e4U858xd+wZ4OKqDUURaM/7nOidqyTM0xF93tJHPqw3/IVLS2MBSBPcbofwRZnMP2jZrQdhORAyq5YtJ9qhbh+9s20QGTC+w8FpwoB3LuAAmfeQ9sDgHNSysrsC2SAIQng== Received: from MW4P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::27) by CY8PR12MB8241.namprd12.prod.outlook.com (2603:10b6:930:76::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Sun, 9 Apr 2023 15:37:03 +0000 Received: from CO1NAM11FT096.eop-nam11.prod.protection.outlook.com (2603:10b6:303:115:cafe::4f) by MW4P220CA0022.outlook.office365.com (2603:10b6:303:115::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36 via Frontend Transport; Sun, 9 Apr 2023 15:37:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT096.mail.protection.outlook.com (10.13.175.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:37:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:36:56 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:36:54 -0700 From: Xueming Li To: Alex Vesker CC: Erez Shitrit , Matan Azrad , "dpdk stable" Subject: patch 'net/mlx5/hws: fix error code of send queue action' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:25:19 +0800 Message-ID: <20230409152529.5308-132-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT096:EE_|CY8PR12MB8241:EE_ X-MS-Office365-Filtering-Correlation-Id: 865ccb83-eb2f-4ef6-4a7c-08db3910447d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xc6tzxSUzyaBMZ7v+BBD3ouWgnuTqVJ97gzNvVBsPK9ZPTXqXeXLuNd/7twpkDOChIM/aOafywZWFqGq0BNjvRf7hbihGcEjW5pqvnIrZ90gyVBsH4d5tjW6yvN+Qw8ck02Lt08O+hRBgw66RyHsHuxg9r+0VhCUgXGwQuhYi0Ao+Q46VL5RGsvuCMEScAtxYTfEox2JLpH8RTEufm9S+W0sJM2ewn0QIIggA9FrBn8wwhCIh+KH1HeyErQh7M8bxNnTh89qJeiBHK0IN8KB+ZQDq/eLqM8AChUVVKULc32qus5mI3q4aU/zXj7jRKfZ0U6MRt4ZHq9rRf6uVWK4VH+pWA/gTD5Ho/KVj0PZY4AIe414TpFMpRpc845e64iTZ91Sjex/biT1SNklgo7SmcOHqNv+On6ruVOTIwZpCusQIikuxrGF3q7fi9JgKDlTpp9y/iBntsLCmybzSmxwY3riWB7lcFlVTzL3+ubJ77NWAaO39qJtf4ZZABPcVVG2KaQyetvhqbA2JZuuam+iTjkPuXsq072pjPxkIYt630w1Y4dnBUVQPeXX6iXBnDHJuW8rk6k7HhX+sFGUWOWPmsm7Ag/P7PowjewdTm3+35UaceJdTt6sWHpqI0geiodRSXzZtt0p1HD+w2Do56GpTLbQv79vsYm5eOoxYIA7dBvY+1LlpA24vH5kS6ujM7stul33dI/AUQxYwvxK4Qo0b/+YKr5q6rmkAmogDmN9JQSBw+hj53mc2k2kv25N0fSYhp1ry5Iw8qF+OKBSe+sZu8W8MPOWDdxiHlLd1pN5HzEPfgEe8gHcEzZBGxvzAexVxp3y3CK7HE5NYXOouRyJmA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(396003)(136003)(39860400002)(451199021)(36840700001)(46966006)(40470700004)(55016003)(8936002)(6666004)(6862004)(7696005)(40480700001)(40460700003)(966005)(5660300002)(86362001)(70586007)(70206006)(8676002)(4326008)(478600001)(37006003)(316002)(82310400005)(36860700001)(82740400003)(7636003)(356005)(6636002)(54906003)(2906002)(53546011)(1076003)(26005)(2616005)(83380400001)(47076005)(426003)(336012)(41300700001)(36756003)(186003)(16526019)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:37:03.3285 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 865ccb83-eb2f-4ef6-4a7c-08db3910447d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT096.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8241 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/1f4de71406e27229e0e941a196605490e2de4aed Thanks. Xueming Li --- >From 1f4de71406e27229e0e941a196605490e2de4aed Mon Sep 17 00:00:00 2001 From: Alex Vesker Date: Thu, 23 Mar 2023 14:34:14 +0200 Subject: [PATCH] net/mlx5/hws: fix error code of send queue action Cc: Xueming Li [ upstream commit 8ae49a5edb5b1a64716b00bd644c57278d1801fe ] The rte_errno should be set to a positive error value while the ret of the function should return a negative value this aligns code to other mlx5dr API functions. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 5c8bbe6fc6..a8aba31cbe 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -842,8 +842,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx, /* Signal on the last posted WQE */ mlx5dr_send_engine_flush_queue(queue); } else { - rte_errno = -EINVAL; - return rte_errno; + rte_errno = EINVAL; + return -rte_errno; } return 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:42.115619200 +0800 +++ 0131-net-mlx5-hws-fix-error-code-of-send-queue-action.patch 2023-04-09 21:45:38.809042200 +0800 @@ -1 +1 @@ -From 8ae49a5edb5b1a64716b00bd644c57278d1801fe Mon Sep 17 00:00:00 2001 +From 1f4de71406e27229e0e941a196605490e2de4aed Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8ae49a5edb5b1a64716b00bd644c57278d1801fe ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 51aaf5c8e2..d650c55124 100644 +index 5c8bbe6fc6..a8aba31cbe 100644 @@ -24,4 +26,4 @@ -@@ -1007,8 +1007,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx, - - break; - default: +@@ -842,8 +842,8 @@ int mlx5dr_send_queue_action(struct mlx5dr_context *ctx, + /* Signal on the last posted WQE */ + mlx5dr_send_engine_flush_queue(queue); + } else {