From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01583428F8 for ; Sun, 9 Apr 2023 17:37:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC134410EE; Sun, 9 Apr 2023 17:37:41 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2064.outbound.protection.outlook.com [40.107.93.64]) by mails.dpdk.org (Postfix) with ESMTP id 382CC410EE for ; Sun, 9 Apr 2023 17:37:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HGInT49XXlKLcgaskGIpKi8ShjN73xXQW/CbzNhUGOHwbXP2xgDjnevQMVZ8ezGKWSm/TR651GYyetcjUPk51RtVNkptbj20bHLtFqZ1r1f73Eigd73pE8NfQXJ4xMc9YUF3sMyNSJ5T+5RZ+9KjIIQ9aiWMPDJGtrH+FBo1MB231GmjO/NH4Vms4OP4g2+Y/HkqYwX34raQKsxio3NKG2S5vuBsotrlhZ8jXlkuurRfMGJ5YIFNRDPbKsD0ZNZQdFHdrszhfyXHArDR7TJycDj3GQqQGtfF1mesEVWgXq3tH9lHfjGUgcklccjqFUtwiJiIA1Nf5TjGOuURTJdJXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iTHAh0Ow/EmrkdxtTXFy0Rku5rM5CW8z9ZV9imdSc4Q=; b=gRglWe/DO2o/FOWwHTbjefESkG4Zt7RiRff8I4lDSXNP32OXsYCcgpbF+BDl7NGaS/AWKNtOto9lPPhVZll8P1RB4SZIzuZgOk1GVoaSeSuhoRV281JCi9dgfJ5VStEX5/AzgRua3a4XWxaf+gBFmzHkqUCJgJ4y2fsUQsPxa6ljgwQ8+3wQdpse/mYRY79d8lNehGFHjrgYzjEANdeA2KCxnzpQ7fkS8fvEQLA7CJDgPJKCcWegYflh/4mqe1y0qBE5E9U2q+nqys9M1XHB/jIRSgNToM6CDCmtQGrsreuuCYqfU8M2CheJD358vDZyOzzCqRLsJM531ZNqt+5QPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iTHAh0Ow/EmrkdxtTXFy0Rku5rM5CW8z9ZV9imdSc4Q=; b=XO0o4hOZeyLKEr7FC51aiHNywKMLFnZ7wPArbEmq79w5DnEke1hX/bv4ssxfnnNX3Q2l3tPMqd4cMcKyWhJDGxN9R1kV3at+suvCzlYWeIBXNrH7Lf6fQAoiiOIc0r/rGc3Y2FiD+ehDh+LSY/zUF2BkOljaXsw+aeg0GLdCBai6jjOxEm5PipixdVEVzG53Whqogn/mFDX0cepUOSVunLVsOQ+d0+upmGWJZDrNz3itrMxQb2DspFaHFC2kxmLtj9dGWT09LV+PGIUq+81Ueg9O5exIwK6xLEr6bAcqR5vKoDZNQ5JUbeBU71vSmzuT+BtJTU4YwbP/umrysgW+3g== Received: from DS7PR05CA0037.namprd05.prod.outlook.com (2603:10b6:8:2f::24) by MW3PR12MB4540.namprd12.prod.outlook.com (2603:10b6:303:52::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Sun, 9 Apr 2023 15:37:38 +0000 Received: from DM6NAM11FT069.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2f:cafe::e1) by DS7PR05CA0037.outlook.office365.com (2603:10b6:8:2f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:37:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT069.mail.protection.outlook.com (10.13.173.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:37:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:37:22 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:37:20 -0700 From: Xueming Li To: Joyce Kong CC: Ruifeng Wang , Reshma Pattan , Tyler Retzlaff , dpdk stable Subject: patch 'pdump: fix build with GCC 12' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:25:24 +0800 Message-ID: <20230409152529.5308-137-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT069:EE_|MW3PR12MB4540:EE_ X-MS-Office365-Filtering-Correlation-Id: 918141c2-5e94-4ff0-03fe-08db39105953 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PBqEKB0BLSsdidzhOIH+CHOhsTNcxudDdtEnOGPuLNdtyNN25BPsFyxOEhfWl0ax1aQd+B+wdSp7OPckg6q7Rt3Ei9wAjbrz/i1xA+0SUBHfBErgr1ktr/u12aJo6xtcoKgAFa5fNj6g+VfTgC5WcCvIRP1gZdalmt1sG766UL7YgXTKoNE/IrSeW91pudL0fKx6NUXVmF0TY/zoyq4I6f+wdbQff+i7uQn969QXeyK8wjlx7pscR7gMALEB6biRtPMFDWKAbvKlX12w+ppoMUWwmn5ibviB5/W56MZmX/vQzUq8zP8lb9pztv4NtsQU4JvPnHTDRDVbiEJoNVLo3NT+E9AZnEmzRqp2YZAcpyYEdBSCowvoiD6GO3VMart002kEgb3DREOiNhR6uz9o8YLyAipgZqEgL8EB1+lneOkDexDc8LB18GL/oLZddcjej3st49OCxzFV2xClD0Gaxe6FgSzIPP3JT/EYJasaPIov2cEaQxuxM3st03fR6ytBn3UgFYnZp50pH6m6nb+w67EdMQTePdnbR8vj3YRloTpJZ1Cj7uWlMk+FQme2KnLyT8VZgMm8LgjXtkVi1OWHXhXuDRyyiPeygkTA8sbg0Nyt5TIPwFr/7o+cGb4yjPtkSLBpEAzBLxWHs2uzx0dd1cZaobAxavSpoV4Ud1obDgxNNYWwJwJZ8I++QcfNgp0ikFk4r4apTMQCFJmN4ARW0q78LrmIA+kf5kIKbdMbWKMeBs7fEyWUd1fYRDgdAzr6A0uzffjndS873cB2IaRl30VvnX/240a8Sl8xDM36clMlbyKMqlO2ZpjofZaQRaLbja5Uh6jdvwVPlpJslZrATw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199021)(46966006)(36840700001)(40470700004)(86362001)(36756003)(316002)(41300700001)(70586007)(8676002)(4326008)(6916009)(966005)(7696005)(70206006)(54906003)(478600001)(40480700001)(55016003)(82310400005)(5660300002)(2906002)(8936002)(36860700001)(82740400003)(356005)(7636003)(16526019)(6286002)(186003)(53546011)(1076003)(26005)(336012)(2616005)(426003)(47076005)(83380400001)(40460700003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:37:38.2679 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 918141c2-5e94-4ff0-03fe-08db39105953 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT069.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4540 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/ac849cac65a35923ffdb10e04a30ca3a67e6d5da Thanks. Xueming Li --- >From ac849cac65a35923ffdb10e04a30ca3a67e6d5da Mon Sep 17 00:00:00 2001 From: Joyce Kong Date: Mon, 27 Mar 2023 07:07:12 +0000 Subject: [PATCH] pdump: fix build with GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit b182466683a5c76657efb4b6b8d43e7d71979034 ] The following warning is observed with GCC12 compilation with release 20.11: In function ‘__rte_ring_enqueue_elems_64’, inlined from ‘__rte_ring_enqueue_elems’ at ../lib/librte_ring/rte_ring_elem.h:225:3, inlined from ‘__rte_ring_do_enqueue_elem’ at ../lib/librte_ring/rte_ring_elem.h:424:2, inlined from ‘rte_ring_mp_enqueue_burst_elem’ at ../lib/librte_ring/rte_ring_elem.h:884:9, inlined from ‘rte_ring_enqueue_burst_elem’ at ../lib/librte_ring/rte_ring_elem.h:946:10, inlined from ‘rte_ring_enqueue_burst’ at ../lib/librte_ring/rte_ring.h:721:9, inlined from ‘pdump_copy’ at ../lib/librte_pdump/rte_pdump.c:94:13: ../lib/librte_ring/rte_ring_elem.h:162:40: warning: ‘*dup_bufs.36_42 + _89’ may be used uninitialized [-Wmaybe-uninitialized] 162 | ring[idx] = obj[i]; | ~~~^~~ ../lib/librte_ring/rte_ring_elem.h:163:44: warning: ‘*dup_bufs.36_42 + _98’ may be used uninitialized [-Wmaybe-uninitialized] 163 | ring[idx + 1] = obj[i + 1]; | ~~~^~~~~~~ ../lib/librte_ring/rte_ring_elem.h:164:44: warning: ‘*dup_bufs.36_42 + _107’ may be used uninitialized [-Wmaybe-uninitialized] 164 | ring[idx + 2] = obj[i + 2]; | ~~~^~~~~~~ ../lib/librte_ring/rte_ring_elem.h:165:44: warning: ‘*dup_bufs.36_42 + _116’ may be used uninitialized [-Wmaybe-uninitialized] 165 | ring[idx + 3] = obj[i + 3]; | ~~~^~~~~~~ ../lib/librte_ring/rte_ring_elem.h:169:42: warning: ‘*dup_bufs.36_42 + _129’ may be used uninitialized [-Wmaybe-uninitialized] 169 | ring[idx++] = obj[i++]; /* fallthrough */ | ~~~^~~~~ ../lib/librte_ring/rte_ring_elem.h:171:42: warning: ‘*dup_bufs.36_42 + _139’ may be used uninitialized [-Wmaybe-uninitialized] 171 | ring[idx++] = obj[i++]; /* fallthrough */ | ~~~^~~~~ ../lib/librte_ring/rte_ring_elem.h:173:42: warning: ‘*dup_bufs.36_42 + _149’ may be used uninitialized [-Wmaybe-uninitialized] 173 | ring[idx++] = obj[i++]; Actually, this is an alias warning as -O3 enables strict alias. This patch fixes it by replacing 'dup_bufs' with '&dup_bufs[0]' as the compiler represents them differently. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Reshma Pattan Acked-by: Tyler Retzlaff --- lib/pdump/rte_pdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index a81544cb57..4b7a4b3483 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -134,7 +134,7 @@ pdump_copy(uint16_t port_id, uint16_t queue, __atomic_fetch_add(&stats->accepted, d_pkts, __ATOMIC_RELAXED); - ring_enq = rte_ring_enqueue_burst(ring, (void *)dup_bufs, d_pkts, NULL); + ring_enq = rte_ring_enqueue_burst(ring, (void *)&dup_bufs[0], d_pkts, NULL); if (unlikely(ring_enq < d_pkts)) { unsigned int drops = d_pkts - ring_enq; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:42.258824700 +0800 +++ 0136-pdump-fix-build-with-GCC-12.patch 2023-04-09 21:45:38.819042200 +0800 @@ -1 +1 @@ -From b182466683a5c76657efb4b6b8d43e7d71979034 Mon Sep 17 00:00:00 2001 +From ac849cac65a35923ffdb10e04a30ca3a67e6d5da Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit b182466683a5c76657efb4b6b8d43e7d71979034 ] @@ -58 +60,0 @@ -Cc: stable@dpdk.org @@ -69 +71 @@ -index 9bc4bab4f2..53cca1034d 100644 +index a81544cb57..4b7a4b3483 100644