From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE96D428F8 for ; Sun, 9 Apr 2023 17:28:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8F9C410EF; Sun, 9 Apr 2023 17:28:37 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2072.outbound.protection.outlook.com [40.107.237.72]) by mails.dpdk.org (Postfix) with ESMTP id 0945740A80 for ; Sun, 9 Apr 2023 17:28:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lze8HLMgeWimtCEpxysC9pHt9IYeT0oZo8Ve8UikG4KzTFjwKYt1vt2wurGPdetcfExsGo/zAisicZUqc1t8SWAPIPUJNtZn0ZI4w9yDylwjdvqq1GkYq/GMlmAWpBMz7Au6+NMkTfoYwhTQOomXpqwFrvwMqcUJsV3QKpPt5/dTR7r56jQ40Yo9lPzk7AQ902jqpQSUDOaSVK4giuHPwaM3mA/POXdsrTiHIV4pw7rxQb6y2cwQM5wfAH2MF5gCI47/04bHNuNV0hov+CaHOWErw2SDNXr9tdrHZgVwAAn/Mgd9GUeTOJfd9EpthAdh18L3rkT8igcRFT4TIKoIJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cLqjXtyl30g5C+OeECLTGGvVbL2jXB0CpzUsUwWIRqk=; b=Fj53VkN7KM0u92+ZZ4YEzX6V5aBgFOSIzXp6eXKOjvG+Fza6meGqCDAJ1yQaGzL71mAAwTQ/cXa3WY/HNmcv5VEVUc6icyV/QKlCQs/35Jmrh+Ywv3bqjRA1lLTvd9HxdP/itGURh1KK5Hb27BAt2pPIGIRqn9f6Z19bAv/XhvYnCgit0DRh+MswHeNwwwstuthF2zDb6ccSWagPL5iC9+9ecKOb7rpwXpXNWFM/tGP0p9xWiHCitCLQbAbstTWmDL5qHcWVKZIARm7xP8SODeAFhtdTMucZSePmx1c60GKHvzwsQ6yGUTz3rjwB1EGuOnyEtAUcenhJyJ+vZsdbJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cLqjXtyl30g5C+OeECLTGGvVbL2jXB0CpzUsUwWIRqk=; b=VflvLr0JG6yggVjk/GC9JGWQM2+ZdZN9VXXbihzf8k1LzhRidO/VCk2xheG+PPUIcRhtqLZpPU1M0+OseR+ivYks9aL7NDlGZaxCJjDGB//CwUDy/0lsIVf9p/tG11sD76wanrtwizJ04sge22MkDQXC3goF7gnETqWRR7dbEnQ+XGasbGMQmLIog2ilfl09sMqRnZ7m7AvG3ma7PaYewgh+R7Cb6kNRoDBMufSloQDkSVWWM3Wsy1qdeY3jJX15zGtM9iUzWTk+QjKsdP6hMUYl0lMgCGvjVVS02U3RPxgpKiWgAtdqMDkh1PYKk9J9l10ov0RJsWBH1/UwWSUdJw== Received: from BN0PR03CA0043.namprd03.prod.outlook.com (2603:10b6:408:e7::18) by DM4PR12MB5374.namprd12.prod.outlook.com (2603:10b6:5:39a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:28:34 +0000 Received: from BN8NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::2d) by BN0PR03CA0043.outlook.office365.com (2603:10b6:408:e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Sun, 9 Apr 2023 15:28:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT110.mail.protection.outlook.com (10.13.176.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.23 via Frontend Transport; Sun, 9 Apr 2023 15:28:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:28:25 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:28:24 -0700 From: Xueming Li To: David Marchand CC: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix packet transmission in noisy VNF engine' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:23:42 +0800 Message-ID: <20230409152529.5308-35-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT110:EE_|DM4PR12MB5374:EE_ X-MS-Office365-Filtering-Correlation-Id: d33bd78b-f403-4877-4a32-08db390f14d7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: agmRuOA/VfpKgs2DwzO5PtvhbHFla/zMJ5dHDWhC4TE3wWzoaF7bTcidGdNzV+EiiHipRprMfukzDTiEMLymUQnXzwOaDjTb8CZ1fB6VguyVnz4sxJB8CVXSahAZujNYDXUqeMYU5xbWA0HqkY8wHIuCKmfezNkDd4GBe0Ycy3dJaKxl6bpsl1YKPOBDzWhRJSS5CIXwwyOIDFCzF/r4gI2IZ3jag8mEX4MI4x/sYzTgdC1Fl7GX1zKem/y9H2Q9QeE7ixOtrrUCJmAbMdcwDoPHBlttUqKt2jMqTG4+pQ6USSQYNYB6RaGJj8Oq4xUGoQq4W39RdNo7gpzZxadPtMJlP/QpblNmGMcHUxead/o20f6TexSYxn2/4NaWEJissqu6HdP2vVnUVTHsI3P9MP1zybXUZ/+ANvAHhSQCcD8DiNa4XaG7piLu2bcFgvCUDRmDq0PQ+td5IfgOsQEz97px0GEWuVNkN6O3ZosjwwK0mfouvNZt9cNelaH7NJ2Aw0nqsJqWbkB8VVHdk3Jh/arVlxLCdAPc+zxeXlM/HxdxVLtUbxu35a4QC+ngjNhprBz60SMtI9tv6bAUaP8C7PnnHgMHqMJnwUE3NLK4S0RBxPI8ammveQnsRENp3Vsx4RnBXbnRz2bms0rYrOk8FVtlv9tcKo+X6NMIAQQU9ntPk3LR8Kkfy70lBhH/kkdFjxv3C8fBEO4UmvqLFM+/rQkzVubz+k08feYIf2itxwyr66TmwNqDhtQs0Lfg8o/w4UioEI6wUHbx3uyhcqfTXDYNAilwmkDsnKe7r64Xtg1vjAQekI/zxtwr3S6yPHJO1ggjZef+e320DoHLIKNIcA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(478600001)(7696005)(54906003)(316002)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(6666004)(966005)(2906002)(4326008)(70586007)(70206006)(5660300002)(8676002)(6916009)(41300700001)(8936002)(82310400005)(7636003)(356005)(82740400003)(55016003)(86362001)(40480700001)(36756003)(40460700003)(47076005)(83380400001)(2616005)(426003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:28:33.7972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d33bd78b-f403-4877-4a32-08db390f14d7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5374 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/cd2635a2b54fdc4e12731ffdc44cbd1ada81ed6b Thanks. Xueming Li --- >From cd2635a2b54fdc4e12731ffdc44cbd1ada81ed6b Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 20 Feb 2023 19:34:57 +0100 Subject: [PATCH] app/testpmd: fix packet transmission in noisy VNF engine Cc: Xueming Li [ upstream commit c2acd2db16cba89f403a980da5f4b6764085b01d ] nb_rx relates to the number of packets received from the driver. nb_tx is the total number of packets transmitted by this forward engine. Fix the retry stage, for dequeued packets, as it was incorrectly passing nb_rx / nb_tx as bounds of the tmp_pkts[] array, and fix tx stats accordingly. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- app/test-pmd/noisy_vnf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/noisy_vnf.c b/app/test-pmd/noisy_vnf.c index c65ec6f06a..abd99a0407 100644 --- a/app/test-pmd/noisy_vnf.c +++ b/app/test-pmd/noisy_vnf.c @@ -214,9 +214,10 @@ flush: sent = rte_eth_tx_burst(fs->tx_port, fs->tx_queue, tmp_pkts, nb_deqd); if (unlikely(sent < nb_deqd) && fs->retry_enabled) - nb_tx += do_retry(nb_rx, nb_tx, tmp_pkts, fs); - inc_tx_burst_stats(fs, nb_tx); + sent += do_retry(nb_deqd, sent, tmp_pkts, fs); + inc_tx_burst_stats(fs, sent); fs->fwd_dropped += drop_pkts(tmp_pkts, nb_deqd, sent); + nb_tx += sent; ncf->prev_time = rte_get_timer_cycles(); } } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:39.677201100 +0800 +++ 0034-app-testpmd-fix-packet-transmission-in-noisy-VNF-eng.patch 2023-04-09 21:45:38.619042200 +0800 @@ -1 +1 @@ -From c2acd2db16cba89f403a980da5f4b6764085b01d Mon Sep 17 00:00:00 2001 +From cd2635a2b54fdc4e12731ffdc44cbd1ada81ed6b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c2acd2db16cba89f403a980da5f4b6764085b01d ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index ce5a3e5e69..0e72dc034f 100644 +index c65ec6f06a..abd99a0407 100644 @@ -26 +28 @@ -@@ -217,9 +217,10 @@ flush: +@@ -214,9 +214,10 @@ flush: @@ -38 +40 @@ - end: + }