From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87A56428F8 for ; Sun, 9 Apr 2023 17:28:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 827CD4067E; Sun, 9 Apr 2023 17:28:54 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2077.outbound.protection.outlook.com [40.107.92.77]) by mails.dpdk.org (Postfix) with ESMTP id 3F09E4067E for ; Sun, 9 Apr 2023 17:28:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0DOBfZPBuKkWstNBQCPOSjmcCGjm8qo8gnWY8vaI2W01q7WVC+IiSudc2Wy7CacU2aJG6Ndg/zlKp3neFBDCdVV8AeBgESx0lShPUN/SxAi3qpQ11uEMxdGQ1gClhvjFokghLN+GZH9avpPOAVgF+JmkHK6DfZA1wHDGTTubqoIkdohNtsNs4j/+YfaHNb+4GuXYxod+AUBNbyz1IRoubjSHkS8cp6pPfLI8qxUw3k2svcwIk8d3vceqtzDprxPJpj39aP2P0WB4bmNVj54BR4sj3Ex31LxKcbPXQTDFxDtfjYL/eIg6y3/JszJqk6ipBCNeBlivQB489DMcQBEqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vx47fSQuLO9iB5zxzKtueCh7rfxhDAuD2WpzICxEI6M=; b=IU2vVNILY3hMGwOa7Hp/H5yoWXsfvPpryycb01btUr7bS8nOQ4MXq7dBnZZaOpv+4rnC6/LfKn6u3VAoeSoQiMRfqVC6spSVT2oCbrt3YUPijT0HpZV/d5jHa0x1uBQqkkGPmA2Bad4+axxQf/p3yL5zwAznEAg/0kKFIE+vEYrq8SEYw0V+vatANGn8L0w7Gpee2blVr9zMilnXVUgdnBYMzxqwTKqV4r/coaw5QP9tHkDITXnvlZy5sJzNq4YUDvgL7AK/4s6epZIAEzVZA3Fc8fWfxmIywzDcdRo847sHVdf0EJFYRqhZmtiRktV7OvDSDsTX8GsFENmoUkxw0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx47fSQuLO9iB5zxzKtueCh7rfxhDAuD2WpzICxEI6M=; b=p1YZ6mtMmlg3mDcvineb0S0z0cWYjJrvmfSBwSkW2pT9QS2dRTol24C1NiBjuj7O4VG1JmePx+czgUpLfiOoHUNLGULWJbCs0WSrUb5FU9ibhv4r8GDKRlfEBKUsND2IF5JHc0H9XVqHyV0kQSaDh/G8fwHtqSJqAGSEcAG8L+trKbB8UL4F/ItlQ29QfoKVUrnyUxOu30whg5pbawgANGwpyfyEJRKY7c0OJvcSfjuUV4Lqlj7PzrhKtpAN9j2IXSHUupI73gF6WjqsXFV+/AjumIgCWwJDIWjwXDt6uocMzNGXej7gFxSNZoKwWttoAuBmqUsznvXm0LBZmKzZaA== Received: from BN8PR12CA0006.namprd12.prod.outlook.com (2603:10b6:408:60::19) by CO6PR12MB5393.namprd12.prod.outlook.com (2603:10b6:5:356::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:28:51 +0000 Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com (2603:10b6:408:60:cafe::7) by BN8PR12CA0006.outlook.office365.com (2603:10b6:408:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35 via Frontend Transport; Sun, 9 Apr 2023 15:28:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:28:50 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:28:50 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:28:48 -0700 From: Xueming Li To: Ferruh Yigit CC: Thomas Monjalon , Andrew Rybchenko , dpdk stable Subject: patch 'ethdev: remove telemetry Rx mbuf alloc failed field' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:23:46 +0800 Message-ID: <20230409152529.5308-39-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|CO6PR12MB5393:EE_ X-MS-Office365-Filtering-Correlation-Id: 6d45e3a8-4eb8-4c81-aec3-08db390f1ef1 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lMjMd+hDGxhnjjwLajOg7AaFAGzp/kTkkECgl0EdNdgl4gececS9ggbbXVh4dYYbfYYBlVhzdx+0iDyCAVkA5cA0Cx2bJp/OUbQB21GOQBNXfmabTwDsMuJDE9/aKZ+MVZSf39gmd7JDNr1K6GH3r+a/MzbjPuIcLU32LXbUh/8vXqOpyH1oGh/VEAci6CctKSEnn90f5FqmI8AAjmxbX9PdF7lqSZLz8G+MgoErsKQSfQDOc+oDtaDvmwAZ+XX34Iw74ilOzBgMbMI7/ndmsSO88diF81s7JWx4qx1Q43r4whYUKZPUM57fZSq7kwzs57wqo87oP+XTrrsPWjqIEUdqDqLALBh774CNEq280flDsjOL52ENPgdfu1bFZGH2xGfYt55AUO9srkTV6zGlfy3SYovozUZEszMSQFbILf21HBvnpFFLLb94/hn5HZbcXaXIv5qpRPSymrWJ4rRFsYpIWccTmuEFbqgn4ADb/c4O5+dpA2eGaoklleBkntpNs7IXwedFxwZE8zKveHDRClBiv6mdT6i/uq75rDgFgEIJ3wr9T/aMpb26nkSIoVzxnN29WMforXVIwUtP+7yNDiJeCJifaUARfnbvrjAffFuUk8SOF/OWsa3YhVp2Btg5n5eCM7GtN8gQZ/DH9WR10dnG8pY4CWtDzCen9XXePJWeJvF0v1df38SB4D9fObX/nT67BC1RcU2RSITFmcOdX4lKP+LqlTKola10XzOg+FqZLUGuRDIchjjr+W+xc5J2rMYqeIuuhm3CkdOyFCT6U7uc+K8INhKi1NQBQQ63J25ke669KEXKGk0sR20gO/7qUj3XDiVAw7+DcV1KB/9Fiw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(478600001)(7696005)(54906003)(316002)(53546011)(1076003)(26005)(16526019)(6286002)(186003)(966005)(2906002)(4326008)(70586007)(70206006)(5660300002)(8676002)(6916009)(41300700001)(8936002)(82310400005)(7636003)(356005)(82740400003)(55016003)(86362001)(40480700001)(36756003)(40460700003)(47076005)(83380400001)(2616005)(426003)(336012)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:28:50.7474 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d45e3a8-4eb8-4c81-aec3-08db390f1ef1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/aaa501436cdea8d1b5106a4308895ef216a187a9 Thanks. Xueming Li --- >From aaa501436cdea8d1b5106a4308895ef216a187a9 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 28 Feb 2023 18:02:30 +0000 Subject: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Cc: Xueming Li [ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ] 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to user via ethdev APIs but it is used internally to set "stats->rx_nombuf' which is exposed via ehtdev stat APIs. But telemetry exposes this field to user via "/ethdev/info", instead user can get 'rx_nombuf' value from stats via "/ethdev/stats". Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index a40d396677..b9c8f79f8c 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6039,8 +6039,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu); rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min", eth_dev->data->min_rx_buf_size); - rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail", - eth_dev->data->rx_mbuf_alloc_failed); rte_ether_format_addr(mac_addr, sizeof(mac_addr), eth_dev->data->mac_addrs); rte_tel_data_add_dict_string(d, "mac_addr", mac_addr); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:39.767644700 +0800 +++ 0038-ethdev-remove-telemetry-Rx-mbuf-alloc-failed-field.patch 2023-04-09 21:45:38.619042200 +0800 @@ -1 +1 @@ -From 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 Mon Sep 17 00:00:00 2001 +From aaa501436cdea8d1b5106a4308895ef216a187a9 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 3814c202cd..3d137523a6 100644 +index a40d396677..b9c8f79f8c 100644 @@ -29 +31 @@ -@@ -6642,8 +6642,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, +@@ -6039,8 +6039,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, @@ -31 +33 @@ - rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min", + rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min", @@ -33 +35 @@ -- rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail", +- rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",