From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C68EC428F8 for ; Sun, 9 Apr 2023 17:25:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C14634067E; Sun, 9 Apr 2023 17:25:57 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2084.outbound.protection.outlook.com [40.107.243.84]) by mails.dpdk.org (Postfix) with ESMTP id 5028640141 for ; Sun, 9 Apr 2023 17:25:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYL18GqW/zuCdfj4mIAmBvainfn+uBdOUeQ4laWOQk5kVBHTdwVt4HUnG7Hq6pgIYDsW1UhPDMm24kmDs6LdMps2NfB3HNbsVRA/27LK7TphL9Y+kyufh9LOA9Kbyp4EkqCf0L937VwmjuksLQfl5DiZMLzwcrgXus5ilkLqw6nCBrdR4tyVSu1pIJqrHgyJOxVkelmyf08axWVShTyoVHCdCC01+sKE5VQLbMN5Jr2YbBkBSUzZMpx+Vz8sNNBZZDhvX2/CJYUJz7um/aioHyKQ5by6T2brK/KUYivGnws/TFp5zv2GUDVi/8WEbN6TY57JBj5QTTHtPLM74x0Aog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HaJi3cwoTrpe965gQcMutxPlUxmoMe60Gaylao307QA=; b=gFC0eSBGdTDi4x+nZFx6zjQyucTkQhgOv+U5YBc6AL3zp47BRVtb22S+yvuUP5IadTSqCIBoH/X2oHOfLbcqlWxkrVvKg8LIa57/5s0bH9E0Iti/ztijT2kPiBTeJvYL4izLXflzeryJW/J8u0t99FsFxjn7d7sVGEt5YDokNeB3OTk5a41AO2/fA0VhPYajdnXFVhPCKap/ySqre3N7M4JTKgYARcamlbD1lkOXRrinChe163nXPXue/nuIL9w7MgvAQ5/TW94fSLWp27HaCB91dqxXqAMpeSWAQfwkOme5MhXtOaV1qxNE8Xl51/xX3oL+Ru3W0PCgXCWLQ8YRmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HaJi3cwoTrpe965gQcMutxPlUxmoMe60Gaylao307QA=; b=O1/RWIarIQzgyzO+T0ELd49vAVaZDTYH/hID12p9LeRQeNFP0zdBrFR/7aWJfzMVHqLHYZbXxd0c9tRpDXO7RvolcSIjJ99D/JGZ8mgzuMUIuNp78lS/fDMa2cRKWDKMMjsX+opHw3cRwsj8FH4TWZCZrY0zB1d/ExIk7g5+q0jOinzh82wUBg7VSvBiup9WdjxVESB1DWBCej+QGmQEh1LOffbDKI9eFv/cvMWCy1JdSCuj3JdWT4CEJkppNjLOqNnU5mO6XylESzjMP0B1j43MN5RPAxdflGF2ak+PEzkKN5xMOaczQXWZslxe0hG20yTDmlHO4pf0kt1qsQBNpQ== Received: from MW4PR04CA0120.namprd04.prod.outlook.com (2603:10b6:303:83::35) by CH3PR12MB8281.namprd12.prod.outlook.com (2603:10b6:610:128::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Sun, 9 Apr 2023 15:25:53 +0000 Received: from CO1NAM11FT015.eop-nam11.prod.protection.outlook.com (2603:10b6:303:83:cafe::50) by MW4PR04CA0120.outlook.office365.com (2603:10b6:303:83::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:25:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT015.mail.protection.outlook.com (10.13.175.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:25:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:25:52 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:25:51 -0700 From: Xueming Li To: Thomas Monjalon CC: Tyler Retzlaff , dpdk stable Subject: patch 'eal/windows: fix pedantic build' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:23:11 +0800 Message-ID: <20230409152529.5308-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT015:EE_|CH3PR12MB8281:EE_ X-MS-Office365-Filtering-Correlation-Id: bf5de0f7-0871-4c40-dd5a-08db390eb52b X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7jiAvJIA1ZAw9b32OnHKp6dXu42Oom/xFf2xe9eU3uIyNjliG1SxIZyRMYnEgJx4gPEE+KOIK3yBAtLwyH+sUzNqVVG1O2Q1xdGedPuZmkLcoJM/fIFfZ0H1iuIyKDZIQ1tzlXzk7+rpYiAwgnD92I9qI71KmdA5lf8Uh8HRZ6ln6hTZped6qVCKUR14GBYfwe1YVQyho5Y90qEQUIcFFyS4ddVF2oqVRDalIcfq3qapznhq/m+Cvt3JlGddZxQEmO5nyqr3rpBSzM1qkUauF7mcwAdbCNxJ0/qLAuocLKR54MCsmNsEdU7axXvZOW1riVTItBYsMubW5s63bxDjYIlGrYBfeZWobTkqX2qzzhyHFXvRFHafoZS6Gg6Dst2RQYr4nsyXFqEtItiv4uRaIesbZDw03ak/l5BRAs0gv3FrDpP5Hzojd+XN2K1k0wZ3y7OUi2zymCOUCJ2teMBGv8pE8stljlaycmgyVz99+XNYv99+DAPRRQP6ISgmCt7V3Vls1z+X5Dj9SXN/Wj9yAuF8A/qmeDWV9CVq5lF3foXcTGCN5b+pg/onZTCwhPIVSe5TsKbAwsq3WkH7RE3Psycdh70HDhegDbWAdsdgjdd1rPkZNd9fJ+jcMvKOmlOCs8MCaTmLgKoj49gQ+jmZg2vr8wfd6Vkt5TT5qbdOrCo1W0BXbdFJVpW6k51Rc78Gf/ea8A+3hznPr/Ds5Kvy4WUhgwIWmP4GQ5K/zTSJr/Kidd3nICIPT22hLysLCrsyb2dtGDaaoQJKBur11OHzKtpHpYIaTGbni500zq+fSTO8GkCJlKwgFC6262E9TUZG8lb1ROjLWyDFsCmiEV737w== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(36840700001)(40470700004)(46966006)(7696005)(478600001)(86362001)(55016003)(40480700001)(83380400001)(47076005)(36756003)(40460700003)(82740400003)(7636003)(356005)(2616005)(36860700001)(426003)(336012)(6666004)(966005)(2906002)(54906003)(316002)(16526019)(6286002)(186003)(1076003)(53546011)(26005)(8676002)(6916009)(41300700001)(8936002)(5660300002)(82310400005)(4326008)(70586007)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:25:53.3839 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bf5de0f7-0871-4c40-dd5a-08db390eb52b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8281 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/300d83b989758cd2f85c206b578d207072ce178e Thanks. Xueming Li --- >From 300d83b989758cd2f85c206b578d207072ce178e Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 5 Jan 2023 16:18:38 +0100 Subject: [PATCH] eal/windows: fix pedantic build Cc: Xueming Li [ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] MinGW GCC 12 shows an illegal pointer conversion when included in a pedantic module: lib/eal/windows/include/pthread.h:137:41: error: ISO C forbids conversion of object pointer to function pointer type [-Werror=pedantic] 137 | hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, | ^ By using uintptr_t, the compiler is forced to accept the conversion. Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros") Signed-off-by: Thomas Monjalon Acked-by: Tyler Retzlaff --- lib/eal/windows/include/pthread.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/eal/windows/include/pthread.h b/lib/eal/windows/include/pthread.h index 27fd2cca52..f7cf0e9ddf 100644 --- a/lib/eal/windows/include/pthread.h +++ b/lib/eal/windows/include/pthread.h @@ -134,7 +134,8 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc, { RTE_SET_USED(threadattr); HANDLE hThread; - hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc, + hThread = CreateThread(NULL, 0, + (LPTHREAD_START_ROUTINE)(uintptr_t)threadfunc, args, 0, (LPDWORD)threadid); if (hThread) { SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:38.923433700 +0800 +++ 0003-eal-windows-fix-pedantic-build.patch 2023-04-09 21:45:38.569042200 +0800 @@ -1 +1 @@ -From 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b Mon Sep 17 00:00:00 2001 +From 300d83b989758cd2f85c206b578d207072ce178e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4ef69b2877a24ddb89afaf4bb6f4e73bb52a605b ] @@ -18 +20,0 @@ -Cc: stable@dpdk.org