From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7600B428F8 for ; Sun, 9 Apr 2023 17:29:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DEF4410EF; Sun, 9 Apr 2023 17:29:29 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) by mails.dpdk.org (Postfix) with ESMTP id 9ABE7410EE for ; Sun, 9 Apr 2023 17:29:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRoradmmsDwCCWPKvKi/WvRMIn+EgyE9eCJQhT5qHF9I5ZtTnTLH8vp5DXrJZLlNlbxM+AkNv24lynQ1rV9p5wfDLuamZnnr9n2MuHijpx8eFeMelt+GZf9mbOoZuB45lfL0zqAN5xiI6XlQAVFmsvhjL8uvUuHatTr2KdsR7UT5f9uf610Ai+5Hf1J9d6VTIH1VuprO/NnxjB/mUf6Dk6XTQAqyWw1RmVkxyER0UwMopXRd8DzCh1vYjFgU4zvdDYMfUCECYr0cycIGD5QoUfh36OoAByirFuXgmhreHCzjnWVb83TaU3UBkaLv3DrIZei9aioLjd9SiwSksXwXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PgHCrZOVRL9kR8sJzBnZXFUIg/5hc/MoRcrIvSMgdiU=; b=Dm+ffHHdoVJ1GF5p3M7pJYRkUPhfJ9YuIKdTnA9elFCihafo3ccIsofkbX0PGaDjOBxXxW0FqpC2PVi6eYlQrGZSr6zV0EDMopk0wHynPmW4a5GKyZoFGGinXM4bJptAJYVbYw2cNZh47Tg8t82rkzB6TgeNCiaITFkHDdRJvwlu2JG8l+F+ib9PQspp1lzZs3Y/vj5WsfoiFUOQcIbN1nQX7p4d8QL1IkzCsIuCp+/1Z2fEzCUtD8KfSs6a6zFPucxfkO2bGR1J/x61dbc/IKKsmltKihEXzHGrWQDl903+XYshb4AskNlbq531gZa+P5yH0/zaVwz8HGza9Te0KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PgHCrZOVRL9kR8sJzBnZXFUIg/5hc/MoRcrIvSMgdiU=; b=kp6/vbSlLXxGdVqozvNbix4SACQDo7uoMU3bNqTwh4zgk/frCdxdnIVI6yse3aI2s3Q/SLs5Z6CqQjte0OZrq77q7Nf1LcEr7BM8xY4QKhfzmDMfLT1ueMsazND1gtcg34xwORPbmT3WI2BrXm6oOlCCeZp4yptY8twRC06dKm6hK2yeoGDbtkR+j7L6appDbkpiJUF6Er8+QTkucEUoB1Eryo7pS/K3pI+hWbjJjd9P+Ta2Q79gyOuSbEtUTSEokISWGYyB+CAXMTR+iT5lTmSx9xB34bTgiOINXL1UGTjZalmO3qe371izN73ImIrcPTxa9LEWPf7+obfwrzhENg== Received: from BN8PR16CA0012.namprd16.prod.outlook.com (2603:10b6:408:4c::25) by SA0PR12MB4416.namprd12.prod.outlook.com (2603:10b6:806:99::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Sun, 9 Apr 2023 15:29:26 +0000 Received: from BN8NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:408:4c:cafe::94) by BN8PR16CA0012.outlook.office365.com (2603:10b6:408:4c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34 via Frontend Transport; Sun, 9 Apr 2023 15:29:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT050.mail.protection.outlook.com (10.13.177.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.26 via Frontend Transport; Sun, 9 Apr 2023 15:29:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:29:10 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:29:09 -0700 From: Xueming Li To: Chaoyong He CC: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , "dpdk stable" Subject: patch 'net/nfp: fix set IPv4 flow action' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:23:48 +0800 Message-ID: <20230409152529.5308-41-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT050:EE_|SA0PR12MB4416:EE_ X-MS-Office365-Filtering-Correlation-Id: fa557f63-f0cb-421c-f49d-08db390f33b3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQ/medqOLKZBhODQs4yEbjmoxdR7dVvnHyoW7F3YQddlznHxbe9ZFIeEllZLzfZ+ycTzs2xzOjLisukyA5QOQG3kUbqLfXv+7fYs22+mps9ejsXMHnH6Bg5U19irZnEiL6SuVKw22sb3OS2sDJkI44thNMKq7rxqhyMnRbMHyY8SPDUofv2NNzmsmpKUsMhERRSx/a3rIe3+fQFnuJptSjhiItkxFEMU9xr13QMJI/fJjlMbAW3bkeSpJ/Ccmzm+jFZ6zDdNvIdrKWepnziVYWAccd4TGXtfD6oxc/nRvfTKcS7ICZql2DrydkfghMYMe+wc9OfY06KS5sgLlV/mN2MFlPknPPdGe0h2xsycvCftkAqFssHrbPFYz2oLfstkqVbVm8ktJKnL3MOtPGpdqBi5WcA3Td52AOq/LIyh+e56dkqhBUTbiM+Fb/thcaOGm+e1FMHzR2+OcrAVramdd10xwGnSI54hmKMKc+MZGa0LE2zDhInpp2lErIruf6aM4pCTSO1beiO+j3exFXFL8OsWocvKIjN8jd1kMAUFPYP7mwkT/MHKRvdjVTtDc3vaHW+dr08CwIjUQjtGJVXEsR/mt7bSdu69VBVMJ3ht47o5g4Th06FYX8GEiR0zJj3hIgJZ19L6qx/Nxvpu+qtDnwaX8EWfqJSKIvaCnB3xgxRtD9EmqyrPEmIpVIXczDIQdznMY8v4TjXLzwPbYeI71OsqWyYQQVxXEVNqOeruCZbAmMyqE6kFiaEh8igLPdn6FLeBskD38mbmWWggRmaCg5L43tH6GU5yqkin36F7adpayQUxKfnqv/bfRBiFevWi/YlcC9dVRM6bSuPysdDOcg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199021)(46966006)(36840700001)(40470700004)(40460700003)(966005)(7696005)(8676002)(6916009)(4326008)(54906003)(478600001)(70206006)(41300700001)(316002)(70586007)(86362001)(36756003)(66574015)(83380400001)(47076005)(2616005)(426003)(336012)(1076003)(26005)(6666004)(53546011)(8936002)(5660300002)(2906002)(82310400005)(55016003)(40480700001)(82740400003)(356005)(7636003)(186003)(6286002)(16526019)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:29:25.5750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa557f63-f0cb-421c-f49d-08db390f33b3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4416 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/d6fb8fc9c1378209e92e0d7b04012787c0dd671d Thanks. Xueming Li --- >From d6fb8fc9c1378209e92e0d7b04012787c0dd671d Mon Sep 17 00:00:00 2001 From: Chaoyong He Date: Tue, 21 Feb 2023 18:35:09 +0800 Subject: [PATCH] net/nfp: fix set IPv4 flow action MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit d4b453c42989eb689392fccc7d4b0bc5e1499470 ] The former logic of set IPv4 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4 address as expected. Fixes: ab80975b0a14 ("net/nfp: support IPv4 source flow action") Fixes: f85c1e05bff3 ("net/nfp: support IPv4 destination flow action") Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 51862d73d8..14c949d730 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2121,10 +2121,13 @@ nfp_flow_action_set_ip(char *act_data, set_ip->reserved = 0; set_ipv4 = (const struct rte_flow_action_set_ipv4 *)action->conf; - if (ip_src_flag) + if (ip_src_flag) { set_ip->ipv4_src = set_ipv4->ipv4_addr; - else + set_ip->ipv4_src_mask = RTE_BE32(0xffffffff); + } else { set_ip->ipv4_dst = set_ipv4->ipv4_addr; + set_ip->ipv4_dst_mask = RTE_BE32(0xffffffff); + } } static void -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:39.816181600 +0800 +++ 0040-net-nfp-fix-set-IPv4-flow-action.patch 2023-04-09 21:45:38.629042200 +0800 @@ -1 +1 @@ -From d4b453c42989eb689392fccc7d4b0bc5e1499470 Mon Sep 17 00:00:00 2001 +From d6fb8fc9c1378209e92e0d7b04012787c0dd671d Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit d4b453c42989eb689392fccc7d4b0bc5e1499470 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index f373171d7e..39493ce98d 100644 +index 51862d73d8..14c949d730 100644 @@ -28 +30 @@ -@@ -2132,10 +2132,13 @@ nfp_flow_action_set_ip(char *act_data, +@@ -2121,10 +2121,13 @@ nfp_flow_action_set_ip(char *act_data,