From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A9DC428F8 for ; Sun, 9 Apr 2023 17:30:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95CE642BC9; Sun, 9 Apr 2023 17:30:18 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by mails.dpdk.org (Postfix) with ESMTP id 2DAB5406B8 for ; Sun, 9 Apr 2023 17:30:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZE7/EW5WpKVQJaHb5TtILwEs9zFutoT1qx4u3HO7YisnnPdri0KfWXMtTlKbxChCtk4Ek6XwYPQ+jG1ukuAKFtZabArHKVGq6kzLA1Vcg+iSUHB4vH9xgAk9oq91OAoKWR/6oKtEftKGQRn7aLoTIcbTl7ld/VkrtBgKQNJ//cDFVZ4Nsy0wlnAq1SxA8fodKQBzKM3D3w/tbcoa4DBY4GXm/XAqrK/p3Vzl+y8ukXd/4OLQkS643I/dHG2c1uoisigwOPnTKibz3DnlCA2aqgGuRL610iQuzzv1MxyXCJwAZmwm4DMtkGAJp6wfTBhB/B2QvvHozfBJCQniO603w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qsKc3TdM2K3qpGlrfauCfRXislZw9o4+6T7S8P0NQJc=; b=W7Muupne9MivIFptPeMn3lsznMC63cSvXSFVCcJPqISv9Y//J6bUpshVaziBLY0pQi7T9yUT5qfJEVGPEuKP+BC6rvhN4qAzp66MVwU84eAFjd5NrRJYJ8kwNjVgs3rV4gukvPr5o1LRM0Sd+6IDfshhEIlbLfkm3j3cm62c+jCt7ocRH4i3/xW/Qm9Lc514TAr+CfPyNUSUicj9myWErQ3R4blxY3cWB6d8SxDRpImeB1blv7AoIWDBPiIjgBg+jyexnrVyYYlS7/EbvS+yi6j01H7heALN9TLHUy7ZEgYiem8CkLCwEs+sFBEJabqO5/eu5EgkQ06ww7QBt+4POw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qsKc3TdM2K3qpGlrfauCfRXislZw9o4+6T7S8P0NQJc=; b=uQdM4UXERG3EHBnxyZ7lm4J1oabUUkre5kNyO3vZiUTjhzOYTMNq+H9C2JMZt/LjXzDhVsvMChkgv8ySAVkyktvZfbDvlUEAS3GvKMBwamIdYWIs2RJX3azPxO1TU6AHv0ElQpHTt/BlPLsJVwU5EP6cXr3o+uf0ekANp3SbsSeX3Okxnev9Bq7IAmgW3aodoYx22+c6hgEreJ0bqZF7AdhVVpopBW9BH5/vlsRDP4SafzAkj6/q1BlW02aCNAwoeZFD/zB3HK4qdENxozdsEBAQdVqSz75G6UpflFqJgmL0IbPrhtpEp+16rmg2bEAApRaW5a/9rmqnGwHprcIaow== Received: from DS7PR05CA0083.namprd05.prod.outlook.com (2603:10b6:8:57::29) by DS0PR12MB6558.namprd12.prod.outlook.com (2603:10b6:8:d2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.35; Sun, 9 Apr 2023 15:30:13 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:8:57:cafe::c0) by DS7PR05CA0083.outlook.office365.com (2603:10b6:8:57::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:30:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:30:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:30:04 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:30:03 -0700 From: Xueming Li To: Nithin Dabilpuram CC: dpdk stable Subject: patch 'common/cnxk: add memory clobber to steor and ldeor' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:00 +0800 Message-ID: <20230409152529.5308-53-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT025:EE_|DS0PR12MB6558:EE_ X-MS-Office365-Filtering-Correlation-Id: 047e26f8-08a5-4a05-a5b8-08db390f4ff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TbK3AdrvIoG3JI3kyrEAiVCYyjoYTRvMg7M7gD2nZDpy54Nnh3NsGxJb5ltD5nTAAliwHJQq0Ze1Yq44oAcRDek5X6OHkHJa7B6Lsw4H1e/wTNe4TeFHuFvwo9QrFALVstGPrTuCxmdx2DjjksplgMx2J2uEzqkZuh+aS8TDkBkDljoM+9wpWydVdXKDFvC4tY2bOWViib4vb+uIWLFh+QQLFLMQ/sVQkf3QZLQ+XUgngcqkIk71QFPduXaB6cGUZxP3m2UcVhjYdFUkX65KNzq0Az66rop4hnMoGwKvr/HYJ5EskTNqNllS9XALnDIu8ESGO8dLWNefSv5q/fHut0bITwJqRAyUIkFLY4TueydqVq5C5gIwT9tRrl9y5EKlcheRG02Zt1Z6com18Z6pIxey6aOF7+gFYLay84axkoFLjd3ItGrhpYJOIqhMZ+OdmaLtCthAVqbczFV8r2AIw1RADW1nWzBmBJH5ya2zKuIA6ZReUjcb9abLjCIt2Hjr7e5l3vdXpfvqv0q/LEmrfRqPRJKB9GYaidvJto58F6kPyku71mK1NGFCabJN4HM9ZUeQmsGCYXCwgtQhadn4RCM/StvdUhd3T/XrC7WHHFtCNVBTZ6Rh5kCPFUZ5a8BBoyF/MmCizdbwqkn/qLO12c1UdgvDBNUTGhMIC/X+6JLWwovD0FPo6JmcIP9X4nOkJNkBxTBTgUfzSTlmG1zCCgx3utKMSlK+xpMs1BH45oxzgAWNj70x2WJSQtmhEo+e0j7MG7busoNAVMDa0M6g1I/x3HBretSAV6RZj5H1jjV7Q4NxKthXhgnqWGgrNJyhl56WfxRLqBwNK6YFtlChNA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(39860400002)(376002)(451199021)(46966006)(36840700001)(40470700004)(82740400003)(356005)(7636003)(316002)(83380400001)(36860700001)(478600001)(8676002)(2906002)(8936002)(336012)(53546011)(4326008)(2616005)(6286002)(47076005)(41300700001)(40460700003)(70206006)(6916009)(36756003)(16526019)(82310400005)(26005)(186003)(55016003)(426003)(70586007)(40480700001)(86362001)(1076003)(5660300002)(966005)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:30:13.0155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 047e26f8-08a5-4a05-a5b8-08db390f4ff3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6558 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/fac8d80e0d4c450768804488c81e5f0b94c14c32 Thanks. Xueming Li --- >From fac8d80e0d4c450768804488c81e5f0b94c14c32 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Fri, 3 Mar 2023 13:40:12 +0530 Subject: [PATCH] common/cnxk: add memory clobber to steor and ldeor Cc: Xueming Li [ upstream commit a032b598b30daa9c2f01a6d7de07c87adba05dab ] To avoid compiler reordering stores to LMT line and ldeor, add clobber attribute to ldeor, steor etc. Fixes: 014a9e222bac ("common/cnxk: add model init and IO handling API") Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_io.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h index 13f98ed549..45cbb4e587 100644 --- a/drivers/common/cnxk/roc_io.h +++ b/drivers/common/cnxk/roc_io.h @@ -125,7 +125,8 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "ldeor xzr, %x[rf], [%[rs]]" : [rf] "=r"(result) - : [rs] "r"(io_address)); + : [rs] "r"(io_address) + : "memory"); return result; } @@ -136,7 +137,8 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) asm volatile(PLT_CPU_FEATURE_PREAMBLE "ldeorl xzr,%x[rf],[%[rs]]" : [rf] "=r"(result) - : [rs] "r"(io_address)); + : [rs] "r"(io_address) + : "memory"); return result; } @@ -145,7 +147,8 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) { asm volatile(PLT_CPU_FEATURE_PREAMBLE "steor %x[d], [%[rs]]" ::[d] "r"(data), - [rs] "r"(io_address)); + [rs] "r"(io_address) + : "memory"); } static __plt_always_inline void @@ -153,7 +156,8 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address) { asm volatile(PLT_CPU_FEATURE_PREAMBLE "steorl %x[d], [%[rs]]" ::[d] "r"(data), - [rs] "r"(io_address)); + [rs] "r"(io_address) + : "memory"); } static __plt_always_inline void -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:40.123717300 +0800 +++ 0052-common-cnxk-add-memory-clobber-to-steor-and-ldeor.patch 2023-04-09 21:45:38.659042200 +0800 @@ -1 +1 @@ -From a032b598b30daa9c2f01a6d7de07c87adba05dab Mon Sep 17 00:00:00 2001 +From fac8d80e0d4c450768804488c81e5f0b94c14c32 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a032b598b30daa9c2f01a6d7de07c87adba05dab ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index 1e5c1f8c04..af1a10cd66 100644 +index 13f98ed549..45cbb4e587 100644 @@ -21 +23 @@ -@@ -130,7 +130,8 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) +@@ -125,7 +125,8 @@ roc_lmt_submit_ldeor(plt_iova_t io_address) @@ -31 +33 @@ -@@ -141,7 +142,8 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) +@@ -136,7 +137,8 @@ roc_lmt_submit_ldeorl(plt_iova_t io_address) @@ -41 +43 @@ -@@ -150,7 +152,8 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) +@@ -145,7 +147,8 @@ roc_lmt_submit_steor(uint64_t data, plt_iova_t io_address) @@ -51 +53 @@ -@@ -158,7 +161,8 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address) +@@ -153,7 +156,8 @@ roc_lmt_submit_steorl(uint64_t data, plt_iova_t io_address)