From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9D61428F8 for ; Sun, 9 Apr 2023 17:30:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4A804114A; Sun, 9 Apr 2023 17:30:47 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by mails.dpdk.org (Postfix) with ESMTP id 9D90A4067E for ; Sun, 9 Apr 2023 17:30:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+bPCJtHw4AeTFGwrvZ5gChmCcQccxkZfcQuJZk1bKgddp8v+WF6ldvklILHIQWXK1e05CR7D4cnEqvYIPl7S7pv7zYD0Gt4on6AKEhdQD8PZf0y0xLUhbHqLw9vmlPe9ZicvtaEorn7GoIaqNQKnJm80YdJUBkS5bpI3DIL5MTHG+1u5aDr9weLERkI4pgmAc4wxFZxorQCwvb6LOQl2a8gE8Bt4UNeFfrJj5k7GvRIn7xunAa8zWRGl6/i/Kn3d8P/0ngVrJzM8+fr+oFSOdWdCvXLPc2c/KJhdoYPrChPN15W/JEsqVHFbM1hH52UreItcZjsWDOAPiMupddNPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XoVzbGgSPo94Bti+biyl+FmUEKrFExLzZhEKPXH6hUw=; b=UytCGiw7Vw+80KDO7J5EVEDmjpUfrwVe29fZjmMlhNLJnrmn/AxVmcqT4CKYSyNBtixVBdlF/hZJY9aShNzQwjTC9n1KlZSpthYvqJ9VAtb+fPApTtE3rrEHZ7qUCnkYisLTA3R7iisnwEGWnmd8b+owCE+0xGjX0qmHYLGhfca5UXrmrdqQpDaKicxlNJL+KGbPdeS0LkVpuGSfVHgtww9x0kmmJuIBLAIiJMTUTgQjt6fjNkSvvCA4mO68hm55GUKbJw3mAN8L6Rk3cVnRgCi8jq5SR3JAX/VCPh5/IYRVw/cNZ+iK0FYA4bo09iWpUeqFMlNPJV5PlIQZuizzjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XoVzbGgSPo94Bti+biyl+FmUEKrFExLzZhEKPXH6hUw=; b=GX/GOUzA9mEazHsdXHbHMuiTWtz/ICmO0/nCuzbTsn0GcT9MWoXP7THVuztJm7HoVnUJwHEgI08VtypVbaetvd6/jWwJaR4qcJiZ4XmtrRb5iGRaAn1ND9Gkh3hmVpzU5ZxYIQaBJumoIXOx4H8uri6u4A+b7UyS5BtkxhYCV/QJ1Ej8mxLKc6TqyuqKP9Dr0ulQ5KKiM4t0SQrUYayzdxtpaKn57iYjx1olWLgbvrFen73478h6+T0V0VSjoz8WpvwVVz5moGdwfu6ammKyWSf6VLPd6sMoHDT6RTS1YtS/hgWmXy8YigUFntJ987FOrWsVY6kzmSulAFAblFUMew== Received: from BN0PR04CA0075.namprd04.prod.outlook.com (2603:10b6:408:ea::20) by DS0PR12MB7560.namprd12.prod.outlook.com (2603:10b6:8:133::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34; Sun, 9 Apr 2023 15:30:45 +0000 Received: from BN8NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::39) by BN0PR04CA0075.outlook.office365.com (2603:10b6:408:ea::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.34 via Frontend Transport; Sun, 9 Apr 2023 15:30:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT040.mail.protection.outlook.com (10.13.177.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:30:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:30:29 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:30:28 -0700 From: Xueming Li To: Chengwen Feng CC: Akhil Goyal , dpdk stable Subject: patch 'cryptodev: fix empty devargs parsing' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:05 +0800 Message-ID: <20230409152529.5308-58-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT040:EE_|DS0PR12MB7560:EE_ X-MS-Office365-Filtering-Correlation-Id: f808e618-9330-4fba-945b-08db390f627f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p6NecKme9LKweu0gYzggUj56VD5rWqyNMnhtg23MNlvgxnZXy42TsepTe7O00vVXUnM9cbes3fBRlYRGUJ9vzjx+R5cLsPjTkQX6SaTlwvEY1RV51DdL0HYEdsG+iZ6IXKxgqmmnktIX0q4dQ+3juMOGdeyTCevLr43n6LvscFvjatDebQD7xBOjAmXCN+KvLo6kpT5GxjY3YNzgYTTJx4TnhHXBdhK+nuZshT5uLE1h1lXplfKHG4rC6AdP+koner/W06CrPaAcqXSuQGGrLhvB7BFPShXE64x1S+8iAO8mx3HLXVoYY/W2Nwp+i91BqxZEkRuLCb5HTEcXSUYd+evlJYLbJ74GeVxqStLigC7N9vfkQNh9CSLwcmndOwj9QvcE2bPGEpyYIovqnYhpDHWgdvoV4cm+bWZl94yHaa60H+rT2gTXweSEquALkfvJMhr/qbF9P6agcgEXD61Mgp4pRGGTjABb2Li7DJsiBg2hByC5zoT0Rz4Jvl1c0HFQ7hqkNY9Jltu9UEhJwpvLfXWtHU7DUuAvl30Rnmgp7Msv3SelhvA5nxqSx9mBx4Sby0D9E2qDbpA0BhMIo8x1pIrF679ru24M0J5nlW8u3baa8krrHDv9Gd4c5jMfmvYmchJECG+4Yxebn66XhFTQ1TTB9eq10phvSxKaJNuL50AgT0cFumhoKhGQBy5rAVxjIz8/SygraV3OQ8b6HCbdtMYvW1wRK/uYwKIHrM2r+RwPjDLa3/Nr8c6excYSBqwtpjvMUQvN/7ecCKZaqG+cxL+4tEvmd8FCEcfQ/uaph69D0w9gyMJTLPOlXfLrZJIjlQ77OklNze1OTMcAMwO6vg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(2906002)(6916009)(4326008)(8676002)(70586007)(70206006)(8936002)(41300700001)(5660300002)(478600001)(54906003)(316002)(966005)(40460700003)(7696005)(40480700001)(26005)(1076003)(186003)(53546011)(6666004)(36756003)(426003)(336012)(2616005)(47076005)(55016003)(6286002)(82740400003)(36860700001)(82310400005)(356005)(7636003)(16526019)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:30:44.0846 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f808e618-9330-4fba-945b-08db390f627f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7560 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/63ba1d9f2c17245fd549c897536e1ecf2b4fe23e Thanks. Xueming Li --- >From 63ba1d9f2c17245fd549c897536e1ecf2b4fe23e Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:07 +0000 Subject: [PATCH] cryptodev: fix empty devargs parsing Cc: Xueming Li [ upstream commit 8146454c56636ba8af5263b57e1c4a9f67fd4a39 ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault in rte_cryptodev_pmd_parse_uint_arg() when parse input args with 'only keys' (e.g. socket_id, max_nb_queue_pairs). For a similar reason, this patch fixes rte_cryptodev_pmd_parse_name_arg(). Fixes: 9e6edea41805 ("cryptodev: add APIs to assist PMD initialisation") Signed-off-by: Chengwen Feng Acked-by: Akhil Goyal --- lib/cryptodev/cryptodev_pmd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c index 77b269f312..d8073a601d 100644 --- a/lib/cryptodev/cryptodev_pmd.c +++ b/lib/cryptodev/cryptodev_pmd.c @@ -22,6 +22,9 @@ rte_cryptodev_pmd_parse_name_arg(const char *key __rte_unused, struct rte_cryptodev_pmd_init_params *params = extra_args; int n; + if (value == NULL || extra_args == NULL) + return -EINVAL; + n = strlcpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); if (n >= RTE_CRYPTODEV_NAME_MAX_LEN) return -EINVAL; @@ -38,6 +41,10 @@ rte_cryptodev_pmd_parse_uint_arg(const char *key __rte_unused, { int i; char *end; + + if (value == NULL || extra_args == NULL) + return -EINVAL; + errno = 0; i = strtol(value, &end, 10); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:40.253461800 +0800 +++ 0057-cryptodev-fix-empty-devargs-parsing.patch 2023-04-09 21:45:38.669042200 +0800 @@ -1 +1 @@ -From 8146454c56636ba8af5263b57e1c4a9f67fd4a39 Mon Sep 17 00:00:00 2001 +From 63ba1d9f2c17245fd549c897536e1ecf2b4fe23e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8146454c56636ba8af5263b57e1c4a9f67fd4a39 ] @@ -18 +20,0 @@ -Cc: stable@dpdk.org