From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48389428F8 for ; Sun, 9 Apr 2023 17:30:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43A1042C24; Sun, 9 Apr 2023 17:30:51 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2064.outbound.protection.outlook.com [40.107.94.64]) by mails.dpdk.org (Postfix) with ESMTP id AB501410EE for ; Sun, 9 Apr 2023 17:30:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJA+DaaouIoyub1kMFfZgQOIdDUgAxmIT5cJ11DZjDtJPMG+B5X5Qpm1KFVW43BZHdsZQBpzL+LB6VNeXO+y+PjBxPV0xAI3MzZZI+kD//Nd9x/PdNkigZ4iDYbYnP8nXNxCqoYgJQVrZyZTzloD2XM8UIiB4HCnVPw0ApfzXZq68btBC+abZ2EnWM7SCCxW0m/s/0/WVQMSxTqzJHzJ2eUTsxWgxe4QV5Y4vMuHzYkniH4ZWoLsRtPX4jAWTaxc0WYraRq313jGoYI5DE+Wf3QigSql/J89zQx1giqeAqfSutaDDMForh7ePEYiHPsb6Ti/G7uUPi1RLIlA0AqidA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJlWPW6tpu+2jaNfialRrnnh6wXEuvWEJ3IPNGec3GQ=; b=kagXkNMVIulXnNTtmfRPwKSd0Pi3wnmyHmmt9ssCsdsYP5jnzZZbV4Aib0YbeNA0q+1t+rBnD12SUXOf2wuteA7H1PSDfUik70pe2qcjQ0HR8QUTCQ17F6KcwkUpdrXrf4s6a/GNgy6Pd1wTsrSyFSbp9yzNSnEKUxJUUYpmnxyppiVVH5y6luhqmrBfE3IyOYasV+bi/fxf7mMmGhWKWylXyYxdCPgRClEnzstCF2sbEMWlTOrq1qGj3UgIPBSES9b1iLjTzvlzfz8GUitqprZduBGVTXYh/6kKYz/cgYOcOeKDGhrJ95oZrKiex0jk8/AqeJhNY1HYSQLLk4CyLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJlWPW6tpu+2jaNfialRrnnh6wXEuvWEJ3IPNGec3GQ=; b=Na8L/vjPHayHQmqImL5wr++VAPQ47ySOJN+/NgcK7SARFlD7eJRdzigTchGzNJlHImxJkF0X3a9N6udHDbhrlsNsAm0UgM5ppe9fXDOj3/DrCOMKNjcR8OEMSC/Wcj/YRWM1FNtVwocLe+YB8FhzH1iYF/p0GC336JCVQ47T8T51FFiA6ZfbTjV+OTuJGBU5ANK0hSTDwsa76oGq2UHu9NezqtW6jUqA7snSo9c/TcrgLeMz52wzf+kzepURe9iEl6ly+8N4qS0NcTNJkUGC6kCsvz5m/LIwhw65zFDBMS9444BI2eyihgEJlNa85g/edgh0FSJTKlo7MpqVHAja+Q== Received: from BN9P222CA0008.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::13) by BN9PR12MB5097.namprd12.prod.outlook.com (2603:10b6:408:136::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Sun, 9 Apr 2023 15:30:47 +0000 Received: from BN8NAM11FT023.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10c:cafe::2e) by BN9P222CA0008.outlook.office365.com (2603:10b6:408:10c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:30:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT023.mail.protection.outlook.com (10.13.177.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.20 via Frontend Transport; Sun, 9 Apr 2023 15:30:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:30:31 -0700 Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:30:29 -0700 From: Xueming Li To: Chengwen Feng CC: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix empty devargs parsing' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:06 +0800 Message-ID: <20230409152529.5308-59-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT023:EE_|BN9PR12MB5097:EE_ X-MS-Office365-Filtering-Correlation-Id: ffbbaf05-a4c2-4e98-4b27-08db390f63c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RL+xf8z8TxlfrgPJ7UCqcZZbvu/ri/I/d5/2nW/qWIFfRZcUx3xbSwf2okxNZia4+Bz0BARztJX6yz6FBgCuOEwdQrf1PuR4HXcYheqzji514wiZhC5wxyAXlCQhwek56KZ5ovA+NeaLxZth1/i7KnkEmsP5P0EIM+5OsuiVo5ZDK+qVxi1W0jMrPJ6MX2lezUKInPVuaUQnkIircoQkajv9L/sCd1AQ4FdLqQOECB37qxGEGxppvpeSP54uy66iJgmvrqJlIwTL4AZTThlhQJpHrJPxi2FBkI+lRUhND8pXGAQOjKpXuKtMTQdQuUycYs7wt2zTHSW61h6npVr4YXANrdTl6GxM4bnIznRenjsD2ovL8tCiGHbbMbxWW2cjENwoy5eRNQnJEwPLsfyJDnhUj1jpYefl6Od/PT35vZDkVBSOQvUX7+PXx74/DoYb3UbWEjxCkuaS0KSoGz+cZi3dsAhRnOnJ96dIZQ08z1KL5n+MOWnQC7nSPIeSAcbNTOjURzwk+fRoIMiOK+ehqi57pWgPnB4VW/2Q7uBbGoBZOpI5dlHsHYRSc+2ZWr0PmhZj9vEsLG9ZxAnEM7aq8nMF4Kc6yrtsVEKfG3z2w9B3HCWZvknVH9t0oDTNsP3EG02dhcmu2f3dPYGaFwRVzrXl0C7XT+836dnSlB7pfjuUiDgLSqB0R1EZtaO02yuICfaSsp6HisMupHdK4akSczkjnl4rPbWV2oHaOrDsMoS898n5IvXP4KQKEhgq2iTfnRR0uy7tlcShoJyKzlHrEFqCAJL5r0LyObahgOLfwqLSlWi+6Ipbr0VdMR7NUkJUsVINbsHVKVdi0ZD/VhhXUQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(346002)(376002)(396003)(451199021)(40470700004)(46966006)(36840700001)(82310400005)(40480700001)(40460700003)(36756003)(2906002)(5660300002)(86362001)(55016003)(8936002)(70586007)(70206006)(41300700001)(82740400003)(6916009)(4326008)(8676002)(356005)(2616005)(966005)(7636003)(426003)(83380400001)(336012)(47076005)(36860700001)(1076003)(54906003)(186003)(26005)(6666004)(316002)(53546011)(6286002)(7696005)(478600001)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:30:46.1930 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffbbaf05-a4c2-4e98-4b27-08db390f63c1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT023.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5097 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/33b1cea25d77140ebfa518d312803803b02c56ac Thanks. Xueming Li --- >From 33b1cea25d77140ebfa518d312803803b02c56ac Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:09 +0000 Subject: [PATCH] net/hns3: fix empty devargs parsing Cc: Xueming Li [ upstream commit 8e9bd29995ddb1205d90291a684bcf71599d6623 ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. rx_func_hint). Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function") Fixes: 70791213242e ("net/hns3: support masking device capability") Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time") Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c index a0c9e66c2c..f077ef5057 100644 --- a/drivers/net/hns3/hns3_common.c +++ b/drivers/net/hns3/hns3_common.c @@ -163,6 +163,9 @@ hns3_parse_io_hint_func(const char *key, const char *value, void *extra_args) RTE_SET_USED(key); + if (value == NULL || extra_args == NULL) + return 0; + if (strcmp(value, "vec") == 0) hint = HNS3_IO_FUNC_HINT_VEC; else if (strcmp(value, "sve") == 0) @@ -203,6 +206,9 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args) RTE_SET_USED(key); + if (value == NULL || extra_args == NULL) + return 0; + val = strtoull(value, NULL, HNS3_CONVERT_TO_HEXADECIMAL); *(uint64_t *)extra_args = val; @@ -216,6 +222,9 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args) RTE_SET_USED(key); + if (value == NULL || extra_args == NULL) + return 0; + val = strtoul(value, NULL, HNS3_CONVERT_TO_DECIMAL); /* -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:40.276437600 +0800 +++ 0058-net-hns3-fix-empty-devargs-parsing.patch 2023-04-09 21:45:38.669042200 +0800 @@ -1 +1 @@ -From 8e9bd29995ddb1205d90291a684bcf71599d6623 Mon Sep 17 00:00:00 2001 +From 33b1cea25d77140ebfa518d312803803b02c56ac Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8e9bd29995ddb1205d90291a684bcf71599d6623 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org