From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EC8A428F8 for ; Sun, 9 Apr 2023 17:31:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58F8D42BAC; Sun, 9 Apr 2023 17:31:16 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by mails.dpdk.org (Postfix) with ESMTP id BF1B14067E for ; Sun, 9 Apr 2023 17:31:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R24GXLjRO/d0dyshAORNXP9BAQz/+4tg0EqGrPwj7NrPRT30ttYS8vH2+LvuSWgVBQMJEc2MQfae80vM7B4zy1ywL90Lmd2v0KB/I7c4duYRSCFrKF6mFAQ3cNgNSN62goK5CT7pOx/AdC5YFayrhDykpJ8aosOGR1LZBmolS/RHsu0KnmUquav1h0BDOGOif6/5z8fzG8smj3nCG+69qUo9lw6gQsDGisz5kzrpeSA80iLsT6brinKoBBl3JFEeDMQFnGz9sRiPAsQQMHJliF/xydtoW3/NOKZRW8vmRxmMJo37SauS7UCfyP0UVml8sL8lMCwn9lVf//ClyL0k7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1zh0ez0zyWVKvy3qLTrIZM/RFx/YyKS/RUo3543nCU8=; b=doHQRIygFkOZvAIvatYc3TPrHmOeOsfQi329faOepGhineOhaVdavBcXqWwzfpIj0OWuZRxU3iNYsk/gCMbv7qmzc+jP2pClLWjRuC02Kv3QicUfWXHgMA3eqE3yXAZWfYa+9mu+P0z6ha2wl78BNeCBTdXnTdB4ovatBZrIHGxxK7MVnPv3Ju9O/TL9J2qiE5BwA1uJLQTcpmCgKLgHvXfrV+MUsxDRSSSfj7Iv1gb0QCT5LH6yKKUaRXHP+L2Eln0TNv34VHOy6ZgELDfp8/BanjRBaoUH7gQogL6vhhmrcBDFLmV6Jhcx1JOi+RYk1VXZd/i0SVcAWwKbvDYWdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1zh0ez0zyWVKvy3qLTrIZM/RFx/YyKS/RUo3543nCU8=; b=SHneyj1wUDkH8Gn6Ar+7cnHka7HeDoE8onDLoFr+jXawhF7r5eUHZuJ9tQ3QzFBiuBaYCKjzY5b3gDpffCcn2q1F2IVMDpLM2qMt05k4YhQNoQBZvKBZi/74WymFa9c2bljMpvEl66/AaDKcCxN9wLJ3c0n1k8NcYiauqQt8hCrsX2CZc1Jhg7gRdHlh1fEw4aKBossaqISlt47STI80mjwoYx7zmDMVroLZyvohJN3+Dovx/HHO6zdEsCsyQhkMtnD6Xx9itnGdbkMdcCNnnfiuJmCvfvxKgi7sghik8HWATn+zacbkcXZD6aYjMTMEUYuS5OTmFNmVUysQIW2cYQ== Received: from DM6PR04CA0013.namprd04.prod.outlook.com (2603:10b6:5:334::18) by CY8PR12MB7537.namprd12.prod.outlook.com (2603:10b6:930:94::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Sun, 9 Apr 2023 15:31:12 +0000 Received: from DM6NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:5:334:cafe::bf) by DM6PR04CA0013.outlook.office365.com (2603:10b6:5:334::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:31:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT009.mail.protection.outlook.com (10.13.173.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:31:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:30:51 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:30:50 -0700 From: Xueming Li To: Chengwen Feng CC: dpdk stable Subject: patch 'dma/skeleton: fix empty devargs parsing' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:08 +0800 Message-ID: <20230409152529.5308-61-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT009:EE_|CY8PR12MB7537:EE_ X-MS-Office365-Filtering-Correlation-Id: 86607e77-c89f-477c-b974-08db390f72cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 25oAfxR77elbNCy+nU90PaGEk/r/xedZtcv1qjnvD8urZ3S5MjCLbj+kxXms7mHtPbVnaOWpXXRmr/1JT51CPvaukBfbl/M/yCcNQdfFugcs18rcHyrzVIFNt6U7Qe0TdLqjdMvg7PddoHmIpSIjcq9CLRBaATfqVwCEi5PqhRTETSRY7a2T9r9s6+/H9QQ41L97hmWtiHVt2dp59jsGFf4ptjxCevPcVRWS2kINyqZD/FO3FxSLffElghg8uEz3oN3wESTF0KD87U9MRLgqBk5DbjRDG2stdvcxHZn1lFTAxvfFxDAY7HbJKXZLvublDVwukWMMHAZhM0EHjNIwOozAGcgoML8W/Vkt60BaO953QxdH1z5uiobPbAr8vPIwbpBZhtAYNlGm7yEXPM4RXk871nlUwkPF380//AvxmgyoBB1Bf4Y0oC44vbYzrXAKkyjvjYarfgXQoZOSibF8xH6m1OG1wZd3TRk77bv4svlNHENzXa1s7muPesI4jxJWkFv87StOlzhA1TiwUKn2/4egorHuyJM6h163T/cT7ngUZn/WRzLc00LGF791dRJ7ee25gNUDNvQSLS8yDiinH8AgOWpX9Q/dZXHF0SM7bHmUS6rFPTHMA3RI8W/XslwThln7wMXfAU6uDzFmv9ZPWDT71SuUJNLf5Rq992Gn2RCcMx72Md6NfH3U87FtpLTTJUkN52u+dTILLshpYrh+m4FTbIsDEOqj5yY9yBPX83Syhx0sWrjpyzRo09CBk8/wEq53j4dSa7StiePbgnJnPtZk3JUZhHIJRMDS4IUDvg/H/SObK5VtdPl9P4q0b8ozB5NR3xQzJfHnpgCPqktpOw== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(36756003)(40460700003)(82310400005)(2906002)(5660300002)(8936002)(8676002)(55016003)(40480700001)(86362001)(966005)(6666004)(7696005)(1076003)(26005)(36860700001)(478600001)(2616005)(47076005)(83380400001)(336012)(426003)(16526019)(6286002)(186003)(53546011)(70586007)(70206006)(82740400003)(356005)(7636003)(41300700001)(6916009)(4326008)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:31:11.4897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86607e77-c89f-477c-b974-08db390f72cb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7537 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/0848681e9058955f794a52c02ba84501493e9548 Thanks. Xueming Li --- >From 0848681e9058955f794a52c02ba84501493e9548 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Thu, 2 Mar 2023 07:50:11 +0000 Subject: [PATCH] dma/skeleton: fix empty devargs parsing Cc: Xueming Li [ upstream commit e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 ] The rte_kvargs_process() was used to parse KV pairs, it also supports to parse 'only keys' (e.g. socket_id) type. And the callback function parameter 'value' is NULL when parsed 'only keys'. This patch fixes segment fault when parse input args with 'only keys' (e.g. lcore). Fixes: 05d5fc66a269 ("dma/skeleton: introduce skeleton driver") Signed-off-by: Chengwen Feng --- drivers/dma/skeleton/skeleton_dmadev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/dma/skeleton/skeleton_dmadev.c b/drivers/dma/skeleton/skeleton_dmadev.c index 9b6da655fd..daf35eccce 100644 --- a/drivers/dma/skeleton/skeleton_dmadev.c +++ b/drivers/dma/skeleton/skeleton_dmadev.c @@ -515,9 +515,15 @@ skeldma_parse_lcore(const char *key __rte_unused, const char *value, void *opaque) { - int lcore_id = atoi(value); + int lcore_id; + + if (value == NULL || opaque == NULL) + return -EINVAL; + + lcore_id = atoi(value); if (lcore_id >= 0 && lcore_id < RTE_MAX_LCORE) *(int *)opaque = lcore_id; + return 0; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:40.322382400 +0800 +++ 0060-dma-skeleton-fix-empty-devargs-parsing.patch 2023-04-09 21:45:38.669042200 +0800 @@ -1 +1 @@ -From e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 Mon Sep 17 00:00:00 2001 +From 0848681e9058955f794a52c02ba84501493e9548 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org