From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BFA6428F8 for ; Sun, 9 Apr 2023 17:31:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11D9542BD9; Sun, 9 Apr 2023 17:31:40 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2079.outbound.protection.outlook.com [40.107.237.79]) by mails.dpdk.org (Postfix) with ESMTP id 25C8B410EE for ; Sun, 9 Apr 2023 17:31:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dbn6w7AiYkWetAXWr29QwEf6vEVmK68UzkxesIu8I2uurmh5aKGTH+MIbfYK4PQnI79Q3fTLd4TiV7UU1+aOT06lvgdz/ZLZJ6Ot1QGTF88S7KaWUwujx0co5ij8+d6tGZ8memAkxDBnjH/m1fzyiupYG8RnfVc/yoJAyOvCF2Xlk9CsC/PGh5lOVPj3AApCucmhpEZFQCDw5E8lQaoW98cQWnsq++CA66d/IkwFS4tiDiPEXY7KyYn2x//jVCDEfHiBxpOoRXzg51GKQdtjQ4WG9BeDKLQGVszJwou97ccbZnp7GnvNfKjotDSnQom2HY2ycD+SCq0KDrFIxcuNvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ceioGjWBK3FNFWxRyjfs40t6HKTUT10J2inHuMEW7Y=; b=GsaznlG5MO/ReAeXTVjcJUiokCMAHWCDYYuTjwFXFa0pe+zVlquTeo4CLT8nWFu20D03rPq7u26SNUBHb92aB0+ZyZD0pNiePitUWGrQGjfwtzYA1vAPHN+HbZLAD1z2qdhaddUcsyfdZ7vHQlCUONsd7jgh6FI/IyjCOs3sZbp8YdpRSUozdu9mDXo3ThWL7hCDyQyMF2du0r4K/zaTROZVsEqOSsTp6qESWfFbu4wWklqZMDwZZjpFtRBPbHwYVZThmOvUkn3zSzkTizngAYIsF6xkAnZbNq1kPuOSY6yAaoD8j0hc0HyILPK8qHw/RQz1XdXYQLpCNXh++CxyUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/ceioGjWBK3FNFWxRyjfs40t6HKTUT10J2inHuMEW7Y=; b=jCH90iSW62VxgcFwfAoNXYYz2ZeUbAfjdAc2QhYyu+BT2XSH2X9uv6xEfXfzyV4RtVYlWlo2iCQxE2xc7Se8n5dAEPRVM+XPz6aLnymMXD628B/els756jgQimrMjIFxX3DbvGzPJdLoiAqnEW5mtWuz0GWAITosGHl41V50eyho4bMwq55nVP8Ldm5YjyeDJdrMrU3aa9pV46Oc7dAFgP5xAhsyUMk6/qauIkIbwR24TcqrKFVG04+X+i818ib6cwcVQWYlz7BB7FFw0AjYKlEvUJa577VRCiww3X4vbtorSB3Fv+7TIKNpV31NY9POKXvChHgamVM7Aqb4dE0bOg== Received: from BN7PR06CA0072.namprd06.prod.outlook.com (2603:10b6:408:34::49) by DS0PR12MB7780.namprd12.prod.outlook.com (2603:10b6:8:152::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Sun, 9 Apr 2023 15:31:36 +0000 Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:408:34:cafe::a) by BN7PR06CA0072.outlook.office365.com (2603:10b6:408:34::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.39 via Frontend Transport; Sun, 9 Apr 2023 15:31:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.26 via Frontend Transport; Sun, 9 Apr 2023 15:31:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:31:21 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:31:20 -0700 From: Xueming Li To: Stephen Hemminger CC: Chengwen Feng , dpdk stable Subject: patch 'cmdline: make rdline status not private' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:16 +0800 Message-ID: <20230409152529.5308-69-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT054:EE_|DS0PR12MB7780:EE_ X-MS-Office365-Filtering-Correlation-Id: e55a75d5-b176-4161-32e4-08db390f812a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AV5k8hKw9AY3TEVZnj5e2/kJBNdCEnujZMDUYTunAPgHlNjvQ18Xxu13ulDQ/byK6XaVbXS0MjGsgvpcQ+jQp3UIZvIj4tJXaURaNC0WOM4DkDsz4IiyQsT4UXa89dGxLIHYkZ22t1fU9tz7EQF3fh8L1wO00Irrb/5HF3RfBmEnG9HaF6r9ixZe/iVdwpAzwwqRqe6jXGbn9ssTV5gUJD1QMYw8IA6wqaT0ejaFiAgI7BH/gFS3WWXJ0lL3Le7KMRZyexLAP77bPDOVZNPK0MZb8AU0cuxOsmKUKZUFKUXl/jrvMItXB5rtMtJ9XfYpBUU9FKRoU8+xCirvvauGOBp/r7RkBaWXgfDWSnfZjLzo93yRwMw9OeGhmg/fFrkCPbk45v7EWIYtHK5MlmMsHd05Z1jganN8iJfnPspQULCbVfWbwfla0w1DU+4oLg5Kck4nEW0wtQq9xCVjVxuTqDodQKdoSrUc9AWBft5P42aNBOHH+J64MdilddD0aqu5qXE0fjyC5BUc8jS600yDphI2TADrlM1Uib9buEzpYuw3QzmCD05r//ZnHR60HXDtYWKm0AasxmaZipwy1KtH3pLGaIodbEWkN/97p9iP/4uyJsgIZyUfPk7+OXArMyL7vAjAZsrcFgp6RHtygykVie6g7GuRrv0PzuISd82UmCA1WZ0M+3/LyaZ1Fw9CYj6A4EWIX+MO1CTK5wzhYJhq5zsKipmmhKJrIHkc712yRp6B5hYaQu9i5kbDUTxjqpjM5+jazmBVN2zD+PrZHB0zHUrv5TohjYAcBySO8Y9/KZz3AOUL/RR/qoci1plUxPoGZ24a+5dOZH+nkRhzefxYvw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199021)(46966006)(36840700001)(40470700004)(55016003)(6666004)(8936002)(7696005)(40480700001)(40460700003)(966005)(5660300002)(86362001)(70586007)(70206006)(8676002)(6916009)(4326008)(478600001)(316002)(82310400005)(36860700001)(82740400003)(7636003)(356005)(54906003)(2906002)(53546011)(1076003)(26005)(2616005)(83380400001)(47076005)(426003)(336012)(41300700001)(36756003)(186003)(16526019)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:31:35.5345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e55a75d5-b176-4161-32e4-08db390f812a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7780 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/1a22081244a86a6f94dd90d9c8690df266fb0923 Thanks. Xueming Li --- >From 1a22081244a86a6f94dd90d9c8690df266fb0923 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 3 Feb 2023 11:14:07 -0800 Subject: [PATCH] cmdline: make rdline status not private Cc: Xueming Li [ upstream commit 1ac8dd1d1b62c59cd440e5529e3bd5a500e72f76 ] The function cmdline_poll() returns values from rdline_status enum but that was moved to being defined only in cmdline_private.h. For proper use of the API the return value needs to be visible to callers. This was not a problem before because cmdline_poll() was not used anywhere. Fixes: f8f8dc289095 ("cmdline: make struct rdline opaque") Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng --- lib/cmdline/cmdline.h | 6 ++++++ lib/cmdline/cmdline_private.h | 6 ------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 96674dfda2..b14355ef51 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -23,6 +23,12 @@ extern "C" { #endif +enum rdline_status { + RDLINE_INIT, + RDLINE_RUNNING, + RDLINE_EXITED +}; + struct cmdline; struct cmdline *cmdline_new(cmdline_parse_ctx_t *ctx, const char *prompt, int s_in, int s_out); diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h index c2e906d8de..a3271c7693 100644 --- a/lib/cmdline/cmdline_private.h +++ b/lib/cmdline/cmdline_private.h @@ -23,12 +23,6 @@ #define RDLINE_HISTORY_BUF_SIZE BUFSIZ #define RDLINE_HISTORY_MAX_LINE 64 -enum rdline_status { - RDLINE_INIT, - RDLINE_RUNNING, - RDLINE_EXITED -}; - struct rdline { enum rdline_status status; /* rdline bufs */ -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:40.517705400 +0800 +++ 0068-cmdline-make-rdline-status-not-private.patch 2023-04-09 21:45:38.679042200 +0800 @@ -1 +1 @@ -From 1ac8dd1d1b62c59cd440e5529e3bd5a500e72f76 Mon Sep 17 00:00:00 2001 +From 1a22081244a86a6f94dd90d9c8690df266fb0923 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 1ac8dd1d1b62c59cd440e5529e3bd5a500e72f76 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org