From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB66A428F8 for ; Sun, 9 Apr 2023 17:33:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4EC342BFE; Sun, 9 Apr 2023 17:33:37 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2086.outbound.protection.outlook.com [40.107.92.86]) by mails.dpdk.org (Postfix) with ESMTP id D0A294067E for ; Sun, 9 Apr 2023 17:33:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UG+d4jWMECCi/NT3YwC1TI2JUNQVsizF0s6HvJxpkNFT1sWHtWQOomj960y87lHPf8HgtERL10rNy9D4gaA8AECxTddravsIWOkPET030ikEyenXJJiqoFnQWb84yZlYB1o0Vcs+6zUUinJtNeDIfiTTgT4IDPi3Jx9FQ87TcUcWmlJlWrFYZCk1fuS5tSM6L/Awv6BOuNes8wpUyGrw6gUcZZpcyC3hbE1vXFVy8OAiglpNcfUMgbh+/qYFrD2e7yDxM07sJN8AQSAjd7FseT0x9TWJ9Qg77ZRb4kDSHh4YPpx4Qp8iUwN+IHJaqNT4sdFUKlgN2hQUJ2tRCgj2YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3YggllSUd7lj0C7875fCX39LYwc3+lZ70e8bh5Yh46s=; b=mwluk7dgxO5e5k51+hPSp1DOatOV0MK7x+K36wxkk/EvXiuf0nHaoKluE79dOMEQFvNxhdHNV2PyYjss7JzZMa08CCQVaPQAFKonDmtRKGGZczZ9tk7PdOqGT3TnOs7MD9ezwjt2+rBNUOZWE8SZUjWrhVUKdc/tct3i3/V+hRAJFlpjzDt0dkhLfK8XaemxwPhpk6MYNnqs39wr+vAgm6mC8WsAcK46YMZ0AM2StYI56qrbaqlAJKAHSorOKACY2YH13/HcvH+plTqAX1cPRP+7I2/ASzlgff4OY3zvhZRbF2k+bFOyVg5X07JqSor8Ls1OsyWtnwXvU1CwVYnQPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3YggllSUd7lj0C7875fCX39LYwc3+lZ70e8bh5Yh46s=; b=N4pZCXH/aB47OJZ4yp0Wc4q5a+uDqIQwIRQ3JkN4WveV0T9gR7x+D/fOMrxd5aEsiTRpRwjA8k46c+9bdK1ndn4akW046H7u6XbFD231Xa8zEaz2hNtEJMqxipP7Gcim3b6g+wsw19Z8fDL2NWswh5X076j88m2Z5vm0Ug7UBWdJHbJwIntczgdMXDS280dvnujvHpHd558suAF2KQPAvtjvzQGYxPmoFLL9sysio1d3IJsK7Bq6xitom9cI/MC77CmE4KhgZEiKNqPwjNB6nirER7xuw1iIUDEBO3w+w1oAbNCqN3CVelvTASqPq9ZZ40WnOt2wPtVeNTDfinqdPw== Received: from BN0PR04CA0114.namprd04.prod.outlook.com (2603:10b6:408:ec::29) by MN0PR12MB5786.namprd12.prod.outlook.com (2603:10b6:208:375::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Sun, 9 Apr 2023 15:33:34 +0000 Received: from BN8NAM11FT048.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::c6) by BN0PR04CA0114.outlook.office365.com (2603:10b6:408:ec::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38 via Frontend Transport; Sun, 9 Apr 2023 15:33:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT048.mail.protection.outlook.com (10.13.177.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.25 via Frontend Transport; Sun, 9 Apr 2023 15:33:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Sun, 9 Apr 2023 08:33:27 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Sun, 9 Apr 2023 08:33:25 -0700 From: Xueming Li To: Kai Ji CC: Ciara Power , dpdk stable Subject: patch 'crypto/openssl: fix freeing in RSA EVP' has been queued to stable release 22.11.2 Date: Sun, 9 Apr 2023 23:24:39 +0800 Message-ID: <20230409152529.5308-92-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230409152529.5308-1-xuemingl@nvidia.com> References: <20230227062349.13764-1-xuemingl@nvidia.com> <20230409152529.5308-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT048:EE_|MN0PR12MB5786:EE_ X-MS-Office365-Filtering-Correlation-Id: b7f010b7-ae3c-467d-f14e-08db390fc77c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2WEAtZ+HHo47IvrEMNcEAYiGLc7maB6bEUmkO/h6oWYpHQ5kpmOtRiN3lmkBamRL8jk4YOTJh6CAM2UoRz/uLmyAgFauqgSIBy+Y23aFkOT/cL524CWScP+zg9ZBqFujS1xlBAFvGv/YtJ+sDHGTHAHdIxyD8yg/wPun/FcCHkaR1726tMDV/lHcaMBgkGIgCu0m20S1B4V5q+jD0ezOExvqhcGUC6bjtYYXe3RYd3g2aBJJHW9y3seCOlDYDes0s9xU4e+eW6JGXR6pQ4yWsinDlr1lNvt/86kahEJQVj0mloBVus/aEXWOu/KRynOUspvb4s7N2FGGtmSz00KKKLFvjQmzYIc433XNK3OOtzxxbjhHOi8TkYomI0+f1Vh1bIGGqvGlyLdnYPHGBDO2oxM7nmp2zMkuuyO+ko8wMAqS65Eb3iCDW+RmxnraDTa9jrs5jqx+UEFWtUlkDPb56iI+ts7sbvzq+iBIOY7aFPO9kUn2g5z4Z+6Hdg5XzhCa775Buy4z1ZKCc/9+hZrLiVLrD+FmcZ49GMFqvKiR32d63xsduApE1YWIbs70Fo8U8K+P35KDvnz4O6y5LQ99GHzmAt9L3NECXLGGNcIoRt4StTWm1FzNYe8PWgRSYxp8xs4pRILubXFife7yahUAwH3YfYS2hQG5wfBBx29G8VKd2ZLLvkjS1EqbUsFEwfx3xM9CL8iomyRxO+XnzJ4FF46c0w9NpWL9VbsnVRuTIyET7N5PXwsnGIlM/kmKwSWLggCmNwfAurnGQZ0ZYY0ZG66uLj2qQPM++kYDe4RG90Sab5Yj9j9842UdsA53CwX06nRxS+/Swif6uHFQEcXi5w== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199021)(36840700001)(40470700004)(46966006)(7696005)(478600001)(86362001)(55016003)(40480700001)(83380400001)(47076005)(36756003)(40460700003)(82740400003)(7636003)(356005)(2616005)(36860700001)(426003)(336012)(6666004)(966005)(2906002)(54906003)(316002)(16526019)(6286002)(186003)(1076003)(53546011)(26005)(8676002)(6916009)(41300700001)(8936002)(5660300002)(82310400005)(4326008)(70586007)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2023 15:33:33.5008 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b7f010b7-ae3c-467d-f14e-08db390fc77c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT048.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5786 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 04/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging/commit/72c1da7b2d2c8b0726a34ed675658c965151508e Thanks. Xueming Li --- >From 72c1da7b2d2c8b0726a34ed675658c965151508e Mon Sep 17 00:00:00 2001 From: Kai Ji Date: Wed, 8 Mar 2023 22:47:48 +0800 Subject: [PATCH] crypto/openssl: fix freeing in RSA EVP Cc: Xueming Li [ upstream commit 4de0f183506c5fecbf0486780068c044b1711daf ] Fixed ASAN heap-use-after-free error on tmp buffer. Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index abcb641a44..384d262621 100644 --- a/drivers/crypto/openssl/rte_openssl_pmd.c +++ b/drivers/crypto/openssl/rte_openssl_pmd.c @@ -2633,7 +2633,7 @@ process_openssl_rsa_op_evp(struct rte_crypto_op *cop, if (EVP_PKEY_verify_recover(rsa_ctx, tmp, &outlen, op->rsa.sign.data, op->rsa.sign.length) <= 0) { - rte_free(tmp); + OPENSSL_free(tmp); goto err_rsa; } @@ -2645,7 +2645,7 @@ process_openssl_rsa_op_evp(struct rte_crypto_op *cop, op->rsa.message.length)) { OPENSSL_LOG(ERR, "RSA sign Verification failed"); } - rte_free(tmp); + OPENSSL_free(tmp); break; default: -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-04-09 21:45:41.096254900 +0800 +++ 0091-crypto-openssl-fix-freeing-in-RSA-EVP.patch 2023-04-09 21:45:38.709042200 +0800 @@ -1 +1 @@ -From 4de0f183506c5fecbf0486780068c044b1711daf Mon Sep 17 00:00:00 2001 +From 72c1da7b2d2c8b0726a34ed675658c965151508e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4de0f183506c5fecbf0486780068c044b1711daf ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org